From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
Subject: [PATCH v1] nvmet: Don't use uuid_le type
Date: Mon, 16 Jul 2018 12:59:08 +0300 [thread overview]
Message-ID: <20180716095908.7690-1-andriy.shevchenko@linux.intel.com> (raw)
Don't use sizeof(uuid_le) where none of the parameters is type of uuid_le.
Since both arguments are u8 [16], use plain number there.
Moreover, uuid_le is a deprecated type, and nvmet is using uuid_t
already.
Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
---
drivers/nvme/target/admin-cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c
index 38803576d5e1..f832be8245cd 100644
--- a/drivers/nvme/target/admin-cmd.c
+++ b/drivers/nvme/target/admin-cmd.c
@@ -308,7 +308,7 @@ static void nvmet_execute_identify_ns(struct nvmet_req *req)
*/
id->nmic = (1 << 0);
- memcpy(&id->nguid, &ns->nguid, sizeof(uuid_le));
+ memcpy(&id->nguid, &ns->nguid, 16);
id->lbaf[0].ds = ns->blksize_shift;
--
2.18.0
next reply other threads:[~2018-07-16 9:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 9:59 Andy Shevchenko [this message]
2018-07-16 10:26 ` [PATCH v1] nvmet: Don't use uuid_le type Sagi Grimberg
2018-07-16 10:27 ` Sagi Grimberg
2018-07-16 12:03 ` Andy Shevchenko
2018-07-17 13:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716095908.7690-1-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.