From: andriy.shevchenko@linux.intel.com (Andy Shevchenko)
Subject: [PATCH v1] nvmet: Don't use uuid_le type
Date: Mon, 16 Jul 2018 15:03:27 +0300 [thread overview]
Message-ID: <6259b86a67bc8530e2ca3bce26b7114fe78d1410.camel@linux.intel.com> (raw)
In-Reply-To: <27beef69-2f59-94dd-f592-a051a2cefcbd@grimberg.me>
On Mon, 2018-07-16@13:27 +0300, Sagi Grimberg wrote:
> > - memcpy(&id->nguid, &ns->nguid, sizeof(uuid_le));
> > + memcpy(&id->nguid, &ns->nguid, 16);
>
> how about memcpy(&id->nguid, &ns->nguid, sizeof(ns->nguid));
I suppose should be sizeof(id->nguid), but I don't care much as long as
it doesn't use uuid_le type here.
--
Andy Shevchenko <andriy.shevchenko at linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-07-16 12:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 9:59 [PATCH v1] nvmet: Don't use uuid_le type Andy Shevchenko
2018-07-16 10:26 ` Sagi Grimberg
2018-07-16 10:27 ` Sagi Grimberg
2018-07-16 12:03 ` Andy Shevchenko [this message]
2018-07-17 13:14 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6259b86a67bc8530e2ca3bce26b7114fe78d1410.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.