From: Johan Hovold <johan@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: mos7720: remove redundant variables iflag, mask and serial
Date: Mon, 16 Jul 2018 12:11:02 +0000 [thread overview]
Message-ID: <20180716121102.GM10204@localhost> (raw)
In-Reply-To: <20180713100831.29120-1-colin.king@canonical.com>
On Fri, Jul 13, 2018 at 11:08:31AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables iflag, mask and serial are being assigned but ar never used
> hence are redundant and can be removed.
>
> Cleans up clang warnings:
> warning: variable 'iflag' set but not used [-Wunused-but-set-variable]
> warning: variable 'mask' set but not used [-Wunused-but-set-variable]
> warning: variable 'serial' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Now applied, thanks.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: usb: serial: mos7720: remove redundant variables iflag, mask and serial
Date: Mon, 16 Jul 2018 14:11:02 +0200 [thread overview]
Message-ID: <20180716121102.GM10204@localhost> (raw)
On Fri, Jul 13, 2018 at 11:08:31AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables iflag, mask and serial are being assigned but ar never used
> hence are redundant and can be removed.
>
> Cleans up clang warnings:
> warning: variable 'iflag' set but not used [-Wunused-but-set-variable]
> warning: variable 'mask' set but not used [-Wunused-but-set-variable]
> warning: variable 'serial' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Now applied, thanks.
Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hovold <johan@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: mos7720: remove redundant variables iflag, mask and serial
Date: Mon, 16 Jul 2018 14:11:02 +0200 [thread overview]
Message-ID: <20180716121102.GM10204@localhost> (raw)
In-Reply-To: <20180713100831.29120-1-colin.king@canonical.com>
On Fri, Jul 13, 2018 at 11:08:31AM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variables iflag, mask and serial are being assigned but ar never used
> hence are redundant and can be removed.
>
> Cleans up clang warnings:
> warning: variable 'iflag' set but not used [-Wunused-but-set-variable]
> warning: variable 'mask' set but not used [-Wunused-but-set-variable]
> warning: variable 'serial' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Now applied, thanks.
Johan
next prev parent reply other threads:[~2018-07-16 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-13 10:08 [PATCH] usb: serial: mos7720: remove redundant variables iflag, mask and serial Colin King
2018-07-13 10:08 ` Colin King
2018-07-13 10:08 ` Colin King
2018-07-16 12:11 ` Johan Hovold [this message]
2018-07-16 12:11 ` [PATCH] " Johan Hovold
2018-07-16 12:11 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716121102.GM10204@localhost \
--to=johan@kernel.org \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.