All of lore.kernel.org
 help / color / mirror / Atom feed
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/6] mailbox: ti-msgmgr: Get rid of unused structure members
Date: Mon, 16 Jul 2018 13:06:02 -0500	[thread overview]
Message-ID: <20180716180607.16526-2-nm@ti.com> (raw)
In-Reply-To: <20180716180607.16526-1-nm@ti.com>

Though q_proxies and q_slices do describe the hardware configuration,
they are not necessary for operation given that the values are
always default. Hence drop the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Changes since V1: None
V1: https://patchwork.kernel.org/patch/10475339/
RFC: https://patchwork.kernel.org/patch/10447665/

 drivers/mailbox/ti-msgmgr.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
index 5d04738c3c8a..5fe6ce200264 100644
--- a/drivers/mailbox/ti-msgmgr.c
+++ b/drivers/mailbox/ti-msgmgr.c
@@ -42,8 +42,6 @@ struct ti_msgmgr_valid_queue_desc {
  * @queue_count:	Number of Queues
  * @max_message_size:	Message size in bytes
  * @max_messages:	Number of messages
- * @q_slices:		Number of queue engines
- * @q_proxies:		Number of queue proxies per page
  * @data_first_reg:	First data register for proxy data region
  * @data_last_reg:	Last data register for proxy data region
  * @tx_polled:		Do I need to use polled mechanism for tx
@@ -58,8 +56,6 @@ struct ti_msgmgr_desc {
 	u8 queue_count;
 	u8 max_message_size;
 	u8 max_messages;
-	u8 q_slices;
-	u8 q_proxies;
 	u8 data_first_reg;
 	u8 data_last_reg;
 	bool tx_polled;
@@ -494,8 +490,6 @@ static const struct ti_msgmgr_desc k2g_desc = {
 	.queue_count = 64,
 	.max_message_size = 64,
 	.max_messages = 128,
-	.q_slices = 1,
-	.q_proxies = 1,
 	.data_first_reg = 16,
 	.data_last_reg = 31,
 	.tx_polled = false,
-- 
2.15.1

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jassi Brar <jassisinghbrar@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Suman Anna <s-anna@ti.com>,
	Tero Kristo <t-kristo@ti.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 1/6] mailbox: ti-msgmgr: Get rid of unused structure members
Date: Mon, 16 Jul 2018 13:06:02 -0500	[thread overview]
Message-ID: <20180716180607.16526-2-nm@ti.com> (raw)
In-Reply-To: <20180716180607.16526-1-nm@ti.com>

Though q_proxies and q_slices do describe the hardware configuration,
they are not necessary for operation given that the values are
always default. Hence drop the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Changes since V1: None
V1: https://patchwork.kernel.org/patch/10475339/
RFC: https://patchwork.kernel.org/patch/10447665/

 drivers/mailbox/ti-msgmgr.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
index 5d04738c3c8a..5fe6ce200264 100644
--- a/drivers/mailbox/ti-msgmgr.c
+++ b/drivers/mailbox/ti-msgmgr.c
@@ -42,8 +42,6 @@ struct ti_msgmgr_valid_queue_desc {
  * @queue_count:	Number of Queues
  * @max_message_size:	Message size in bytes
  * @max_messages:	Number of messages
- * @q_slices:		Number of queue engines
- * @q_proxies:		Number of queue proxies per page
  * @data_first_reg:	First data register for proxy data region
  * @data_last_reg:	Last data register for proxy data region
  * @tx_polled:		Do I need to use polled mechanism for tx
@@ -58,8 +56,6 @@ struct ti_msgmgr_desc {
 	u8 queue_count;
 	u8 max_message_size;
 	u8 max_messages;
-	u8 q_slices;
-	u8 q_proxies;
 	u8 data_first_reg;
 	u8 data_last_reg;
 	bool tx_polled;
@@ -494,8 +490,6 @@ static const struct ti_msgmgr_desc k2g_desc = {
 	.queue_count = 64,
 	.max_message_size = 64,
 	.max_messages = 128,
-	.q_slices = 1,
-	.q_proxies = 1,
 	.data_first_reg = 16,
 	.data_last_reg = 31,
 	.tx_polled = false,
-- 
2.15.1

WARNING: multiple messages have this Message-ID (diff)
From: Nishanth Menon <nm@ti.com>
To: Jassi Brar <jassisinghbrar@gmail.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Suman Anna <s-anna@ti.com>,
	Tero Kristo <t-kristo@ti.com>, <linux-kernel@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: [PATCH V2 1/6] mailbox: ti-msgmgr: Get rid of unused structure members
Date: Mon, 16 Jul 2018 13:06:02 -0500	[thread overview]
Message-ID: <20180716180607.16526-2-nm@ti.com> (raw)
In-Reply-To: <20180716180607.16526-1-nm@ti.com>

Though q_proxies and q_slices do describe the hardware configuration,
they are not necessary for operation given that the values are
always default. Hence drop the same.

Signed-off-by: Nishanth Menon <nm@ti.com>
---

Changes since V1: None
V1: https://patchwork.kernel.org/patch/10475339/
RFC: https://patchwork.kernel.org/patch/10447665/

 drivers/mailbox/ti-msgmgr.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/mailbox/ti-msgmgr.c b/drivers/mailbox/ti-msgmgr.c
index 5d04738c3c8a..5fe6ce200264 100644
--- a/drivers/mailbox/ti-msgmgr.c
+++ b/drivers/mailbox/ti-msgmgr.c
@@ -42,8 +42,6 @@ struct ti_msgmgr_valid_queue_desc {
  * @queue_count:	Number of Queues
  * @max_message_size:	Message size in bytes
  * @max_messages:	Number of messages
- * @q_slices:		Number of queue engines
- * @q_proxies:		Number of queue proxies per page
  * @data_first_reg:	First data register for proxy data region
  * @data_last_reg:	Last data register for proxy data region
  * @tx_polled:		Do I need to use polled mechanism for tx
@@ -58,8 +56,6 @@ struct ti_msgmgr_desc {
 	u8 queue_count;
 	u8 max_message_size;
 	u8 max_messages;
-	u8 q_slices;
-	u8 q_proxies;
 	u8 data_first_reg;
 	u8 data_last_reg;
 	bool tx_polled;
@@ -494,8 +490,6 @@ static const struct ti_msgmgr_desc k2g_desc = {
 	.queue_count = 64,
 	.max_message_size = 64,
 	.max_messages = 128,
-	.q_slices = 1,
-	.q_proxies = 1,
 	.data_first_reg = 16,
 	.data_last_reg = 31,
 	.tx_polled = false,
-- 
2.15.1


  reply	other threads:[~2018-07-16 18:06 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-16 18:06 [PATCH V2 0/6] mailbox: ti-msgmgr: Add support for AM654 Secure Proxy Nishanth Menon
2018-07-16 18:06 ` Nishanth Menon
2018-07-16 18:06 ` Nishanth Menon
2018-07-16 18:06 ` Nishanth Menon [this message]
2018-07-16 18:06   ` [PATCH V2 1/6] mailbox: ti-msgmgr: Get rid of unused structure members Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06 ` [PATCH V2 2/6] mailbox: ti-msgmgr: Allocate Rx channel resources only on request Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06 ` [PATCH V2 3/6] mailbox: ti-msgmgr: Change message count mask to be descriptor based Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06 ` [PATCH V2 4/6] mailbox: ti-msgmgr: Move the memory region name to descriptor Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06 ` [PATCH V2 5/6] dt-bindings: mailbox: Add support for secure proxy threads Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06 ` [PATCH V2 6/6] mailbox: ti-msgmgr: Add support for Secure Proxy Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-16 18:06   ` Nishanth Menon
2018-07-23 13:29 ` [PATCH V2 0/6] mailbox: ti-msgmgr: Add support for AM654 " Nishanth Menon
2018-07-23 13:29   ` Nishanth Menon
2018-07-23 13:29   ` Nishanth Menon
2018-07-23 13:56   ` Jassi Brar
2018-07-23 13:56     ` Jassi Brar
2018-07-23 14:14     ` Nishanth Menon
2018-07-23 14:14       ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180716180607.16526-2-nm@ti.com \
    --to=nm@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.