From: Christoph Hellwig <hch@lst.de>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH 5/6] iomap: add a page_done callback
Date: Tue, 17 Jul 2018 16:02:58 +0200 [thread overview]
Message-ID: <20180717140258.GA18365@lst.de> (raw)
In-Reply-To: <20180713025853.xugxx6zte3kvvqjy@merlin>
On Thu, Jul 12, 2018 at 09:58:53PM -0500, Goldwyn Rodrigues wrote:
> Would it be better if we keep this function as a part of iomap_ops? I
> know gfs2 sets this conditionally, but we can always check the condition
> in the function assigned to page_done(). It would keep all the functions
> in one place.
It works at a very different level than the other iomap ops. We had
extensive discussions on previous versions, it should all be on
the list.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: cluster-devel@redhat.com, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-ext4@vger.kernel.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 5/6] iomap: add a page_done callback
Date: Tue, 17 Jul 2018 16:02:58 +0200 [thread overview]
Message-ID: <20180717140258.GA18365@lst.de> (raw)
In-Reply-To: <20180713025853.xugxx6zte3kvvqjy@merlin>
On Thu, Jul 12, 2018 at 09:58:53PM -0500, Goldwyn Rodrigues wrote:
> Would it be better if we keep this function as a part of iomap_ops? I
> know gfs2 sets this conditionally, but we can always check the condition
> in the function assigned to page_done(). It would keep all the functions
> in one place.
It works at a very different level than the other iomap ops. We had
extensive discussions on previous versions, it should all be on
the list.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
Andreas Gruenbacher <agruenba@redhat.com>,
linux-xfs@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel@vger.kernel.org, cluster-devel@redhat.com,
linux-ext4@vger.kernel.org
Subject: Re: [PATCH 5/6] iomap: add a page_done callback
Date: Tue, 17 Jul 2018 16:02:58 +0200 [thread overview]
Message-ID: <20180717140258.GA18365@lst.de> (raw)
In-Reply-To: <20180713025853.xugxx6zte3kvvqjy@merlin>
On Thu, Jul 12, 2018 at 09:58:53PM -0500, Goldwyn Rodrigues wrote:
> Would it be better if we keep this function as a part of iomap_ops? I
> know gfs2 sets this conditionally, but we can always check the condition
> in the function assigned to page_done(). It would keep all the functions
> in one place.
It works at a very different level than the other iomap ops. We had
extensive discussions on previous versions, it should all be on
the list.
next prev parent reply other threads:[~2018-07-17 14:02 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-19 16:41 [Cluster-devel] iomap preparations for GFS2 v3 Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` [Cluster-devel] [PATCH 1/6] fs: factor out a __generic_write_end helper Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` [Cluster-devel] [PATCH 2/6] iomap: mark newly allocated buffer heads as new Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` [Cluster-devel] [PATCH 3/6] iomap: complete partial direct I/O writes synchronously Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` [Cluster-devel] [PATCH 4/6] iomap: generic inline data handling Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` [Cluster-devel] [PATCH 5/6] iomap: add a page_done callback Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-07-13 2:58 ` [Cluster-devel] " Goldwyn Rodrigues
2018-07-13 2:58 ` Goldwyn Rodrigues
2018-07-13 2:58 ` Goldwyn Rodrigues
2018-07-17 14:02 ` Christoph Hellwig [this message]
2018-07-17 14:02 ` Christoph Hellwig
2018-07-17 14:02 ` Christoph Hellwig
2018-06-19 16:41 ` [Cluster-devel] [PATCH 6/6] iomap: add private pointer to struct iomap Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
2018-06-19 16:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717140258.GA18365@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.