From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: valdis.kletnieks@vt.edu
Cc: Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PATCH scripts/kernel-doc
Date: Wed, 18 Jul 2018 07:22:46 +0900 [thread overview]
Message-ID: <20180718072246.6070f2a1@vela.lan> (raw)
In-Reply-To: <50400.1531846649@turing-police.cc.vt.edu>
Em Tue, 17 Jul 2018 12:57:29 -0400
valdis.kletnieks@vt.edu escreveu:
> Fix a warning whinge from Perl introduced by "scripts: kernel-doc: parse next structs/unions"
>
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE [^\{\}]*})/ at ./scripts/kernel-doc line 1155.
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE )/ at ./scripts/kernel-doc line 1179.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 0057d8eafcc1..31a34ced55a3 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -1152,7 +1152,7 @@ sub dump_struct($$) {
> }
>
> # Ignore other nested elements, like enums
> - $members =~ s/({[^\{\}]*})//g;
> + $members =~ s/(\{[^\{\}]*})//g;
>
> create_parameterlist($members, ';', $file, $declaration_name);
> check_sections($file, $declaration_name, $decl_type, $sectcheck, $struct_actual);
> @@ -1176,7 +1176,7 @@ sub dump_struct($$) {
> $declaration .= "\t" x $level;
> }
> $declaration .= "\t" . $clause . "\n";
> - $level++ if ($clause =~ m/({)/ && !($clause =~m/}/));
> + $level++ if ($clause =~ m/(\{)/ && !($clause =~m/}/));
> }
> output_declaration($declaration_name,
> 'struct',
>
Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: valdis.kletnieks@vt.edu
Cc: Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab@s-opensource.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: PATCH scripts/kernel-doc
Date: Wed, 18 Jul 2018 07:22:46 +0900 [thread overview]
Message-ID: <20180718072246.6070f2a1@vela.lan> (raw)
In-Reply-To: <50400.1531846649@turing-police.cc.vt.edu>
Em Tue, 17 Jul 2018 12:57:29 -0400
valdis.kletnieks@vt.edu escreveu:
> Fix a warning whinge from Perl introduced by "scripts: kernel-doc: parse next structs/unions"
>
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE [^\{\}]*})/ at ./scripts/kernel-doc line 1155.
> Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/({ <-- HERE )/ at ./scripts/kernel-doc line 1179.
>
> Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Reviewed-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> ---
> diff --git a/scripts/kernel-doc b/scripts/kernel-doc
> index 0057d8eafcc1..31a34ced55a3 100755
> --- a/scripts/kernel-doc
> +++ b/scripts/kernel-doc
> @@ -1152,7 +1152,7 @@ sub dump_struct($$) {
> }
>
> # Ignore other nested elements, like enums
> - $members =~ s/({[^\{\}]*})//g;
> + $members =~ s/(\{[^\{\}]*})//g;
>
> create_parameterlist($members, ';', $file, $declaration_name);
> check_sections($file, $declaration_name, $decl_type, $sectcheck, $struct_actual);
> @@ -1176,7 +1176,7 @@ sub dump_struct($$) {
> $declaration .= "\t" x $level;
> }
> $declaration .= "\t" . $clause . "\n";
> - $level++ if ($clause =~ m/({)/ && !($clause =~m/}/));
> + $level++ if ($clause =~ m/(\{)/ && !($clause =~m/}/));
> }
> output_declaration($declaration_name,
> 'struct',
>
Cheers,
Mauro
next prev parent reply other threads:[~2018-07-17 22:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 16:57 PATCH scripts/kernel-doc valdis.kletnieks
2018-07-17 16:57 ` valdis.kletnieks
2018-07-17 22:22 ` Mauro Carvalho Chehab [this message]
2018-07-17 22:22 ` Mauro Carvalho Chehab
2018-07-23 15:32 ` Jonathan Corbet
2018-07-23 15:32 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718072246.6070f2a1@vela.lan \
--to=mchehab+samsung@kernel.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.