* Re: [PATCH] automation: add SLES 11 SP4 dockerfile
2018-07-17 20:03 [PATCH] automation: add SLES 11 SP4 dockerfile Wei Liu
@ 2018-07-17 20:06 ` Wei Liu
2018-07-17 20:42 ` Doug Goldstein
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2018-07-17 20:06 UTC (permalink / raw)
To: Xen-devel; +Cc: Doug Goldstein, Wei Liu, Jan Beulich
On Tue, Jul 17, 2018 at 09:03:05PM +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> No OVMF because it requires gcc 4.4 or later.
> No seabios because it requires anonymous union initialisation
> No QEMU upstrea because sed doesn't support -E.
>
> vmcs.c vmx_find_msr and vmx_del_msr build failure in pv shim because
> the compiler thinks total, substart and subend may be used
> uninitialised. The compiler doesn't complain while building normal
> xen though.
Also notable is that there is a sles11sp4-base on gitlab now, which is a
vanilla installation of SLES 11 SP4 with all the build tools and
libraries installed.
This helps separate Xen build specific setup (done in this file) from a
vanilla build.
>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
> automation/build/suse/sles11sp4.dockerfile | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 automation/build/suse/sles11sp4.dockerfile
>
> diff --git a/automation/build/suse/sles11sp4.dockerfile b/automation/build/suse/sles11sp4.dockerfile
> new file mode 100644
> index 0000000000..ff69a99afc
> --- /dev/null
> +++ b/automation/build/suse/sles11sp4.dockerfile
> @@ -0,0 +1,20 @@
> +FROM registry.gitlab.com/xen-project/xen/suse:sles11sp4-base
> +LABEL maintainer.name="The Xen Project" \
> + maintainer.email="xen-devel@lists.xenproject.org"
> +
> +ENV USER root
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +# Nothing else is needed -- base image already contain everything.
> +
> +# Note:
> +#
> +# SLES11 SP4 runs pre-2.13 glibc, which requires vsyscall support. Most
> +# distros nowadays disable vsyscall. To run this container, the host needs to
> +# have vsyscall=emulate in its kernel command line.
> +#
> +# Due to various issues in SLES11 SP4, you might want to disable building
> +# certain components. Known *not bulding* components include OVMF, SEABIOS
> +# and upstream QEMU.
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] automation: add SLES 11 SP4 dockerfile
2018-07-17 20:03 [PATCH] automation: add SLES 11 SP4 dockerfile Wei Liu
2018-07-17 20:06 ` Wei Liu
@ 2018-07-17 20:42 ` Doug Goldstein
2018-07-18 7:25 ` Jan Beulich
2018-07-18 9:44 ` Olaf Hering
3 siblings, 0 replies; 7+ messages in thread
From: Doug Goldstein @ 2018-07-17 20:42 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Jan Beulich
On Tue, Jul 17, 2018 at 09:03:05PM +0100, Wei Liu wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Awesome work Wei. Thanks for taking the time and effort to get this
done. I'll defer to Jan to confirm that this will hopefully be an
effective stand in but you've got my
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] automation: add SLES 11 SP4 dockerfile
2018-07-17 20:03 [PATCH] automation: add SLES 11 SP4 dockerfile Wei Liu
2018-07-17 20:06 ` Wei Liu
2018-07-17 20:42 ` Doug Goldstein
@ 2018-07-18 7:25 ` Jan Beulich
2018-07-18 8:04 ` Wei Liu
2018-07-18 9:44 ` Olaf Hering
3 siblings, 1 reply; 7+ messages in thread
From: Jan Beulich @ 2018-07-18 7:25 UTC (permalink / raw)
To: Wei Liu; +Cc: xen-devel, Doug Goldstein
>>> On 17.07.18 at 22:03, <wei.liu2@citrix.com> wrote:
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> No OVMF because it requires gcc 4.4 or later.
> No seabios because it requires anonymous union initialisation
This is unfortunate, and could perhaps be worked around by using the
alternative newer gcc-5 (iirc) that is being provided. Otoh we're not
so much after the build checking of 3rd party components here anyway.
> No QEMU upstrea because sed doesn't support -E.
This has been fixed in qemu quite some time ago (6809df1df0).
> vmcs.c vmx_find_msr and vmx_del_msr build failure in pv shim because
> the compiler thinks total, substart and subend may be used
> uninitialised. The compiler doesn't complain while building normal
> xen though.
A patch for this was already sent, but I mean to work out whether
instead some CFLAGS issue exists.
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Doug Goldstein <cardoe@cardoe.com>
> ---
> automation/build/suse/sles11sp4.dockerfile | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> create mode 100644 automation/build/suse/sles11sp4.dockerfile
>
> diff --git a/automation/build/suse/sles11sp4.dockerfile
> b/automation/build/suse/sles11sp4.dockerfile
> new file mode 100644
> index 0000000000..ff69a99afc
> --- /dev/null
> +++ b/automation/build/suse/sles11sp4.dockerfile
> @@ -0,0 +1,20 @@
> +FROM registry.gitlab.com/xen-project/xen/suse:sles11sp4-base
> +LABEL maintainer.name="The Xen Project" \
> + maintainer.email="xen-devel@lists.xenproject.org"
> +
> +ENV USER root
> +
> +RUN mkdir /build
> +WORKDIR /build
> +
> +# Nothing else is needed -- base image already contain everything.
> +
> +# Note:
> +#
> +# SLES11 SP4 runs pre-2.13 glibc, which requires vsyscall support. Most
> +# distros nowadays disable vsyscall. To run this container, the host needs
> to
> +# have vsyscall=emulate in its kernel command line.
> +#
> +# Due to various issues in SLES11 SP4, you might want to disable building
> +# certain components. Known *not bulding* components include OVMF, SEABIOS
> +# and upstream QEMU.
> --
> 2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] automation: add SLES 11 SP4 dockerfile
2018-07-18 7:25 ` Jan Beulich
@ 2018-07-18 8:04 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2018-07-18 8:04 UTC (permalink / raw)
To: Jan Beulich; +Cc: Doug Goldstein, Wei Liu, xen-devel
On Wed, Jul 18, 2018 at 01:25:22AM -0600, Jan Beulich wrote:
> >>> On 17.07.18 at 22:03, <wei.liu2@citrix.com> wrote:
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > No OVMF because it requires gcc 4.4 or later.
> > No seabios because it requires anonymous union initialisation
>
> This is unfortunate, and could perhaps be worked around by using the
> alternative newer gcc-5 (iirc) that is being provided. Otoh we're not
> so much after the build checking of 3rd party components here anyway.
>
I'm not going to do special arrangement for that in CI, but I will try
to put the alternative compiler in so that developers can try it out.
The main purpose of this container is to use old compiler in our CI
system.
> > No QEMU upstrea because sed doesn't support -E.
>
> This has been fixed in qemu quite some time ago (6809df1df0).
Right. I suppose once we update qemu-xen, it should build fine.
>
> > vmcs.c vmx_find_msr and vmx_del_msr build failure in pv shim because
> > the compiler thinks total, substart and subend may be used
> > uninitialised. The compiler doesn't complain while building normal
> > xen though.
>
> A patch for this was already sent, but I mean to work out whether
> instead some CFLAGS issue exists.
>
Just saw it.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] automation: add SLES 11 SP4 dockerfile
2018-07-17 20:03 [PATCH] automation: add SLES 11 SP4 dockerfile Wei Liu
` (2 preceding siblings ...)
2018-07-18 7:25 ` Jan Beulich
@ 2018-07-18 9:44 ` Olaf Hering
2018-07-18 9:51 ` Wei Liu
3 siblings, 1 reply; 7+ messages in thread
From: Olaf Hering @ 2018-07-18 9:44 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Doug Goldstein, Jan Beulich
[-- Attachment #1.1: Type: text/plain, Size: 753 bytes --]
On Tue, Jul 17, Wei Liu wrote:
> No OVMF because it requires gcc 4.4 or later.
Fine.
> No seabios because it requires anonymous union initialisation
It is required to build Xen like that (with a custom compiler from gcc48.rpm):
test -x "$(type -p gcc)" && CC=$_
test -x "$(type -p gcc-4.8)" && CC=$_
make \
CC=$CC \
HOSTCC=$CC \
xen
make \
CC=$CC \
GCC=$CC \
HOSTCC=$CC \
HOST_CC=$CC \
BUILD_CC=$CC \
tools stubdom
> No QEMU upstrea because sed doesn't support -E.
libvirt+QEMU upstream does not support SLE11 anymore due to the
requirement for a newer glib2. In case Xen wants to stick with qemu-2.12
for a while, SLE11 could still be tested for fun and education.
Olaf
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] automation: add SLES 11 SP4 dockerfile
2018-07-18 9:44 ` Olaf Hering
@ 2018-07-18 9:51 ` Wei Liu
0 siblings, 0 replies; 7+ messages in thread
From: Wei Liu @ 2018-07-18 9:51 UTC (permalink / raw)
To: Olaf Hering; +Cc: Xen-devel, Wei Liu, Jan Beulich, Doug Goldstein
On Wed, Jul 18, 2018 at 11:44:40AM +0200, Olaf Hering wrote:
> On Tue, Jul 17, Wei Liu wrote:
>
> > No OVMF because it requires gcc 4.4 or later.
>
> Fine.
>
> > No seabios because it requires anonymous union initialisation
>
> It is required to build Xen like that (with a custom compiler from gcc48.rpm):
>
> test -x "$(type -p gcc)" && CC=$_
> test -x "$(type -p gcc-4.8)" && CC=$_
> make \
> CC=$CC \
> HOSTCC=$CC \
> xen
>
> make \
> CC=$CC \
> GCC=$CC \
> HOSTCC=$CC \
> HOST_CC=$CC \
> BUILD_CC=$CC \
> tools stubdom
I just pushed a new base image which contained gcc-4.8. Individual
developers can use the runes here if they care to build seabios.
Further adjustment to the build script is needed if we really care about
building seabios in gitlab CI. But we don't even know if we can run this
container on gitlab CI yet. :-)
>
> > No QEMU upstrea because sed doesn't support -E.
>
> libvirt+QEMU upstream does not support SLE11 anymore due to the
> requirement for a newer glib2. In case Xen wants to stick with qemu-2.12
> for a while, SLE11 could still be tested for fun and education.
I think the same principle mentioned above applies here as well.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread