All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: rawnand: add default values for dynamic timings
Date: Wed, 18 Jul 2018 09:46:32 +0200	[thread overview]
Message-ID: <20180718094632.1105861e@xps13> (raw)
In-Reply-To: <20180717142621.380adf1e@bbrezillon>

> On Sat, 14 Jul 2018 12:23:54 +0200
> Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> 
> > Some timings like tBERS (block erase time), tCCs (change column setup
> > time), tPROG (page program time) and tR (page read time) are derived
> > from the ONFI parameter page. They are set in the SDR interface only
> > if the chip is ONFI compliant.
> > 
> > It makes these timings unreliable and prevent the driver to use one of
> > these four values with a non-ONFI chip.
> > 
> > Fix this situation by taking the highest possible value (or a default
> > one) value for each missing timing (stored as unsigned 16-bit entries in
> > the parameter page).
> > 
> > This makes tBERS and tPROG being ~65ms while typical values are at most
> > a few milliseconds. As these are timeouts, it is not impacting at all
> > the performances in nominal use.
> > 
> > tR maximum time and tCCS minimum time (delay to wait after a change
> > column) are set, according to the ONFI specification, to default 'slow'
> > values; respectively 200us and 500ns.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> 
> Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>
> 

Applied to nand/next.

Miquèl

      reply	other threads:[~2018-07-18  7:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-14 10:23 [PATCH v2] mtd: rawnand: add default values for dynamic timings Miquel Raynal
2018-07-17 12:26 ` Boris Brezillon
2018-07-18  7:46   ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180718094632.1105861e@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.