From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware
Date: Wed, 18 Jul 2018 13:18:39 +0200 [thread overview]
Message-ID: <20180718131839.1995b40c@windsurf> (raw)
In-Reply-To: <20180716151303.18064-1-me@noctarius.com>
Hello,
On Mon, 16 Jul 2018 18:13:03 +0300, Christoph Engelbert wrote:
> With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files
> directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll
> fallback to using crda, but the direct way is preferred.
>
> This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with
> kernels of 4.15 or later.
>
> Signed-off-by: Christoph Engelbert <me@noctarius.com>
> ---
> package/wireless-regdb/wireless-regdb.mk | 4 ++++
> 1 file changed, 4 insertions(+)
Thanks for your contribution, I've applied your patch. However, I would
like to recommend a few improvements for your future contributions, if
possible:
- No need to enclose the package name between < and > in the commit
title, i.e just "package: description" is enough.
- When sending new iterations, please change the patch subject prefix
to PATCH v2, PATCH v3, etc. You can do that with "git format-patch
-v2" or git format-patch --subject-prefix="PATCH v2"
- Also when sending new iterations, adding a changelog below the "---"
sign is very nice, because it allows the people reviewing your patch
understand what has changed.
- Finally, the commit log description should be wrapped to 72
characters.
But again: I applied your patch after doing minor fixes in the commit
title and commit log, so those recommendations are valid for your
future contributions only :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-18 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 15:13 [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware Christoph Engelbert
2018-07-18 11:18 ` Thomas Petazzoni [this message]
2018-07-18 11:23 ` Christoph Engelbert
2018-07-19 21:44 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718131839.1995b40c@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.