* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware @ 2018-07-16 15:13 Christoph Engelbert 2018-07-18 11:18 ` Thomas Petazzoni 2018-07-19 21:44 ` Peter Korsgaard 0 siblings, 2 replies; 4+ messages in thread From: Christoph Engelbert @ 2018-07-16 15:13 UTC (permalink / raw) To: buildroot With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll fallback to using crda, but the direct way is preferred. This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with kernels of 4.15 or later. Signed-off-by: Christoph Engelbert <me@noctarius.com> --- package/wireless-regdb/wireless-regdb.mk | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package/wireless-regdb/wireless-regdb.mk b/package/wireless-regdb/wireless-regdb.mk index e9283a00e2..829374edcf 100644 --- a/package/wireless-regdb/wireless-regdb.mk +++ b/package/wireless-regdb/wireless-regdb.mk @@ -15,6 +15,10 @@ define WIRELESS_REGDB_INSTALL_TARGET_CMDS $(TARGET_DIR)/usr/lib/crda/regulatory.bin $(INSTALL) -m 644 -D -T $(@D)/sforshee.key.pub.pem \ $(TARGET_DIR)/etc/wireless-regdb/pubkeys/sforshee.key.pub.pem + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db \ + $(TARGET_DIR)/lib/firmware/regulatory.db + $(INSTALL) -m 644 -D -T $(@D)/regulatory.db.p7s \ + $(TARGET_DIR)/lib/firmware/regulatory.db.p7s endef $(eval $(generic-package)) -- 2.17.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware 2018-07-16 15:13 [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware Christoph Engelbert @ 2018-07-18 11:18 ` Thomas Petazzoni 2018-07-18 11:23 ` Christoph Engelbert 2018-07-19 21:44 ` Peter Korsgaard 1 sibling, 1 reply; 4+ messages in thread From: Thomas Petazzoni @ 2018-07-18 11:18 UTC (permalink / raw) To: buildroot Hello, On Mon, 16 Jul 2018 18:13:03 +0300, Christoph Engelbert wrote: > With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files > directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll > fallback to using crda, but the direct way is preferred. > > This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with > kernels of 4.15 or later. > > Signed-off-by: Christoph Engelbert <me@noctarius.com> > --- > package/wireless-regdb/wireless-regdb.mk | 4 ++++ > 1 file changed, 4 insertions(+) Thanks for your contribution, I've applied your patch. However, I would like to recommend a few improvements for your future contributions, if possible: - No need to enclose the package name between < and > in the commit title, i.e just "package: description" is enough. - When sending new iterations, please change the patch subject prefix to PATCH v2, PATCH v3, etc. You can do that with "git format-patch -v2" or git format-patch --subject-prefix="PATCH v2" - Also when sending new iterations, adding a changelog below the "---" sign is very nice, because it allows the people reviewing your patch understand what has changed. - Finally, the commit log description should be wrapped to 72 characters. But again: I applied your patch after doing minor fixes in the commit title and commit log, so those recommendations are valid for your future contributions only :-) Thanks! Thomas -- Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware 2018-07-18 11:18 ` Thomas Petazzoni @ 2018-07-18 11:23 ` Christoph Engelbert 0 siblings, 0 replies; 4+ messages in thread From: Christoph Engelbert @ 2018-07-18 11:23 UTC (permalink / raw) To: buildroot Hey Thomas, Thanks for applying the patch. I?ll take your recommendations into consideration next time. Guess that was probably not the last patch to send ;-) Especially since (at the moment) I?m fighting myself through the process to get a full blown nanopi neo air working from the buildroot process. Thanks, Chris > On 18. Jul 2018, at 13:18, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote: > > Hello, > > On Mon, 16 Jul 2018 18:13:03 +0300, Christoph Engelbert wrote: >> With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files >> directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll >> fallback to using crda, but the direct way is preferred. >> >> This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with >> kernels of 4.15 or later. >> >> Signed-off-by: Christoph Engelbert <me@noctarius.com> >> --- >> package/wireless-regdb/wireless-regdb.mk | 4 ++++ >> 1 file changed, 4 insertions(+) > > Thanks for your contribution, I've applied your patch. However, I would > like to recommend a few improvements for your future contributions, if > possible: > > - No need to enclose the package name between < and > in the commit > title, i.e just "package: description" is enough. > > - When sending new iterations, please change the patch subject prefix > to PATCH v2, PATCH v3, etc. You can do that with "git format-patch > -v2" or git format-patch --subject-prefix="PATCH v2" > > - Also when sending new iterations, adding a changelog below the "---" > sign is very nice, because it allows the people reviewing your patch > understand what has changed. > > - Finally, the commit log description should be wrapped to 72 > characters. > > But again: I applied your patch after doing minor fixes in the commit > title and commit log, so those recommendations are valid for your > future contributions only :-) > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons) > Embedded Linux and Kernel engineering > https://bootlin.com > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware 2018-07-16 15:13 [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware Christoph Engelbert 2018-07-18 11:18 ` Thomas Petazzoni @ 2018-07-19 21:44 ` Peter Korsgaard 1 sibling, 0 replies; 4+ messages in thread From: Peter Korsgaard @ 2018-07-19 21:44 UTC (permalink / raw) To: buildroot >>>>> "Christoph" == Christoph Engelbert <me@noctarius.com> writes: > With kernel version 4.15, Linux started to support loading regulatory.db and regulatory.db.p7s files > directly from /lib/firmware, without the need of crda. If the kernel can't load those files it'll > fallback to using crda, but the direct way is preferred. > This patch copies those those files under /lib/firmware. The use of crda shouldn't be necessary with > kernels of 4.15 or later. > Signed-off-by: Christoph Engelbert <me@noctarius.com> Committed to 2018.02.x and 2018.05.x, thanks. -- Bye, Peter Korsgaard ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-19 21:44 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-07-16 15:13 [Buildroot] [PATCH 1/1] <wireless-regdb>: Adds "regulatory.db[.p7s]" to /lib/firmware Christoph Engelbert 2018-07-18 11:18 ` Thomas Petazzoni 2018-07-18 11:23 ` Christoph Engelbert 2018-07-19 21:44 ` Peter Korsgaard
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.