From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
sergey.senozhatsky@gmail.com, hdegoede@redhat.com,
rostedt@goodmis.org, Thomas Zimmermann <tzimmermann@suse.de>,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set
Date: Thu, 19 Jul 2018 10:05:26 +0000 [thread overview]
Message-ID: <20180719100526.GB424@jagdpanzerIV> (raw)
In-Reply-To: <20180719085303.mkxu7i7zl4suybcz@pathway.suse.cz>
On (07/19/18 10:53), Petr Mladek wrote:
> Hmm, this approach is racy if there are other users
> saving/setting/restoring ignore_console_lock_warning in parallel.
> I mean that this works only when the entire safe/set/restore
> operation is nested or sequential.
Good point!
However, I tend to think that we don't need to care about it
that much. Having a counter to permit nesting would probably be
better, but, like you said, it's unlikely that we will see any
problems with ignore_console_lock_warning anyway. So we can keep
it simple [IOW - the way it is].
-ss
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Petr Mladek <pmladek@suse.com>
Cc: linux-fbdev@vger.kernel.org, sergey.senozhatsky.work@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
sergey.senozhatsky@gmail.com, hdegoede@redhat.com,
rostedt@goodmis.org, Thomas Zimmermann <tzimmermann@suse.de>,
akpm@linux-foundation.org
Subject: Re: [PATCH v2 1/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set
Date: Thu, 19 Jul 2018 19:05:26 +0900 [thread overview]
Message-ID: <20180719100526.GB424@jagdpanzerIV> (raw)
In-Reply-To: <20180719085303.mkxu7i7zl4suybcz@pathway.suse.cz>
On (07/19/18 10:53), Petr Mladek wrote:
> Hmm, this approach is racy if there are other users
> saving/setting/restoring ignore_console_lock_warning in parallel.
> I mean that this works only when the entire safe/set/restore
> operation is nested or sequential.
Good point!
However, I tend to think that we don't need to care about it
that much. Having a counter to permit nesting would probably be
better, but, like you said, it's unlikely that we will see any
problems with ignore_console_lock_warning anyway. So we can keep
it simple [IOW - the way it is].
-ss
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-19 10:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-18 9:30 [PATCH v2 0/1] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Thomas Zimmermann
2018-07-18 9:30 ` Thomas Zimmermann
2018-07-18 9:30 ` [PATCH v2 1/1] " Thomas Zimmermann
2018-07-18 9:30 ` Thomas Zimmermann
2018-07-18 9:34 ` Hans de Goede
2018-07-18 9:34 ` Hans de Goede
2018-07-18 19:53 ` kbuild test robot
2018-07-18 19:53 ` kbuild test robot
2018-07-19 8:53 ` Petr Mladek
2018-07-19 8:53 ` Petr Mladek
2018-07-19 10:05 ` Sergey Senozhatsky [this message]
2018-07-19 10:05 ` Sergey Senozhatsky
2018-07-19 10:20 ` Thomas Zimmermann
2018-07-19 10:20 ` Thomas Zimmermann
2018-07-19 10:33 ` Sergey Senozhatsky
2018-07-19 10:33 ` Sergey Senozhatsky
2018-07-19 11:43 ` Hans de Goede
2018-07-19 11:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719100526.GB424@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.