From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: linux-arch@vger.kernel.org, alexandre.belloni@bootlin.com,
arnd@arndb.de, richard.genoud@gmail.com,
Greg KH <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
jslaby@suse.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure
Date: Thu, 19 Jul 2018 12:07:05 +0100 [thread overview]
Message-ID: <20180719120705.4a2fde04@alans-desktop> (raw)
In-Reply-To: <20180713080129.2ifw7crjksvaxxpq@M43218.corp.atmel.com>
> >
> > > + if (!port->iso7816_config)
> > > + return -ENOIOCTLCMD;
> >
> > Why this error value?
> >
>
> It was a mimic of RS485.
Which is what you want - it means the upper tty layer knows to offer the
ioctl to other places and then return appropriately.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-serial@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jslaby@suse.com,
arnd@arndb.de, richard.genoud@gmail.com,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure
Date: Thu, 19 Jul 2018 12:07:05 +0100 [thread overview]
Message-ID: <20180719120705.4a2fde04@alans-desktop> (raw)
Message-ID: <20180719110705.5X8kYrDK5QuLMqvnWItN_784sH0GxnrUvXh35YhkpbI@z> (raw)
In-Reply-To: <20180713080129.2ifw7crjksvaxxpq@M43218.corp.atmel.com>
> >
> > > + if (!port->iso7816_config)
> > > + return -ENOIOCTLCMD;
> >
> > Why this error value?
> >
>
> It was a mimic of RS485.
Which is what you want - it means the upper tty layer knows to offer the
ioctl to other places and then return appropriately.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: gnomes@lxorguk.ukuu.org.uk (Alan Cox)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure
Date: Thu, 19 Jul 2018 12:07:05 +0100 [thread overview]
Message-ID: <20180719120705.4a2fde04@alans-desktop> (raw)
In-Reply-To: <20180713080129.2ifw7crjksvaxxpq@M43218.corp.atmel.com>
> >
> > > + if (!port->iso7816_config)
> > > + return -ENOIOCTLCMD;
> >
> > Why this error value?
> >
>
> It was a mimic of RS485.
Which is what you want - it means the upper tty layer knows to offer the
ioctl to other places and then return appropriately.
Alan
WARNING: multiple messages have this Message-ID (diff)
From: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
To: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
<linux-serial@vger.kernel.org>, <linux-arch@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <jslaby@suse.com>,
<arnd@arndb.de>, <richard.genoud@gmail.com>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure
Date: Thu, 19 Jul 2018 12:07:05 +0100 [thread overview]
Message-ID: <20180719120705.4a2fde04@alans-desktop> (raw)
In-Reply-To: <20180713080129.2ifw7crjksvaxxpq@M43218.corp.atmel.com>
> >
> > > + if (!port->iso7816_config)
> > > + return -ENOIOCTLCMD;
> >
> > Why this error value?
> >
>
> It was a mimic of RS485.
Which is what you want - it means the upper tty layer knows to offer the
ioctl to other places and then return appropriately.
Alan
next prev parent reply other threads:[~2018-07-19 11:07 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 13:16 [PATCH 0/3] add ISO7816 support Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-11 13:16 ` [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-11 21:52 ` kbuild test robot
2018-07-11 21:52 ` kbuild test robot
2018-07-11 21:52 ` kbuild test robot
2018-07-11 21:52 ` kbuild test robot
2018-07-12 0:10 ` kbuild test robot
2018-07-12 0:10 ` kbuild test robot
2018-07-12 0:10 ` kbuild test robot
2018-07-12 0:10 ` kbuild test robot
2018-07-12 14:58 ` Greg KH
2018-07-12 14:58 ` Greg KH
2018-07-13 8:01 ` Ludovic Desroches
2018-07-13 8:01 ` Ludovic Desroches
2018-07-13 8:01 ` Ludovic Desroches
2018-07-19 11:07 ` Alan Cox [this message]
2018-07-19 11:07 ` Alan Cox
2018-07-19 11:07 ` Alan Cox
2018-07-19 11:07 ` Alan Cox
2018-07-12 15:02 ` Greg KH
2018-07-12 15:02 ` Greg KH
2018-07-13 7:56 ` Ludovic Desroches
2018-07-13 7:56 ` Ludovic Desroches
2018-07-13 7:56 ` Ludovic Desroches
2018-07-13 8:16 ` Greg KH
2018-07-13 8:16 ` Greg KH
2018-07-11 13:16 ` [PATCH 2/3] tty/serial: atmel: add ISO7816 support Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-12 15:01 ` Greg KH
2018-07-12 15:01 ` Greg KH
2018-07-11 13:16 ` [PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-11 13:16 ` Ludovic Desroches
2018-07-12 14:59 ` Greg KH
2018-07-12 14:59 ` Greg KH
2018-07-11 13:26 ` Ludovic Desroches
2018-07-11 13:26 ` Ludovic Desroches
2018-07-11 13:26 ` Ludovic Desroches
2018-07-12 14:58 ` Greg KH
2018-07-12 14:58 ` Greg KH
2018-07-12 15:23 ` Ludovic Desroches
2018-07-12 15:23 ` Ludovic Desroches
2018-07-12 15:23 ` Ludovic Desroches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719120705.4a2fde04@alans-desktop \
--to=gnomes@lxorguk.ukuu.org.uk \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=richard.genoud@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.