From: Bin Liu <b-liu@ti.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: usb: musb: Call musb_platform_exit from musb_stop
Date: Thu, 19 Jul 2018 13:34:16 -0500 [thread overview]
Message-ID: <20180719183416.GE3949@uda0271908> (raw)
On Thu, Jul 19, 2018 at 11:16:18PM +0530, Jagan Teki wrote:
> On Thu, Jul 19, 2018 at 9:07 PM, Bin Liu <b-liu@ti.com> wrote:
> > Hi,
> >
> > On Thu, Jul 19, 2018 at 03:40:38PM +0530, Jagan Teki wrote:
> >> musb stop is musb core call during unregister or shutting down
> >> gadget or host musb. For graceful exit add musb_platform_exit
> >> on musb_stop so-that it can exit the musb platform driver as well.
> >
> > Thanks for the patch. but musb_stop() is called in the .udc_stop() and
> > host .stop() hooks, which can stop (and restart) at any time by the udc
> > or host core, not really during unregister. musb_platform_init() is not
> > called in .udc_start() and .start() hooks, so we shouldn't add
> > musb_platform_exit() in musb_stop().
>
> Thanks for the explanation.
>
> Look like musb_platform_exit calling during musb_remove call of
> platform driver. can you explain how the shutdown sequence happen
> because of if udc_stop call musb_stop to shutdown how come
musb_stop() only disables for example irq and session. I didn't read
how udc_stop() is used though.
> platform_exit will shutdown it's PHY and CLK bits. or is it in
platform_exit() is called in musb_remove().
Not sure if this answers your question though.
Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: musb: Call musb_platform_exit from musb_stop
Date: Thu, 19 Jul 2018 13:34:16 -0500 [thread overview]
Message-ID: <20180719183416.GE3949@uda0271908> (raw)
In-Reply-To: <CAMty3ZCTFMvOtc78eoLULLzhgufVEcX0YUexCn94QAkpLLpqMQ@mail.gmail.com>
On Thu, Jul 19, 2018 at 11:16:18PM +0530, Jagan Teki wrote:
> On Thu, Jul 19, 2018 at 9:07 PM, Bin Liu <b-liu@ti.com> wrote:
> > Hi,
> >
> > On Thu, Jul 19, 2018 at 03:40:38PM +0530, Jagan Teki wrote:
> >> musb stop is musb core call during unregister or shutting down
> >> gadget or host musb. For graceful exit add musb_platform_exit
> >> on musb_stop so-that it can exit the musb platform driver as well.
> >
> > Thanks for the patch. but musb_stop() is called in the .udc_stop() and
> > host .stop() hooks, which can stop (and restart) at any time by the udc
> > or host core, not really during unregister. musb_platform_init() is not
> > called in .udc_start() and .start() hooks, so we shouldn't add
> > musb_platform_exit() in musb_stop().
>
> Thanks for the explanation.
>
> Look like musb_platform_exit calling during musb_remove call of
> platform driver. can you explain how the shutdown sequence happen
> because of if udc_stop call musb_stop to shutdown how come
musb_stop() only disables for example irq and session. I didn't read
how udc_stop() is used though.
> platform_exit will shutdown it's PHY and CLK bits. or is it in
platform_exit() is called in musb_remove().
Not sure if this answers your question though.
Regards,
-Bin.
next reply other threads:[~2018-07-19 18:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 18:34 Bin Liu [this message]
2018-07-19 18:34 ` [PATCH] usb: musb: Call musb_platform_exit from musb_stop Bin Liu
-- strict thread matches above, loose matches on Subject: below --
2018-07-19 17:46 Jagan Teki
2018-07-19 17:46 ` [PATCH] " Jagan Teki
2018-07-19 15:37 Bin Liu
2018-07-19 15:37 ` [PATCH] " Bin Liu
2018-07-19 10:10 Jagan Teki
2018-07-19 10:10 ` [PATCH] " Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180719183416.GE3949@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.