From: Mark Brown <broonie@kernel.org>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
linux-tegra@vger.kernel.org
Subject: Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting
Date: Fri, 20 Jul 2018 13:16:12 +0100 [thread overview]
Message-ID: <20180720121612.GC10784@sirena.org.uk> (raw)
In-Reply-To: <20180720080424.31505-2-marcel@ziswiler.com>
[-- Attachment #1.1: Type: text/plain, Size: 804 bytes --]
On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote:
> - dev_err(&pdev->dev, "could not get codec-reset GPIO\n");
> + dev_err(&pdev->dev, "could not get codec-reset GPIO: "
> + "%d\n", ret);
Don't split strings over lines like this, it causes problems when people
grep for errors. It's better to go over 80 columns.
> ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> "nvidia,codec-sync-gpio", 0);
> if (!gpio_is_valid(ac97->sync_gpio)) {
> - dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
> + ret = ac97->sync_gpio;
> + dev_err(&pdev->dev, "no codec-sync GPIO supplied: %d\n", ret);
> goto err_clk_put;
> }
This isn't reporting an error code associated with the attempt to find a
codec-sync GPIO, it's the result of some other operation.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Marcel Ziswiler <marcel@ziswiler.com>
Cc: alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
Marcel Ziswiler <marcel.ziswiler@toradex.com>,
Jaroslav Kysela <perex@perex.cz>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: tegra: probe deferral error reporting
Date: Fri, 20 Jul 2018 13:16:12 +0100 [thread overview]
Message-ID: <20180720121612.GC10784@sirena.org.uk> (raw)
In-Reply-To: <20180720080424.31505-2-marcel@ziswiler.com>
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
On Fri, Jul 20, 2018 at 10:04:24AM +0200, Marcel Ziswiler wrote:
> - dev_err(&pdev->dev, "could not get codec-reset GPIO\n");
> + dev_err(&pdev->dev, "could not get codec-reset GPIO: "
> + "%d\n", ret);
Don't split strings over lines like this, it causes problems when people
grep for errors. It's better to go over 80 columns.
> ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> "nvidia,codec-sync-gpio", 0);
> if (!gpio_is_valid(ac97->sync_gpio)) {
> - dev_err(&pdev->dev, "no codec-sync GPIO supplied\n");
> + ret = ac97->sync_gpio;
> + dev_err(&pdev->dev, "no codec-sync GPIO supplied: %d\n", ret);
> goto err_clk_put;
> }
This isn't reporting an error code associated with the attempt to find a
codec-sync GPIO, it's the result of some other operation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-07-20 12:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 8:04 [PATCH 1/2] ASoC: tegra: improve goto error label Marcel Ziswiler
2018-07-20 8:04 ` Marcel Ziswiler
2018-07-20 8:04 ` [PATCH 2/2] ASoC: tegra: probe deferral error reporting Marcel Ziswiler
2018-07-20 8:04 ` Marcel Ziswiler
2018-07-20 12:16 ` Mark Brown [this message]
2018-07-20 12:16 ` Mark Brown
2018-07-20 12:31 ` Marcel Ziswiler
2018-07-21 9:56 ` Mark Brown
2018-07-21 9:56 ` Mark Brown
2018-07-21 10:06 ` Marcel Ziswiler
2018-07-21 10:06 ` Marcel Ziswiler
2018-07-23 10:25 ` Mark Brown
2018-07-23 10:25 ` Mark Brown
2018-07-21 11:17 ` Dmitry Osipenko
2018-07-21 11:55 ` Marcel Ziswiler
2018-07-21 11:55 ` Marcel Ziswiler
2018-07-21 12:03 ` Dmitry Osipenko
2018-07-21 12:15 ` Dmitry Osipenko
2018-07-26 8:34 ` Stefan Agner
2018-07-20 12:19 ` Applied "ASoC: tegra: improve goto error label" to the asoc tree Mark Brown
2018-07-20 12:19 ` Mark Brown
2018-07-20 12:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720121612.GC10784@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=marcel@ziswiler.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.