[U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM

All of lore.kernel.org
 help / color / mirror / Atom feed

* [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM
@ 2018-07-20 12:05 Michal Simek
  2018-07-20 12:05 ` [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling Michal Simek
  2018-07-20 12:53 ` [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM Tom Rini
  0 siblings, 2 replies; 7+ messages in thread
From: Michal Simek @ 2018-07-20 12:05 UTC (permalink / raw)
  To: u-boot

Better use depends on instead of select.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

I found this in connection to setup imply CMD_DM and it seems to not
standard that it is selecting DM which is not used anywhere else.

---
 common/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/Kconfig b/common/Kconfig
index 4c7a1a9af865..cb17911e1681 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -424,7 +424,7 @@ menu "Logging"
 
 config LOG
 	bool "Enable logging support"
-	select DM
+	depends on DM
 	help
 	  This enables support for logging of status and debug messages. These
 	  can be displayed on the console, recorded in a memory buffer, or
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling
  2018-07-20 12:05 [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM Michal Simek
@ 2018-07-20 12:05 ` Michal Simek
  2018-07-20 12:53   ` Tom Rini
  2018-07-20 12:53 ` [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM Tom Rini
  1 sibling, 1 reply; 7+ messages in thread
From: Michal Simek @ 2018-07-20 12:05 UTC (permalink / raw)
  To: u-boot

CMD_DM is used for debug purpose and it shouldn't be enabled by default
via Kconfig. Unfortunately this is in the tree for quite a long time
that's why solution is to use imply DM for all targets which are
enabling DM.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

Based on this discussion:
https://lists.denx.de/pipermail/u-boot/2018-July/334952.html

Done by:
for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
uniq`; do
	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
done

And checked by
for i in `ls configs/*`; do
	NAME=`basename $i`; echo $NAME;
	make $NAME;
	make savedefconfig;
	cp defconfig $i;
done

---
 arch/Kconfig                       |  3 +++
 arch/arm/Kconfig                   | 25 +++++++++++++++++++++++++
 arch/arm/mach-at91/Kconfig         |  6 ++++++
 arch/arm/mach-imx/mx5/Kconfig      |  2 ++
 arch/arm/mach-imx/mx6/Kconfig      | 26 ++++++++++++++++++++++++++
 arch/arm/mach-imx/mx7/Kconfig      |  5 +++++
 arch/arm/mach-meson/Kconfig        |  2 ++
 arch/arm/mach-omap2/am33xx/Kconfig | 18 ++++++++++++++++++
 arch/arm/mach-omap2/omap3/Kconfig  | 10 ++++++++++
 arch/arm/mach-rmobile/Kconfig.32   |  8 ++++++++
 arch/arm/mach-tegra/Kconfig        |  1 +
 arch/microblaze/Kconfig            |  1 +
 arch/mips/Kconfig                  |  6 ++++++
 arch/powerpc/cpu/mpc83xx/Kconfig   |  1 +
 cmd/Kconfig                        |  1 -
 15 files changed, 114 insertions(+), 1 deletion(-)

diff --git a/arch/Kconfig b/arch/Kconfig
index dd5a8870017f..4b1265cb5331 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -49,6 +49,7 @@ config NIOS2
 	select SUPPORT_OF_CONTROL
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select CPU
 
 config PPC
@@ -67,6 +68,7 @@ config SANDBOX
 	select BOARD_LATE_INIT
 	select SUPPORT_OF_CONTROL
 	select DM
+	imply CMD_DM
 	select DM_KEYBOARD
 	select DM_SPI_FLASH
 	select DM_SERIAL
@@ -102,6 +104,7 @@ config X86
 	select SUPPORT_OF_CONTROL
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select DM_PCI
 	select PCI
 	select TIMER
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 64d58a624182..86c01afa58a3 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -436,6 +436,7 @@ config ARCH_MVEBU
 	select OF_CONTROL
 	select OF_SEPARATE
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_SERIAL
 	select DM_SPI
@@ -493,6 +494,7 @@ config TARGET_STV0991
 	bool "Support stv0991"
 	select CPU_V7A
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_SPI
 	select DM_SPI_FLASH
@@ -528,6 +530,7 @@ config TARGET_MX35PDK
 config ARCH_BCM283X
 	bool "Broadcom BCM283X family"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OF_CONTROL
@@ -546,6 +549,7 @@ config ARCH_BCMSTB
 	bool "Broadcom BCM7XXX family"
 	select CPU_V7A
 	select DM
+	imply CMD_DM
 	select OF_CONTROL
 	select OF_PRIOR_STAGE
 	help
@@ -600,6 +604,7 @@ config TARGET_BCMNS2
 config ARCH_EXYNOS
 	bool "Samsung EXYNOS"
 	select DM
+	imply CMD_DM
 	select DM_I2C
 	select DM_SPI_FLASH
 	select DM_SERIAL
@@ -613,6 +618,7 @@ config ARCH_S5PC1XX
 	bool "Samsung S5PC1XX"
 	select CPU_V7A
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select DM_I2C
@@ -625,6 +631,7 @@ config ARCH_HIGHBANK
 config ARCH_INTEGRATOR
 	bool "ARM Ltd. Integrator family"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select PL01X_SERIAL
 
@@ -659,6 +666,7 @@ config ARCH_MX8M
 	bool "NXP i.MX8M platform"
 	select ARM64
 	select DM
+	imply CMD_DM
 	select SUPPORT_SPL
 
 config ARCH_MX23
@@ -722,12 +730,14 @@ config ARCH_OWL
 	bool "Actions Semi OWL SoCs"
 	select ARM64
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select OF_CONTROL
 
 config ARCH_QEMU
 	bool "QEMU Virtual Platform"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select OF_CONTROL
 	select PL01X_SERIAL
@@ -735,6 +745,7 @@ config ARCH_QEMU
 config ARCH_RMOBILE
 	bool "Renesas ARM SoCs"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select BOARD_EARLY_INIT_F
 	imply FAT_WRITE
@@ -749,6 +760,7 @@ config ARCH_SNAPDRAGON
 	bool "Qualcomm Snapdragon SoCs"
 	select ARM64
 	select DM
+	imply CMD_DM
 	select DM_GPIO
 	select DM_SERIAL
 	select SPMI
@@ -761,6 +773,7 @@ config ARCH_SOCFPGA
 	select ARCH_MISC_INIT
 	select CPU_V7A if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select ENABLE_ARM_SOC_BOOT0_HOOK if TARGET_SOCFPGA_GEN5 || TARGET_SOCFPGA_ARRIA10
 	select OF_CONTROL
@@ -796,6 +809,7 @@ config ARCH_SUNXI
 	select CMD_MMC if MMC
 	select CMD_USB if DISTRO_DEFAULTS
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_KEYBOARD
@@ -845,6 +859,7 @@ config ARCH_ZYNQ
 	select BOARD_EARLY_INIT_F if WDT
 	select SPL_OF_CONTROL if SPL
 	select DM
+	imply CMD_DM
 	select DM_ETH if NET
 	select SPL_DM if SPL
 	select DM_MMC if MMC
@@ -867,6 +882,7 @@ config ARCH_ZYNQMP_R5
 	select CPU_V7R
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select CLK
 
@@ -875,6 +891,7 @@ config ARCH_ZYNQMP
 	select ARM64
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select OF_CONTROL
 	select DM_SERIAL
 	select SUPPORT_SPL
@@ -1003,6 +1020,7 @@ config TARGET_HIKEY
 	bool "Support HiKey 96boards Consumer Edition Platform"
 	select ARM64
 	select DM
+	imply CMD_DM
 	select DM_GPIO
 	select DM_SERIAL
 	select OF_CONTROL
@@ -1016,6 +1034,7 @@ config TARGET_POPLAR
 	bool "Support Poplar 96boards Enterprise Edition Platform"
 	select ARM64
 	select DM
+	imply CMD_DM
 	select OF_CONTROL
 	select DM_SERIAL
 	select DM_USB
@@ -1215,6 +1234,7 @@ config ARCH_UNIPHIER
 	bool "Socionext UniPhier SoCs"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_GPIO
 	select DM_I2C
 	select DM_MMC
@@ -1240,6 +1260,7 @@ config STM32
 	bool "Support STMicroelectronics STM32 MCU with cortex M"
 	select CPU_V7M
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SYS_THUMB_BUILD
 
@@ -1247,6 +1268,7 @@ config ARCH_STI
 	bool "Support STMicrolectronics SoCs"
 	select CPU_V7A
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select BLK
 	select DM_MMC
@@ -1261,6 +1283,7 @@ config ARCH_STM32MP
 	select BOARD_LATE_INIT
 	select CLK
 	select DM
+	imply CMD_DM
 	select DM_GPIO
 	select DM_RESET
 	select DM_SERIAL
@@ -1284,6 +1307,7 @@ config ARCH_ROCKCHIP
 	select OF_CONTROL
 	select BLK
 	select DM
+	imply CMD_DM
 	select SPL_DM if SPL
 	select SYS_MALLOC_F
 	select SYS_THUMB_BUILD if !ARM64
@@ -1319,6 +1343,7 @@ config ARCH_ASPEED
 	bool "Support Aspeed SoCs"
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 
 endchoice
 
diff --git a/arch/arm/mach-at91/Kconfig b/arch/arm/mach-at91/Kconfig
index ce6be3829afe..a7274489cebf 100644
--- a/arch/arm/mach-at91/Kconfig
+++ b/arch/arm/mach-at91/Kconfig
@@ -76,6 +76,7 @@ config TARGET_SNAPPER9260
 	bool "Support snapper9260"
 	select AT91SAM9260
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -84,6 +85,7 @@ config TARGET_GURNARD
 	select AT91SAM9G45
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_SPI
 	select DM_GPIO
@@ -206,6 +208,7 @@ config TARGET_CORVUS
 	select AT91SAM9M10G45
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select DM_ETH
@@ -215,6 +218,7 @@ config TARGET_TAURUS
 	select AT91SAM9G20
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_SPI
 	select DM_GPIO
@@ -226,6 +230,7 @@ config TARGET_SMARTWEB
 	select AT91SAM9260
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select DM_ETH
@@ -235,6 +240,7 @@ config TARGET_VINCO
 	select SAMA5D4
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SPI
 	select SPI
 
diff --git a/arch/arm/mach-imx/mx5/Kconfig b/arch/arm/mach-imx/mx5/Kconfig
index 3654670442fb..e12af6f0b541 100644
--- a/arch/arm/mach-imx/mx5/Kconfig
+++ b/arch/arm/mach-imx/mx5/Kconfig
@@ -23,6 +23,7 @@ config TARGET_KP_IMX53
 	select BOARD_LATE_INIT
 	select MX53
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_ETH
 	select DM_I2C
@@ -43,6 +44,7 @@ config TARGET_MX53CX9020
 	select BOARD_LATE_INIT
 	select MX53
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 
 config TARGET_MX53EVK
diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
index 521fad74b5a2..df5b16a0f3d5 100644
--- a/arch/arm/mach-imx/mx6/Kconfig
+++ b/arch/arm/mach-imx/mx6/Kconfig
@@ -62,6 +62,7 @@ config MX6UL_LITESOM
 	bool
 	select MX6UL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select SUPPORT_SPL
 
@@ -70,6 +71,7 @@ config MX6UL_OPOS6UL
 	select MX6UL
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_GPIO
 	select DM_MMC
 	select DM_THERMAL
@@ -108,6 +110,7 @@ config TARGET_APALIS_IMX6
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_THERMAL
 	imply CMD_SATA
@@ -129,6 +132,7 @@ config TARGET_CGTQMX6EVAL
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_CM_FX6
@@ -137,6 +141,7 @@ config TARGET_CM_FX6
 	select MX6QDL
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -145,6 +150,7 @@ config TARGET_COLIBRI_IMX6
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_THERMAL
 
@@ -155,6 +161,7 @@ config TARGET_DHCOMIMX6
 	select BOARD_EARLY_INIT_F
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	imply CMD_SPL
 
@@ -162,6 +169,7 @@ config TARGET_DISPLAY5
 	bool "LWN DISPLAY5 board"
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 
 config TARGET_EMBESTMX6BOARDS
@@ -201,6 +209,7 @@ config TARGET_MX6LOGICPD
 	select BOARD_EARLY_INIT_F
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
@@ -226,6 +235,7 @@ config TARGET_MX6DL_MAMOJ
 	select OF_CONTROL
 	select PINCTRL
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
@@ -258,6 +268,7 @@ config TARGET_MX6Q_ENGICAM
 	select OF_CONTROL
 	select SPL_OF_LIBFDT
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
@@ -275,6 +286,7 @@ config TARGET_MX6SABREAUTO
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select BOARD_EARLY_INIT_F
 
@@ -284,6 +296,7 @@ config TARGET_MX6SABRESD
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select BOARD_EARLY_INIT_F
 
@@ -297,6 +310,7 @@ config TARGET_MX6SLLEVK
 	select BOARD_LATE_INIT
         select MX6SLL
         select DM
+	imply CMD_DM
         select DM_THERMAL
 
 config TARGET_MX6SXSABRESD
@@ -305,6 +319,7 @@ config TARGET_MX6SXSABRESD
 	select MX6SX
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select BOARD_EARLY_INIT_F
 
@@ -313,6 +328,7 @@ config TARGET_MX6SXSABREAUTO
 	select BOARD_LATE_INIT
 	select MX6SX
         select DM
+	imply CMD_DM
         select DM_THERMAL
 	select BOARD_EARLY_INIT_F
 
@@ -321,6 +337,7 @@ config TARGET_MX6UL_9X9_EVK
 	select BOARD_LATE_INIT
 	select MX6UL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select SUPPORT_SPL
 
@@ -329,6 +346,7 @@ config TARGET_MX6UL_14X14_EVK
 	bool "mx6ul_14x14_evk"
 	select MX6UL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select SUPPORT_SPL
 
@@ -338,6 +356,7 @@ config TARGET_MX6UL_ENGICAM
 	select MX6UL
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
@@ -354,6 +373,7 @@ config TARGET_MX6ULL_14X14_EVK
 	select BOARD_LATE_INIT
 	select MX6ULL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_NITROGEN6X
@@ -420,6 +440,7 @@ config TARGET_KP_IMX6Q_TPC
 	select BOARD_EARLY_INIT_F
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	imply CMD_SPL
 
@@ -439,6 +460,7 @@ config TARGET_UDOO_NEO
 	select SUPPORT_SPL
 	select MX6SX
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_SAMTEC_VINING_2000
@@ -446,6 +468,7 @@ config TARGET_SAMTEC_VINING_2000
 	select BOARD_LATE_INIT
 	select MX6SX
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_WANDBOARD
@@ -464,6 +487,7 @@ config TARGET_XPRESS
 	select BOARD_LATE_INIT
 	select MX6UL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select SUPPORT_SPL
 
@@ -472,6 +496,7 @@ config TARGET_ZC5202
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_ZC5601
@@ -479,6 +504,7 @@ config TARGET_ZC5601
 	select BOARD_LATE_INIT
 	select SUPPORT_SPL
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 endchoice
diff --git a/arch/arm/mach-imx/mx7/Kconfig b/arch/arm/mach-imx/mx7/Kconfig
index 2a3db860bbcf..88b49e4725d3 100644
--- a/arch/arm/mach-imx/mx7/Kconfig
+++ b/arch/arm/mach-imx/mx7/Kconfig
@@ -24,6 +24,7 @@ config TARGET_CL_SOM_IMX7
 	bool "CL-SOM-iMX7"
 	select MX7D
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 	select SUPPORT_SPL
 
@@ -32,6 +33,7 @@ config TARGET_MX7DSABRESD
 	select BOARD_LATE_INIT
 	select MX7D
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_PICO_IMX7D
@@ -39,6 +41,7 @@ config TARGET_PICO_IMX7D
 	select BOARD_LATE_INIT
 	select MX7D
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_WARP7
@@ -46,12 +49,14 @@ config TARGET_WARP7
 	select BOARD_LATE_INIT
 	select MX7D
 	select DM
+	imply CMD_DM
 	select DM_THERMAL
 
 config TARGET_COLIBRI_IMX7
 	bool "Support Colibri iMX7S/iMX7D modules"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_THERMAL
 
diff --git a/arch/arm/mach-meson/Kconfig b/arch/arm/mach-meson/Kconfig
index 9a06ccc8610e..7e06a49ee7ba 100644
--- a/arch/arm/mach-meson/Kconfig
+++ b/arch/arm/mach-meson/Kconfig
@@ -5,6 +5,7 @@ config MESON_GXBB
 	select ARM64
 	select CLK
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	help
 	  The Amlogic Meson GXBaby (S905) is an ARM SoC with a
@@ -15,6 +16,7 @@ config MESON_GXL
 	select ARM64
 	select CLK
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	help
 	  The Amlogic Meson GXL (S905X and S905X) is an ARM SoC with a
diff --git a/arch/arm/mach-omap2/am33xx/Kconfig b/arch/arm/mach-omap2/am33xx/Kconfig
index 76da6d911ed6..5322bc7fc23d 100644
--- a/arch/arm/mach-omap2/am33xx/Kconfig
+++ b/arch/arm/mach-omap2/am33xx/Kconfig
@@ -31,6 +31,7 @@ config TARGET_AM335X_EVM
 	bool "Support am335x_evm"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select TI_I2C_BOARD_DETECT
@@ -65,6 +66,7 @@ config TARGET_AM335X_BALTOS
 	bool "Support am335x_baltos"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -72,6 +74,7 @@ config TARGET_AM335X_IGEP003X
 	bool "Support am335x_igep003x"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -79,6 +82,7 @@ config TARGET_AM335X_SHC
 	bool "Support am335x based shc board from bosch"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	imply CMD_SPL
@@ -87,6 +91,7 @@ config TARGET_AM335X_SL50
 	bool "Support am335x_sl50"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -94,6 +99,7 @@ config TARGET_BAV335X
 	bool "Support bav335x"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	help
 	  The BAV335x OEM Network Processor integrates all the functions of an
@@ -117,11 +123,13 @@ config TARGET_CHILIBOARD
 	select AM33XX_CHILISOM
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 
 config TARGET_CM_T335
 	bool "Support cm_t335"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -129,6 +137,7 @@ config TARGET_DRACO
 	bool "Support draco"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -136,24 +145,28 @@ config TARGET_ETAMIN
 	bool "Support etamin"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
 config TARGET_PCM051
 	bool "Support pcm051"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
 config TARGET_PENGWYN
 	bool "Support pengwyn"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
 config TARGET_PEPPER
 	bool "Support pepper"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -161,6 +174,7 @@ config TARGET_PXM2
 	bool "Support pxm2"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -168,6 +182,7 @@ config TARGET_RASTABAN
 	bool "Support rastaban"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -175,6 +190,7 @@ config TARGET_RUT
 	bool "Support rut"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -182,12 +198,14 @@ config TARGET_THUBAN
 	bool "Support thuban"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
 config TARGET_PDU001
 	bool "Support PDU001"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	help
 	  Support for PDU001 platform developed by EETS GmbH.
diff --git a/arch/arm/mach-omap2/omap3/Kconfig b/arch/arm/mach-omap2/omap3/Kconfig
index 6d714f6cdb2c..05daceebd1b7 100644
--- a/arch/arm/mach-omap2/omap3/Kconfig
+++ b/arch/arm/mach-omap2/omap3/Kconfig
@@ -23,6 +23,7 @@ choice
 config TARGET_AM3517_EVM
 	bool "AM3517 EVM"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select DM_I2C
@@ -36,6 +37,7 @@ config TARGET_MT_VENTOUX
 config TARGET_OMAP3_BEAGLE
 	bool "TI OMAP3 BeagleBoard"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OMAP3_GPIO_5
@@ -56,12 +58,14 @@ config TARGET_CM_T3517
 config TARGET_DEVKIT8000
 	bool "TimLL OMAP3 Devkit8000"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
 config TARGET_OMAP3_EVM
 	bool "TI OMAP3 EVM"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OMAP3_GPIO_3
@@ -69,6 +73,7 @@ config TARGET_OMAP3_EVM
 config TARGET_OMAP3_IGEP00X0
 	bool "IGEP"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OMAP3_GPIO_3
@@ -78,6 +83,7 @@ config TARGET_OMAP3_IGEP00X0
 config TARGET_OMAP3_OVERO
 	bool "OMAP35xx Gumstix Overo"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OMAP3_GPIO_2
@@ -89,6 +95,7 @@ config TARGET_OMAP3_OVERO
 config TARGET_OMAP3_ZOOM1
 	bool "TI Zoom1"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
@@ -118,6 +125,7 @@ config TARGET_OMAP3_LOGIC
 	bool "OMAP3 Logic"
 	select BOARD_LATE_INIT
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OMAP3_GPIO_3
@@ -143,12 +151,14 @@ config TARGET_TWISTER
 config TARGET_OMAP3_CAIRO
 	bool "QUIPOS CAIRO"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 
 config TARGET_SNIPER
 	bool "LG Optimus Black"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select OMAP3_GPIO_2
diff --git a/arch/arm/mach-rmobile/Kconfig.32 b/arch/arm/mach-rmobile/Kconfig.32
index c0b5b2457cb1..f4493ebd0b3a 100644
--- a/arch/arm/mach-rmobile/Kconfig.32
+++ b/arch/arm/mach-rmobile/Kconfig.32
@@ -40,12 +40,14 @@ config TARGET_ARMADILLO_800EVA
 config TARGET_BLANCHE
 	bool "Blanche board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select USE_TINY_PRINTF
 
 config TARGET_GOSE
 	bool "Gose board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
@@ -54,6 +56,7 @@ config TARGET_GOSE
 config TARGET_KOELSCH
 	bool "Koelsch board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
@@ -62,6 +65,7 @@ config TARGET_KOELSCH
 config TARGET_LAGER
 	bool "Lager board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
@@ -73,6 +77,7 @@ config TARGET_KZM9G
 config TARGET_ALT
 	bool "Alt board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
@@ -81,6 +86,7 @@ config TARGET_ALT
 config TARGET_SILK
 	bool "Silk board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
@@ -89,6 +95,7 @@ config TARGET_SILK
 config TARGET_PORTER
 	bool "Porter board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
@@ -97,6 +104,7 @@ config TARGET_PORTER
 config TARGET_STOUT
 	bool "Stout board"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SUPPORT_SPL
 	select USE_TINY_PRINTF
diff --git a/arch/arm/mach-tegra/Kconfig b/arch/arm/mach-tegra/Kconfig
index 0fb0c6339018..7dcf2199c50c 100644
--- a/arch/arm/mach-tegra/Kconfig
+++ b/arch/arm/mach-tegra/Kconfig
@@ -24,6 +24,7 @@ config TEGRA_COMMON
 	bool "Tegra common options"
 	select CLK
 	select DM
+	imply CMD_DM
 	select DM_ETH
 	select DM_GPIO
 	select DM_I2C
diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig
index c56459345136..ca5dbe8b2ad1 100644
--- a/arch/microblaze/Kconfig
+++ b/arch/microblaze/Kconfig
@@ -14,6 +14,7 @@ config TARGET_MICROBLAZE_GENERIC
 	select SUPPORT_SPL
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select SYSRESET
 
diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index d07b92d1b442..c66fa2198e17 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -25,6 +25,7 @@ config TARGET_QEMU_MIPS
 config TARGET_MALTA
 	bool "Support malta"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DYNAMIC_IO_PORT_BASE
 	select MIPS_CM
@@ -74,11 +75,13 @@ config ARCH_ATH79
 	bool "Support QCA/Atheros ath79"
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 
 config ARCH_BMIPS
 	bool "Support BMIPS SoCs"
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select CLK
 	select CPU
 	select RAM
@@ -88,10 +91,12 @@ config MACH_PIC32
 	bool "Support Microchip PIC32"
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 
 config TARGET_BOSTON
 	bool "Support Boston"
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select OF_CONTROL
 	select MIPS_CM
@@ -112,6 +117,7 @@ config TARGET_XILFPGA
 	bool "Support Imagination Xilfpga"
 	select OF_CONTROL
 	select DM
+	imply CMD_DM
 	select DM_SERIAL
 	select DM_GPIO
 	select DM_ETH
diff --git a/arch/powerpc/cpu/mpc83xx/Kconfig b/arch/powerpc/cpu/mpc83xx/Kconfig
index 05d29d2fd95f..f37223d7656f 100644
--- a/arch/powerpc/cpu/mpc83xx/Kconfig
+++ b/arch/powerpc/cpu/mpc83xx/Kconfig
@@ -64,6 +64,7 @@ config TARGET_MPC837XERDB
 config TARGET_IDS8313
 	bool "Support ids8313"
 	select DM
+	imply CMD_DM
 
 config TARGET_KM8360
 	bool "Support km8360"
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 2fa0829925c1..44a1bc569f70 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -640,7 +640,6 @@ config CMD_DFU
 config CMD_DM
 	bool "dm - Access to driver model information"
 	depends on DM
-	default y
 	help
 	  Provides access to driver model data structures and information,
 	  such as a list of devices, list of uclasses and the state of each
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling
  2018-07-20 12:05 ` [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling Michal Simek
@ 2018-07-20 12:53   ` Tom Rini
  2018-07-23  6:40     ` Michal Simek
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-07-20 12:53 UTC (permalink / raw)
  To: u-boot

On Fri, Jul 20, 2018 at 02:05:07PM +0200, Michal Simek wrote:

> CMD_DM is used for debug purpose and it shouldn't be enabled by default
> via Kconfig. Unfortunately this is in the tree for quite a long time
> that's why solution is to use imply DM for all targets which are
> enabling DM.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
> Based on this discussion:
> https://lists.denx.de/pipermail/u-boot/2018-July/334952.html
> 
> Done by:
> for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
> uniq`; do
> 	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
> done

OK, I'm glad you did this, but now the (mostly) sorted lists are
un-sorted.  Please update to keep them alphabetically sorted, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180720/d392a06f/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling
  2018-07-20 12:53   ` Tom Rini
@ 2018-07-23  6:40     ` Michal Simek
  2018-07-23 12:15       ` Tom Rini
  0 siblings, 1 reply; 7+ messages in thread
From: Michal Simek @ 2018-07-23  6:40 UTC (permalink / raw)
  To: u-boot

On 20.7.2018 14:53, Tom Rini wrote:
> On Fri, Jul 20, 2018 at 02:05:07PM +0200, Michal Simek wrote:
> 
>> CMD_DM is used for debug purpose and it shouldn't be enabled by default
>> via Kconfig. Unfortunately this is in the tree for quite a long time
>> that's why solution is to use imply DM for all targets which are
>> enabling DM.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Based on this discussion:
>> https://lists.denx.de/pipermail/u-boot/2018-July/334952.html
>>
>> Done by:
>> for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
>> uniq`; do
>> 	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
>> done
> 
> OK, I'm glad you did this, but now the (mostly) sorted lists are
> un-sorted.  Please update to keep them alphabetically sorted, thanks!

How this should be sorted?
sorted "select" list first followed by sorted "imply" list?

Thanks,
Michal

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling
  2018-07-23  6:40     ` Michal Simek
@ 2018-07-23 12:15       ` Tom Rini
  2018-07-23 13:56         ` Michal Simek
  0 siblings, 1 reply; 7+ messages in thread
From: Tom Rini @ 2018-07-23 12:15 UTC (permalink / raw)
  To: u-boot

On Mon, Jul 23, 2018 at 08:40:51AM +0200, Michal Simek wrote:
> On 20.7.2018 14:53, Tom Rini wrote:
> > On Fri, Jul 20, 2018 at 02:05:07PM +0200, Michal Simek wrote:
> > 
> >> CMD_DM is used for debug purpose and it shouldn't be enabled by default
> >> via Kconfig. Unfortunately this is in the tree for quite a long time
> >> that's why solution is to use imply DM for all targets which are
> >> enabling DM.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >> Based on this discussion:
> >> https://lists.denx.de/pipermail/u-boot/2018-July/334952.html
> >>
> >> Done by:
> >> for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
> >> uniq`; do
> >> 	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
> >> done
> > 
> > OK, I'm glad you did this, but now the (mostly) sorted lists are
> > un-sorted.  Please update to keep them alphabetically sorted, thanks!
> 
> How this should be sorted?
> sorted "select" list first followed by sorted "imply" list?

Yes, that's approximately how I've been doing it.  It won't be 100%
sorted as some arches aren't, but it should be close.  Thanks again!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180723/c3b00406/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling
  2018-07-23 12:15       ` Tom Rini
@ 2018-07-23 13:56         ` Michal Simek
  0 siblings, 0 replies; 7+ messages in thread
From: Michal Simek @ 2018-07-23 13:56 UTC (permalink / raw)
  To: u-boot

On 23.7.2018 14:15, Tom Rini wrote:
> On Mon, Jul 23, 2018 at 08:40:51AM +0200, Michal Simek wrote:
>> On 20.7.2018 14:53, Tom Rini wrote:
>>> On Fri, Jul 20, 2018 at 02:05:07PM +0200, Michal Simek wrote:
>>>
>>>> CMD_DM is used for debug purpose and it shouldn't be enabled by default
>>>> via Kconfig. Unfortunately this is in the tree for quite a long time
>>>> that's why solution is to use imply DM for all targets which are
>>>> enabling DM.
>>>>
>>>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>>>> ---
>>>>
>>>> Based on this discussion:
>>>> https://lists.denx.de/pipermail/u-boot/2018-July/334952.html
>>>>
>>>> Done by:
>>>> for i in `git grep "select DM" | grep -v DM_ | cut -d ':' -f 1 | sort |
>>>> uniq`; do
>>>> 	sed -i 's/select DM$/select DM\n\timply CMD_DM/g' $i;
>>>> done
>>>
>>> OK, I'm glad you did this, but now the (mostly) sorted lists are
>>> un-sorted.  Please update to keep them alphabetically sorted, thanks!
>>
>> How this should be sorted?
>> sorted "select" list first followed by sorted "imply" list?
> 
> Yes, that's approximately how I've been doing it.  It won't be 100%
> sorted as some arches aren't, but it should be close.  Thanks again!

Ok. Patches sent. I have done some sorting before this patch.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM
  2018-07-20 12:05 [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM Michal Simek
  2018-07-20 12:05 ` [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling Michal Simek
@ 2018-07-20 12:53 ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-07-20 12:53 UTC (permalink / raw)
  To: u-boot

On Fri, Jul 20, 2018 at 02:05:06PM +0200, Michal Simek wrote:

> Better use depends on instead of select.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180720/bd00579a/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-07-23 13:56 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-20 12:05 [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM Michal Simek
2018-07-20 12:05 ` [U-Boot] [PATCH 2/2] dm: Change CMD_DM enabling Michal Simek
2018-07-20 12:53   ` Tom Rini
2018-07-23  6:40     ` Michal Simek
2018-07-23 12:15       ` Tom Rini
2018-07-23 13:56         ` Michal Simek
2018-07-20 12:53 ` [U-Boot] [PATCH 1/2] common: Log should depends on DM not be selected by DM Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.