From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Markus Heiser <markus.heiser@darmarit.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Sphinx version dependencies?
Date: Fri, 20 Jul 2018 10:52:35 -0400 [thread overview]
Message-ID: <20180720145235.GA27862@thunk.org> (raw)
In-Reply-To: <d064f468ab9fc60a02242331e0dddc185d6556ba.camel@darmarit.de>
On Fri, Jul 20, 2018 at 03:45:37PM +0200, Markus Heiser wrote:
> Am Freitag, den 20.07.2018, 09:12 -0400 schrieb Theodore Y. Ts'o:
> > I'm not entirely sure what's the best approach. Right now I just want
> > to understand --- do I have to make ext4.rst work against one, or many
> > versions of Sphinx? And which version(s) of Sphinx do I need to
> > concern myself with? If that turns out to be an onerous burden, I'm
> > sure I won't be the only person complaining. :-)
>
> In that case ...
>
> > But when I did that, Sphinx had heartburn over the ext4.rst file.
> >
> > ./include/linux/spi/spi.h:373: ERROR: Unexpected indentation.
> > /usr/projects/linux/ext4/Documentation/filesystems/ext4/ext4.rst:139: ERROR: Malformed table.
> > Column span alignment problem in table line 5.
>
> ... its clear; the table was malformed. A markup error which is not detected
> by older versions of docutils (very special case).
... except that newer verions are A-OK with it. Apparently 1.3.x was
OK with it, and 1.6.x and 1.7.x were ok with it. ***ONLY*** Sphinx
1.4.9 blew up on the "malformed table".
So in this case, Darrick has come up with a patch that is makes it OK
with 1.4.9 without breaking on 1.7.5 --- and obviously, doing
something that makes it broadly portable is the right thing.
I'm asking a larger question, which is moving forward, which is more
important? Make it work with Sphinx 1.4.9? Or making it Sphinx work
with Sphinx 1.7.5?
And should we change Documentation/sphinx/requirements.txt to require
something newer, such as Sphinx 1.7.5? And should we require that
Ubuntu 18.04 which is using Sphinx 1.6.8 use a virtualenv and use
download Sphinx 1.6.8?
My understanding that the Sphinx developers make no guarantees that if
we follow some external, version-indepedent spec, that it will work on
Sphinx version N, as well as Sphinx version N+1. (In the ideal world,
if there was such an independent spec for .rst format files, and a
compliant .rst file doesn't work for Sphinx version N, it's a bug, and
we should expect somebody --- perhaps the Distro's --- to backport the
fix from Sphinx version N+1 to Sphinx version N.) E.g., is there an
equivalent for ANSI C 1999 standard for .rst files?
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Markus Heiser <markus.heiser@darmarit.de>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Sphinx version dependencies?
Date: Fri, 20 Jul 2018 10:52:35 -0400 [thread overview]
Message-ID: <20180720145235.GA27862@thunk.org> (raw)
In-Reply-To: <d064f468ab9fc60a02242331e0dddc185d6556ba.camel@darmarit.de>
On Fri, Jul 20, 2018 at 03:45:37PM +0200, Markus Heiser wrote:
> Am Freitag, den 20.07.2018, 09:12 -0400 schrieb Theodore Y. Ts'o:
> > I'm not entirely sure what's the best approach. Right now I just want
> > to understand --- do I have to make ext4.rst work against one, or many
> > versions of Sphinx? And which version(s) of Sphinx do I need to
> > concern myself with? If that turns out to be an onerous burden, I'm
> > sure I won't be the only person complaining. :-)
>
> In that case ...
>
> > But when I did that, Sphinx had heartburn over the ext4.rst file.
> >
> > ./include/linux/spi/spi.h:373: ERROR: Unexpected indentation.
> > /usr/projects/linux/ext4/Documentation/filesystems/ext4/ext4.rst:139: ERROR: Malformed table.
> > Column span alignment problem in table line 5.
>
> ... its clear; the table was malformed. A markup error which is not detected
> by older versions of docutils (very special case).
... except that newer verions are A-OK with it. Apparently 1.3.x was
OK with it, and 1.6.x and 1.7.x were ok with it. ***ONLY*** Sphinx
1.4.9 blew up on the "malformed table".
So in this case, Darrick has come up with a patch that is makes it OK
with 1.4.9 without breaking on 1.7.5 --- and obviously, doing
something that makes it broadly portable is the right thing.
I'm asking a larger question, which is moving forward, which is more
important? Make it work with Sphinx 1.4.9? Or making it Sphinx work
with Sphinx 1.7.5?
And should we change Documentation/sphinx/requirements.txt to require
something newer, such as Sphinx 1.7.5? And should we require that
Ubuntu 18.04 which is using Sphinx 1.6.8 use a virtualenv and use
download Sphinx 1.6.8?
My understanding that the Sphinx developers make no guarantees that if
we follow some external, version-indepedent spec, that it will work on
Sphinx version N, as well as Sphinx version N+1. (In the ideal world,
if there was such an independent spec for .rst format files, and a
compliant .rst file doesn't work for Sphinx version N, it's a bug, and
we should expect somebody --- perhaps the Distro's --- to backport the
fix from Sphinx version N+1 to Sphinx version N.) E.g., is there an
equivalent for ANSI C 1999 standard for .rst files?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-07-20 14:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 18:15 Sphinx version dependencies? Theodore Y. Ts'o
2018-07-19 19:04 ` Darrick J. Wong
2018-07-20 7:30 ` Markus Heiser
2018-07-20 7:30 ` Markus Heiser
2018-07-20 13:12 ` Theodore Y. Ts'o
2018-07-20 13:12 ` Theodore Y. Ts'o
2018-07-20 13:45 ` Markus Heiser
2018-07-20 13:45 ` Markus Heiser
2018-07-20 14:52 ` Theodore Y. Ts'o [this message]
2018-07-20 14:52 ` Theodore Y. Ts'o
2018-07-20 16:00 ` Markus Heiser
2018-07-20 16:00 ` Markus Heiser
2018-07-20 16:44 ` Darrick J. Wong
2018-07-20 16:44 ` Darrick J. Wong
2018-07-20 16:58 ` Markus Heiser
2018-07-20 16:58 ` Markus Heiser
2018-07-20 17:10 ` Darrick J. Wong
2018-07-20 17:10 ` Darrick J. Wong
2018-07-20 20:43 ` Theodore Y. Ts'o
2018-07-20 20:43 ` Theodore Y. Ts'o
2018-07-20 21:28 ` Markus Heiser
2018-07-20 21:28 ` Markus Heiser
2018-07-21 10:38 ` Jonathan Corbet
2018-07-21 10:38 ` Jonathan Corbet
2018-07-20 15:04 ` Christoph Hellwig
2018-07-20 15:04 ` Christoph Hellwig
2018-07-20 16:28 ` Markus Heiser
2018-07-20 16:28 ` Markus Heiser
2018-07-20 17:08 ` Darrick J. Wong
2018-07-20 17:08 ` Darrick J. Wong
2018-07-20 17:08 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720145235.GA27862@thunk.org \
--to=tytso@mit.edu \
--cc=corbet@lwn.net \
--cc=darrick.wong@oracle.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.heiser@darmarit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.