All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: Karoly Pados <pados@pados.hu>, Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v4] USB: serial: cp210x: Implement GPIO support for CP2102N
Date: Fri, 20 Jul 2018 19:03:00 +0200	[thread overview]
Message-ID: <20180720170300.GH19245@localhost> (raw)

On Fri, Jul 20, 2018 at 04:22:17PM +0100, Martyn Welch wrote:
> On Fri, 2018-07-20 at 12:35 +0000, Karoly Pados wrote:
> > This patch adds GPIO support for CP2102N devices.
> > 
> > It introduces new generic code to support emulating separate
> > input and outputs directions even though these devices
> > only know output modes (open-drain and pushpull). Existing
> > GPIO support for CP2105 has been migrated over to the new
> > code structure.
> > 
> > Only limitation is that for the QFN28 variant, only 4 out of
> > 7 GPIOs are supported. This is because the config array
> > locations of the last 3 pins are not documented, and reverse
> > engineering revealed offsets that conflicted with other
> > documented functions. Hence we'll play it safe instead
> > until somebody clears this up further.
> > 
> > Signed-off-by: Karoly Pados <pados@pados.hu>

Thanks for the updated commit message, looks goods now.

> As Johan made some changes, I think his Signed-off-by should be here
> as is in v3.

Right. I actually just replaced the commit message in v3 which had a
note about what I had changed.

> Other than that:
> 
> Acked-by: Martyn Welch <martyn.welch@collabora.co.uk>

Thanks for the ack.

And again, thanks to both of you for getting this useful functionality
in place.

Johan
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Martyn Welch <martyn.welch@collabora.co.uk>
Cc: Karoly Pados <pados@pados.hu>, Johan Hovold <johan@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] USB: serial: cp210x: Implement GPIO support for CP2102N
Date: Fri, 20 Jul 2018 19:03:00 +0200	[thread overview]
Message-ID: <20180720170300.GH19245@localhost> (raw)
In-Reply-To: <1532100137.6926.10.camel@collabora.co.uk>

On Fri, Jul 20, 2018 at 04:22:17PM +0100, Martyn Welch wrote:
> On Fri, 2018-07-20 at 12:35 +0000, Karoly Pados wrote:
> > This patch adds GPIO support for CP2102N devices.
> > 
> > It introduces new generic code to support emulating separate
> > input and outputs directions even though these devices
> > only know output modes (open-drain and pushpull). Existing
> > GPIO support for CP2105 has been migrated over to the new
> > code structure.
> > 
> > Only limitation is that for the QFN28 variant, only 4 out of
> > 7 GPIOs are supported. This is because the config array
> > locations of the last 3 pins are not documented, and reverse
> > engineering revealed offsets that conflicted with other
> > documented functions. Hence we'll play it safe instead
> > until somebody clears this up further.
> > 
> > Signed-off-by: Karoly Pados <pados@pados.hu>

Thanks for the updated commit message, looks goods now.

> As Johan made some changes, I think his Signed-off-by should be here
> as is in v3.

Right. I actually just replaced the commit message in v3 which had a
note about what I had changed.

> Other than that:
> 
> Acked-by: Martyn Welch <martyn.welch@collabora.co.uk>

Thanks for the ack.

And again, thanks to both of you for getting this useful functionality
in place.

Johan

             reply	other threads:[~2018-07-20 17:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-20 17:03 Johan Hovold [this message]
2018-07-20 17:03 ` [PATCH v4] USB: serial: cp210x: Implement GPIO support for CP2102N Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2018-07-20 15:22 [v4] " Martyn Welch
2018-07-20 15:22 ` [PATCH v4] " Martyn Welch
2018-07-20 12:35 [v4] " Karoly Pados
2018-07-20 12:35 ` [PATCH v4] " Karoly Pados
2018-07-20 10:52 [v3] " Johan Hovold
2018-07-20 10:52 ` [PATCH v3] " Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720170300.GH19245@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=martyn.welch@collabora.co.uk \
    --cc=pados@pados.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.