All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot,V3,1/2] spl: Fix redundant image of uboot
Date: Fri, 20 Jul 2018 15:54:49 -0400	[thread overview]
Message-ID: <20180720195449.GT11755@bill-the-cat> (raw)
In-Reply-To: <20180706150920.GA30520@panicking>

On Fri, Jul 06, 2018 at 05:09:22PM +0200, Michael Trimarchi wrote:

> We need to address the redundat image case and undestand if the
> image is corrupted or not. In error case we need to try the fallback copy.
> The function used before was always return 0 without any evaluation of the
> error. We try to make it work properly
> 
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> Changes V2->V3:
>         Fix patch mistake due the a wrong edit of it
> Changes V1->V2:
>         Address the comments on using the err variable
> ---
>  common/spl/spl_nand.c | 34 +++++++++++++++++++++++++---------
>  1 file changed, 25 insertions(+), 9 deletions(-)

I see two problems here.  First, this is a generic issue (any
legacy-style U-Boot image that we load should be verified).  Second, we
need to make this behavior configurable as as-is this overflows one
board (omapl138_lcdk) and I expect would be problematic for many more
boards when we make it done more commonly.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180720/c81bbd92/attachment.sig>

  parent reply	other threads:[~2018-07-20 19:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04 13:53 [U-Boot] [PATCH 1/2] spl: Fix redundant image of uboot Michael Trimarchi
2018-07-04 13:53 ` [U-Boot] [PATCH 2/2] spl: Make the spl_nand_load_image static Michael Trimarchi
2018-07-20 22:34   ` [U-Boot] [U-Boot,2/2] " Tom Rini
2018-07-04 14:19 ` [U-Boot] [PATCH 1/2] spl: Fix redundant image of uboot Lothar Waßmann
2018-07-04 14:27   ` Michael Nazzareno Trimarchi
2018-07-04 15:10     ` Lothar Waßmann
2018-07-04 15:12       ` Michael Nazzareno Trimarchi
2018-07-06  6:08       ` [U-Boot] [PATCH V2 " Michael Trimarchi
2018-07-06 15:09         ` [U-Boot] [PATCH V3 " Michael Trimarchi
2018-07-11 11:37           ` Michael Nazzareno Trimarchi
2018-07-11 12:16             ` Lothar Waßmann
2018-07-20 19:54           ` Tom Rini [this message]
2018-07-20 20:09             ` [U-Boot] [U-Boot,V3,1/2] " Michael Nazzareno Trimarchi
2018-07-20 20:11               ` Tom Rini
2018-07-20 20:27                 ` Michael Nazzareno Trimarchi
2018-07-20 20:56                   ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180720195449.GT11755@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.