From: Pavel Machek <pavel@ucw.cz>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Kiran Gunda <kgunda@codeaurora.org>,
bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Fri, 20 Jul 2018 23:21:29 +0200 [thread overview]
Message-ID: <20180720212128.GA13883@amd> (raw)
In-Reply-To: <e5bdf2fe-321a-f2e5-22f5-c886f019ac1a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi!
> >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx)
> > }
> > #define WLED3 3
> >+#define WLED4 4
>
> Are these macros always going to define 3 to be 3 and 4 to be 4. If so we
> probably don't need them (and they should be removed from patch 5/8 too).
>
> There is a degree of nitpicking here however. The rest looks OK to me.
Really nitpicking, and I don't care much either way, but as natural
numbering would be 0-based, I'd keep the defines.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Kiran Gunda <kgunda@codeaurora.org>,
bjorn.andersson@linaro.org, jingoohan1@gmail.com,
lee.jones@linaro.org, b.zolnierkie@samsung.com,
dri-devel@lists.freedesktop.org, jacek.anaszewski@gmail.com,
robh+dt@kernel.org, mark.rutland@arm.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral
Date: Fri, 20 Jul 2018 21:21:29 +0000 [thread overview]
Message-ID: <20180720212128.GA13883@amd> (raw)
In-Reply-To: <e5bdf2fe-321a-f2e5-22f5-c886f019ac1a@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 659 bytes --]
Hi!
> >@@ -332,6 +529,7 @@ static u32 wled_values(const struct wled_var_cfg *cfg, u32 idx)
> > }
> > #define WLED3 3
> >+#define WLED4 4
>
> Are these macros always going to define 3 to be 3 and 4 to be 4. If so we
> probably don't need them (and they should be removed from patch 5/8 too).
>
> There is a degree of nitpicking here however. The rest looks OK to me.
Really nitpicking, and I don't care much either way, but as natural
numbering would be 0-based, I'd keep the defines.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-07-20 21:21 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 10:22 [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 1/8] backlight: qcom-wled: Rename pm8941-wled.c to qcom-wled.c Kiran Gunda
2018-07-09 10:34 ` Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 2/8] backlight: qcom-wled: restructure the qcom-wled bindings Kiran Gunda
2018-07-09 10:22 ` [PATCH V4 3/8] backlight: qcom-wled: Add new properties for PMI8998 Kiran Gunda
2018-07-11 15:12 ` Rob Herring
2018-07-20 13:15 ` Daniel Thompson
2018-07-20 13:15 ` Daniel Thompson
2018-08-07 5:23 ` Bjorn Andersson
2018-08-16 5:23 ` kgunda
2018-09-03 18:55 ` Bjorn Andersson
2018-09-26 5:31 ` kgunda
2018-07-09 10:22 ` [PATCH V4 4/8] backlight: qcom-wled: Rename PM8941* to WLED3 Kiran Gunda
2018-07-09 10:34 ` Kiran Gunda
2018-07-20 13:23 ` Daniel Thompson
2018-07-20 13:23 ` Daniel Thompson
2018-07-23 5:55 ` kgunda
2018-07-23 5:55 ` kgunda
2018-08-07 5:41 ` Bjorn Andersson
2018-08-07 5:41 ` Bjorn Andersson
2018-08-16 5:30 ` kgunda
2018-08-16 5:42 ` kgunda
2018-07-09 10:22 ` [PATCH V4 5/8] backlight: qcom-wled: Restructure the driver for WLED3 Kiran Gunda
2018-07-09 10:34 ` Kiran Gunda
2018-07-20 13:40 ` Daniel Thompson
2018-07-20 13:40 ` Daniel Thompson
2018-07-20 13:40 ` Daniel Thompson
2018-08-07 5:37 ` Bjorn Andersson
2018-08-07 5:37 ` Bjorn Andersson
2018-08-16 5:28 ` kgunda
2018-08-16 5:40 ` kgunda
2018-07-09 10:22 ` [PATCH V4 6/8] backlight: qcom-wled: Add support for WLED4 peripheral Kiran Gunda
2018-07-09 10:34 ` Kiran Gunda
2018-07-20 13:47 ` Daniel Thompson
2018-07-20 13:47 ` Daniel Thompson
2018-07-20 13:47 ` Daniel Thompson
2018-07-20 21:21 ` Pavel Machek [this message]
2018-07-20 21:21 ` Pavel Machek
2018-07-23 6:16 ` kgunda
2018-07-23 6:28 ` kgunda
2018-08-07 5:45 ` Bjorn Andersson
2018-08-07 5:45 ` Bjorn Andersson
2018-07-09 10:22 ` [PATCH V4 7/8] backlight: qcom-wled: add support for short circuit handling Kiran Gunda
2018-07-09 10:34 ` Kiran Gunda
2018-07-20 14:07 ` Daniel Thompson
2018-07-20 14:07 ` Daniel Thompson
2018-07-20 14:07 ` Daniel Thompson
2018-07-23 6:05 ` kgunda
2018-07-23 6:17 ` kgunda
2018-07-09 10:22 ` [PATCH V4 8/8] backlight: qcom-wled: Add auto string detection logic Kiran Gunda
2018-07-09 10:34 ` Kiran Gunda
2018-08-07 6:32 ` Bjorn Andersson
2018-08-07 6:32 ` Bjorn Andersson
2018-08-16 5:33 ` kgunda
2018-08-16 5:45 ` kgunda
2018-08-03 7:19 ` [PATCH V4 0/8] backlight: qcom-wled: Support for QCOM wled driver kgunda
2018-08-03 7:45 ` Daniel Thompson
2018-08-03 7:45 ` Daniel Thompson
2018-08-06 10:58 ` kgunda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720212128.GA13883@amd \
--to=pavel@ucw.cz \
--cc=b.zolnierkie@samsung.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=kgunda@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.