From: Simon Shields <simon@lineageos.org>
To: linux-samsung-soc@vger.kernel.org
Cc: Simon Shields <simon@lineageos.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/5] ARM: dts: exynos: add pinctrl config for midas keys
Date: Sat, 21 Jul 2018 22:50:50 +1000 [thread overview]
Message-ID: <20180721125128.31498-3-simon@lineageos.org> (raw)
In-Reply-To: <20180721125128.31498-1-simon@lineageos.org>
This pins are externally pulled up, and so we should explicitly
configure them to disable the SoC-internal pull-downs. Previously
we relied on the bootloader doing this in order to allow the buttons
to function properly.
Signed-off-by: Simon Shields <simon@lineageos.org>
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
index ee7cda1432f7..6f7b564905ab 100644
--- a/arch/arm/boot/dts/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
@@ -112,6 +112,8 @@
gpio-keys {
compatible = "gpio-keys";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio_keys>;
key-down {
gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
@@ -1126,6 +1128,11 @@
pinctrl-names = "default";
pinctrl-0 = <&sleep1>;
+ gpio_keys: gpio-keys {
+ samsung,pins = "gpx0-1", "gpx2-2", "gpx2-7", "gpx3-3";
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+ };
+
max77693_irq: max77693-irq {
samsung,pins = "gpx1-5";
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
--
2.18.0
WARNING: multiple messages have this Message-ID (diff)
From: simon@lineageos.org (Simon Shields)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: dts: exynos: add pinctrl config for midas keys
Date: Sat, 21 Jul 2018 22:50:50 +1000 [thread overview]
Message-ID: <20180721125128.31498-3-simon@lineageos.org> (raw)
In-Reply-To: <20180721125128.31498-1-simon@lineageos.org>
This pins are externally pulled up, and so we should explicitly
configure them to disable the SoC-internal pull-downs. Previously
we relied on the bootloader doing this in order to allow the buttons
to function properly.
Signed-off-by: Simon Shields <simon@lineageos.org>
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi b/arch/arm/boot/dts/exynos4412-midas.dtsi
index ee7cda1432f7..6f7b564905ab 100644
--- a/arch/arm/boot/dts/exynos4412-midas.dtsi
+++ b/arch/arm/boot/dts/exynos4412-midas.dtsi
@@ -112,6 +112,8 @@
gpio-keys {
compatible = "gpio-keys";
+ pinctrl-names = "default";
+ pinctrl-0 = <&gpio_keys>;
key-down {
gpios = <&gpx3 3 GPIO_ACTIVE_LOW>;
@@ -1126,6 +1128,11 @@
pinctrl-names = "default";
pinctrl-0 = <&sleep1>;
+ gpio_keys: gpio-keys {
+ samsung,pins = "gpx0-1", "gpx2-2", "gpx2-7", "gpx3-3";
+ samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+ };
+
max77693_irq: max77693-irq {
samsung,pins = "gpx1-5";
samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
--
2.18.0
next prev parent reply other threads:[~2018-07-21 12:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-21 12:50 [PATCH 0/5] midas: fix IRQ pin configuration Simon Shields
2018-07-21 12:50 ` Simon Shields
2018-07-21 12:50 ` [PATCH 1/5] ARM: dts: exynos: add max77693 pinctrl config for midas Simon Shields
2018-07-21 12:50 ` Simon Shields
2018-07-23 17:12 ` Krzysztof Kozlowski
2018-07-23 17:12 ` Krzysztof Kozlowski
2018-07-21 12:50 ` Simon Shields [this message]
2018-07-21 12:50 ` [PATCH 2/5] ARM: dts: exynos: add pinctrl config for midas keys Simon Shields
2018-07-23 17:12 ` Krzysztof Kozlowski
2018-07-23 17:12 ` Krzysztof Kozlowski
2018-07-21 12:50 ` [PATCH 3/5] ARM: dts: exynos: add pinctrl for midas fuelgauge irq pin Simon Shields
2018-07-21 12:50 ` Simon Shields
2018-07-23 17:13 ` Krzysztof Kozlowski
2018-07-23 17:13 ` Krzysztof Kozlowski
2018-07-21 12:50 ` [PATCH 4/5] ARM: dts: exynos: configure max77686 IRQ pin on midas Simon Shields
2018-07-21 12:50 ` Simon Shields
2018-07-23 17:13 ` Krzysztof Kozlowski
2018-07-23 17:13 ` Krzysztof Kozlowski
2018-07-21 12:50 ` [PATCH 5/5] ARM: dts: exynos: configure midas SD card CD pin Simon Shields
2018-07-21 12:50 ` Simon Shields
2018-07-23 17:13 ` Krzysztof Kozlowski
2018-07-23 17:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180721125128.31498-3-simon@lineageos.org \
--to=simon@lineageos.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.