All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line
@ 2018-07-22 18:48 Nishad Kamdar
  0 siblings, 0 replies; only message in thread
From: Nishad Kamdar @ 2018-07-22 18:48 UTC (permalink / raw)
  To: Joe Perches, Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
  Cc: driverdev-devel, devel, linux-kernel

Bring the first argument to the previous line,
remove a superfluous () in the second argument
by using !, and align the lines to match open
parenthesis. Issue found by checkpatch.

Signed-off-by: Nishad Kamdar <nishadkamdar@gmail.com>
---
Changes since v1:
 - Remove a superfluous () and use ! instead, in the second argument.
---
 drivers/staging/dgnc/dgnc_tty.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 9f9b9a5b4b27..f91eaa1c3b67 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -883,10 +883,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
 	 * touched safely, the close routine will signal the
 	 * ch_flags_wait to wake us back up.
 	 */
-	rc = wait_event_interruptible(
-				ch->ch_flags_wait,
-				(((ch->ch_tun.un_flags |
-				ch->ch_pun.un_flags) & UN_CLOSING) == 0));
+	rc = wait_event_interruptible(ch->ch_flags_wait,
+				      !((ch->ch_tun.un_flags |
+				      ch->ch_pun.un_flags) & UN_CLOSING));
 	/* If ret is non-zero, user ctrl-c'ed us */
 	if (rc)
 		return -EINTR;
-- 
2.17.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2018-07-22 18:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-22 18:48 [PATCH v2] staging: dgnc: dgnc_tty.c: Avoid '(' at the end of line Nishad Kamdar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.