* [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
@ 2018-07-23 8:02 Yue Wang
2018-07-23 8:26 ` Jussi Laako
0 siblings, 1 reply; 9+ messages in thread
From: Yue Wang @ 2018-07-23 8:02 UTC (permalink / raw)
To: linux-kernel
Cc: yuleopen, Jaroslav Kysela, Takashi Iwai, Jussi Laako,
Nobutaka Okabe, Kai-Heng Feng, Daniel Mack, Ruslan Bilovol,
Alberto Aguirre, alsa-devel
This patch adds the support for native DSD for Topping DX7s DAC. The
product description is on
http://en.tpdz.net/products_detail/productId=32.html and it's
available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21
The DAC uses XMOS chip but uses a special vendor id and product id.
The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC
hence enable native DSD playback up to DSD512 format.
Signed-off-by: Yue Wang <yuleopen@gmail.com>
---
sound/usb/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 02b6cc02767f..c51e2dee3075 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
break;
case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */
+ case USB_ID(0x152a, 0x8750): /* Topping DX7s */
case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */
case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */
case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */
--
2.18.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
2018-07-23 8:02 [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface Yue Wang
@ 2018-07-23 8:26 ` Jussi Laako
0 siblings, 0 replies; 9+ messages in thread
From: Jussi Laako @ 2018-07-23 8:26 UTC (permalink / raw)
To: Yue Wang, linux-kernel
Cc: alsa-devel, Nobutaka Okabe, Takashi Iwai, Alberto Aguirre,
Kai-Heng Feng, Ruslan Bilovol, Daniel Mack
Hi,
> + case USB_ID(0x152a, 0x8750): /* Topping DX7s */
0x152a is Thesycon's VID and if it's based on XMOS I'd recommend to try
adding the 0x152a VID to the generic DSD capability auto-detect list
instead of this old device specific list.
I consider it very likely that it would work that way and at the same
time also cover all other devices with the same firmware and Thesycon's VID.
Best regards,
- Jussi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
@ 2018-07-23 8:26 ` Jussi Laako
0 siblings, 0 replies; 9+ messages in thread
From: Jussi Laako @ 2018-07-23 8:26 UTC (permalink / raw)
To: Yue Wang, linux-kernel
Cc: Jaroslav Kysela, Takashi Iwai, Nobutaka Okabe, Kai-Heng Feng,
Daniel Mack, Ruslan Bilovol, Alberto Aguirre, alsa-devel
Hi,
> + case USB_ID(0x152a, 0x8750): /* Topping DX7s */
0x152a is Thesycon's VID and if it's based on XMOS I'd recommend to try
adding the 0x152a VID to the generic DSD capability auto-detect list
instead of this old device specific list.
I consider it very likely that it would work that way and at the same
time also cover all other devices with the same firmware and Thesycon's VID.
Best regards,
- Jussi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
2018-07-23 8:26 ` Jussi Laako
(?)
@ 2018-07-23 8:53 ` Yue Wang
-1 siblings, 0 replies; 9+ messages in thread
From: Yue Wang @ 2018-07-23 8:53 UTC (permalink / raw)
To: Jussi Laako
Cc: linux-kernel, Jaroslav Kysela, Takashi Iwai, Nobutaka Okabe,
Kai-Heng Feng, Daniel Mack, Ruslan Bilovol, Alberto Aguirre,
alsa-devel
Thanks for the comment Jussi. Let's drop this patch, and I will send a
new patch with this generic approach shortly. The new patch will have
a different commit title and message.
On Mon, Jul 23, 2018 at 1:26 AM Jussi Laako <jussi@sonarnerd.net> wrote:
>
> Hi,
>
> > + case USB_ID(0x152a, 0x8750): /* Topping DX7s */
> 0x152a is Thesycon's VID and if it's based on XMOS I'd recommend to try
> adding the 0x152a VID to the generic DSD capability auto-detect list
> instead of this old device specific list.
>
> I consider it very likely that it would work that way and at the same
> time also cover all other devices with the same firmware and Thesycon's VID.
>
>
> Best regards,
>
> - Jussi
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
@ 2018-07-23 7:25 yuleopen
2018-07-23 7:30 ` Takashi Iwai
0 siblings, 1 reply; 9+ messages in thread
From: yuleopen @ 2018-07-23 7:25 UTC (permalink / raw)
To: linux-kernel
Cc: yuleopen, Jaroslav Kysela, Takashi Iwai, Jussi Laako,
Nobutaka Okabe, Daniel Mack, Kai-Heng Feng, Ruslan Bilovol,
Alberto Aguirre, alsa-devel
From: Yue Wang <yuleopen@gmail.com>
Signed-off-by: Yue Wang <yuleopen@gmail.com>
---
sound/usb/quirks.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
index 02b6cc02767f..c51e2dee3075 100644
--- a/sound/usb/quirks.c
+++ b/sound/usb/quirks.c
@@ -1374,6 +1374,7 @@ u64 snd_usb_interface_dsd_format_quirks(struct snd_usb_audio *chip,
break;
case USB_ID(0x0d8c, 0x0316): /* Hegel HD12 DSD */
+ case USB_ID(0x152a, 0x8750): /* Topping DX7s */
case USB_ID(0x16b0, 0x06b2): /* NuPrime DAC-10 */
case USB_ID(0x16d0, 0x0733): /* Furutech ADL Stratos */
case USB_ID(0x16d0, 0x09db): /* NuPrime Audio DAC-9 */
--
2.17.0.441.gb46fe60e1d-goog
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
2018-07-23 7:25 yuleopen
@ 2018-07-23 7:30 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2018-07-23 7:30 UTC (permalink / raw)
To: yuleopen
Cc: linux-kernel, alsa-devel, Kai-Heng Feng, Alberto Aguirre,
Nobutaka Okabe, Ruslan Bilovol, Jaroslav Kysela, Jussi Laako,
Daniel Mack
On Mon, 23 Jul 2018 09:25:34 +0200,
<yuleopen@gmail.com> wrote:
>
> From: Yue Wang <yuleopen@gmail.com>
>
> Signed-off-by: Yue Wang <yuleopen@gmail.com>
Please give more explanation.
No commit message already indicates that something is very wrong, no
matter what the change is.
thanks,
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
@ 2018-07-23 7:30 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2018-07-23 7:30 UTC (permalink / raw)
To: yuleopen
Cc: linux-kernel, alsa-devel, Kai-Heng Feng, Alberto Aguirre,
Nobutaka Okabe, Ruslan Bilovol, Jaroslav Kysela, Jussi Laako,
Daniel Mack
On Mon, 23 Jul 2018 09:25:34 +0200,
<yuleopen@gmail.com> wrote:
>
> From: Yue Wang <yuleopen@gmail.com>
>
> Signed-off-by: Yue Wang <yuleopen@gmail.com>
Please give more explanation.
No commit message already indicates that something is very wrong, no
matter what the change is.
thanks,
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
2018-07-23 7:30 ` Takashi Iwai
(?)
@ 2018-07-23 7:41 ` Yue Wang
2018-07-23 7:53 ` Takashi Iwai
-1 siblings, 1 reply; 9+ messages in thread
From: Yue Wang @ 2018-07-23 7:41 UTC (permalink / raw)
To: tiwai
Cc: linux-kernel, alsa-devel, kai.heng.feng, albaguirre, nob77413,
ruslan.bilovol, perex, jussi, daniel
Hi Takashi
My apologies, it's my first time sending a patch to the kernel, so
there're quite a few things I need to improve.
This patch adds the support for native DSD for Topping DX7s DAC. The
product description is on
http://en.tpdz.net/products_detail/productId=32.html and it's
available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21
The DAC uses XMOS chip but uses a special vendor id and product id.
The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC
hence enable native DSD playback up to DSD512 format.
Thanks again.
Yue
On Mon, Jul 23, 2018 at 12:30 AM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Mon, 23 Jul 2018 09:25:34 +0200,
> <yuleopen@gmail.com> wrote:
> >
> > From: Yue Wang <yuleopen@gmail.com>
> >
> > Signed-off-by: Yue Wang <yuleopen@gmail.com>
>
> Please give more explanation.
> No commit message already indicates that something is very wrong, no
> matter what the change is.
>
>
> thanks,
>
> Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface
2018-07-23 7:41 ` Yue Wang
@ 2018-07-23 7:53 ` Takashi Iwai
0 siblings, 0 replies; 9+ messages in thread
From: Takashi Iwai @ 2018-07-23 7:53 UTC (permalink / raw)
To: Yue Wang
Cc: linux-kernel, alsa-devel, kai.heng.feng, albaguirre, nob77413,
ruslan.bilovol, perex, jussi, daniel
On Mon, 23 Jul 2018 09:41:15 +0200,
Yue Wang wrote:
>
> Hi Takashi
>
> My apologies, it's my first time sending a patch to the kernel, so
> there're quite a few things I need to improve.
>
> This patch adds the support for native DSD for Topping DX7s DAC. The
> product description is on
> http://en.tpdz.net/products_detail/productId=32.html and it's
> available on https://www.amazon.com/Balanced-Headphone-Amplifier-Topping-2ES9038Q2M/dp/B07B4VFS21
>
> The DAC uses XMOS chip but uses a special vendor id and product id.
> The patch will enable the SNDRV_PCM_FMTBIT_DSD_U32_BE bit for the DAC
> hence enable native DSD playback up to DSD512 format.
Thanks, it's a very good information. Could you resubmit the patch
with adding this nice text in the patch description?
Takashi
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-07-23 8:53 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-23 8:02 [PATCH] alsa/usb-audio: Topping DX7s quirk for DSD interface Yue Wang
2018-07-23 8:26 ` Jussi Laako
2018-07-23 8:26 ` Jussi Laako
2018-07-23 8:53 ` Yue Wang
-- strict thread matches above, loose matches on Subject: below --
2018-07-23 7:25 yuleopen
2018-07-23 7:30 ` Takashi Iwai
2018-07-23 7:30 ` Takashi Iwai
2018-07-23 7:41 ` Yue Wang
2018-07-23 7:53 ` Takashi Iwai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.