All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Lorenzo Bianconi
	<lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
	Jakub Kicinski <kubakici-5tc4TXWwyLM@public.gmane.org>,
	Hans Ulli Kroll
	<ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>,
	Michal Schmidt <mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Subject: Re: [PATCH v2 00/12] Add mt76x0 driver
Date: Mon, 23 Jul 2018 11:44:05 +0200	[thread overview]
Message-ID: <20180723094404.GC26486@redhat.com> (raw)
In-Reply-To: <CAJ0CqmXmQMBfz7GUe31LYrqD=ZF1bWGSdvD0DMgA7cTC=eyQpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Hi

On Mon, Jul 23, 2018 at 11:16:25AM +0200, Lorenzo Bianconi wrote:
> > I'm not sure if it can be got from the market easily.
> >
> > I would like to say, mt7668 is based on new MTK wifi architecture. as
> > for mt7662/mt7612/mt7610, they all belong to legacy Ralink based design.
> > of course, we will never see any new chip based on Ralink based design
> > wifi in the future.
> >
> > There must be really lots of differences exist between two types of
> > devices, such as MCU firmware download, MCU control interface, tx/rx
> > path, even hardware register layout all changed and so on.
> >
> > I guess the hardware abstraction layer needs to be largely adjusted to
> > add the new device mt7668u into mt76 driver. And even I think it would
> > be easier for development and maintenance if we make a separate driver
> > and then pick up some pure software components from mt76 to reuse.
> >
> 
> the mt76 driver has a hw independent layer (mt76/mt76-usb modules) that
> implements data path (tx/rx side), mac80211 integration and calls hw dependent
> code for hw initialization (that approach allows to support mt76x2 and mt7603
> chipsets in the same driver).
> I guess it will be feasible (at least in theory) to integrate mt7668
> support in the
> mt76 driver (but I can't be more precise since I have no any reference code or
> hw to test)
> 
> > Maybe it's the time I want to test your tree first with 7612u (?) or
> > mt7610u (?) , what is suggested? and see how big the gap between this
> > two type of devices and last write some code based on your tree to test
> > mt7668u
> 
> mt76x2u and mt76x0 are not merged yet, but I would suggest to start looking
> at mt76x2u since it is already integrated in the mt76 driver while
> mt76x0 is a standalone
> driver for the moment.
> 
> @Stanislaw what do you think?

I think checking common mt76-usb layer for possibility to add
support for new MT7688U chip on top of it is reasonable :-)

Thanks
Stanislaw

WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Sean Wang <sean.wang@mediatek.com>,
	Jakub Kicinski <kubakici@wp.pl>,
	Hans Ulli Kroll <ulli.kroll@googlemail.com>,
	Michal Schmidt <mschmidt@redhat.com>,
	linux-wireless <linux-wireless@vger.kernel.org>,
	linux-mediatek@lists.infradead.org, Felix Fietkau <nbd@nbd.name>
Subject: Re: [PATCH v2 00/12] Add mt76x0 driver
Date: Mon, 23 Jul 2018 11:44:05 +0200	[thread overview]
Message-ID: <20180723094404.GC26486@redhat.com> (raw)
In-Reply-To: <CAJ0CqmXmQMBfz7GUe31LYrqD=ZF1bWGSdvD0DMgA7cTC=eyQpQ@mail.gmail.com>

Hi

On Mon, Jul 23, 2018 at 11:16:25AM +0200, Lorenzo Bianconi wrote:
> > I'm not sure if it can be got from the market easily.
> >
> > I would like to say, mt7668 is based on new MTK wifi architecture. as
> > for mt7662/mt7612/mt7610, they all belong to legacy Ralink based design.
> > of course, we will never see any new chip based on Ralink based design
> > wifi in the future.
> >
> > There must be really lots of differences exist between two types of
> > devices, such as MCU firmware download, MCU control interface, tx/rx
> > path, even hardware register layout all changed and so on.
> >
> > I guess the hardware abstraction layer needs to be largely adjusted to
> > add the new device mt7668u into mt76 driver. And even I think it would
> > be easier for development and maintenance if we make a separate driver
> > and then pick up some pure software components from mt76 to reuse.
> >
> 
> the mt76 driver has a hw independent layer (mt76/mt76-usb modules) that
> implements data path (tx/rx side), mac80211 integration and calls hw dependent
> code for hw initialization (that approach allows to support mt76x2 and mt7603
> chipsets in the same driver).
> I guess it will be feasible (at least in theory) to integrate mt7668
> support in the
> mt76 driver (but I can't be more precise since I have no any reference code or
> hw to test)
> 
> > Maybe it's the time I want to test your tree first with 7612u (?) or
> > mt7610u (?) , what is suggested? and see how big the gap between this
> > two type of devices and last write some code based on your tree to test
> > mt7668u
> 
> mt76x2u and mt76x0 are not merged yet, but I would suggest to start looking
> at mt76x2u since it is already integrated in the mt76 driver while
> mt76x0 is a standalone
> driver for the moment.
> 
> @Stanislaw what do you think?

I think checking common mt76-usb layer for possibility to add
support for new MT7688U chip on top of it is reasonable :-)

Thanks
Stanislaw

  parent reply	other threads:[~2018-07-23  9:44 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-06 11:03 [PATCH v2 00/12] Add mt76x0 driver Stanislaw Gruszka
2018-07-06 11:03 ` Stanislaw Gruszka
     [not found] ` <1530875029-26274-1-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-06 11:03   ` [PATCH v2 01/12] mt76: add more states Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 02/12] mt76x0: core files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 03/12] mt76x0: mac files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 04/12] mt76x0: usb files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 05/12] mt76x0: mcu files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 06/12] mt76x0: phy files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 07/12] mt76x0: init files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 08/12] mt76x0: eeprom files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 09/12] mt76x0: trace and debugfs files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 10/12] mt76x0: dma and tx files Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 11/12] mt76x0: main file Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
2018-07-06 11:03   ` [PATCH v2 12/12] mt76: Kconfig and Makefile for mt76x0 driver Stanislaw Gruszka
2018-07-06 11:03     ` Stanislaw Gruszka
     [not found]     ` <1530875029-26274-13-git-send-email-sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-06 14:48       ` kbuild test robot
2018-07-06 14:48         ` kbuild test robot
2018-07-06 14:48       ` [RFC PATCH] mt76: mt76x0_burst_read_regs() can be static kbuild test robot
2018-07-06 14:48         ` kbuild test robot
2018-07-10  6:50   ` [SPAM][PATCH v2 00/12] Add mt76x0 driver Sean Wang
2018-07-10  9:52     ` Stanislaw Gruszka
     [not found]       ` <20180710095222.GA18926-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-07-10 13:54         ` Sean Wang
2018-07-10 20:41           ` Lorenzo Bianconi
2018-07-11  8:07           ` [PATCH " Lorenzo Bianconi
2018-07-11  8:07             ` Lorenzo Bianconi
     [not found]             ` <20180711080721.GA3871-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-07-12 11:41               ` Stanislaw Gruszka
2018-07-12 11:41                 ` Stanislaw Gruszka
2018-07-20 15:36               ` Sean Wang
2018-07-20 15:36                 ` Sean Wang
2018-07-23  9:16                 ` Lorenzo Bianconi
2018-07-23  9:16                   ` Lorenzo Bianconi
     [not found]                   ` <CAJ0CqmXmQMBfz7GUe31LYrqD=ZF1bWGSdvD0DMgA7cTC=eyQpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-07-23  9:44                     ` Stanislaw Gruszka [this message]
2018-07-23  9:44                       ` Stanislaw Gruszka
2018-07-23  9:35                 ` Stanislaw Gruszka
2018-07-23  9:35                   ` Stanislaw Gruszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180723094404.GC26486@redhat.com \
    --to=sgruszka-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=kubakici-5tc4TXWwyLM@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=mschmidt-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=nbd-Vt+b4OUoWG0@public.gmane.org \
    --cc=sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
    --cc=ulli.kroll-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.