From: Keith Busch <keith.busch@linux.intel.com>
To: "hch@lst.de" <hch@lst.de>
Cc: Bart Van Assche <Bart.VanAssche@wdc.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"jianchao.w.wang@oracle.com" <jianchao.w.wang@oracle.com>
Subject: Re: [PATCH 2/2] scsi: set timed out out mq requests to complete
Date: Mon, 23 Jul 2018 08:04:06 -0600 [thread overview]
Message-ID: <20180723140406.GB10750@localhost.localdomain> (raw)
In-Reply-To: <20180723081231.GB19247@lst.de>
On Mon, Jul 23, 2018 at 10:12:31AM +0200, hch@lst.de wrote:
> > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > index 8932ae81a15a..902c30d3c0ed 100644
> > --- a/drivers/scsi/scsi_error.c
> > +++ b/drivers/scsi/scsi_error.c
> > @@ -296,6 +296,8 @@ enum blk_eh_timer_return scsi_times_out(struct request *req)
> > rtn = host->hostt->eh_timed_out(scmd);
> >
> > if (rtn == BLK_EH_DONE) {
> > + if (req->q->mq_ops && blk_mq_mark_complete(req))
> > + return rtn;
>
> This looks pretty sensible to me as a band-aid. It just needs a very
> detailed comment explaining what is going on here.
Sounds good, v2 will be sent shortly.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCH 2/2] scsi: set timed out out mq requests to complete
Date: Mon, 23 Jul 2018 08:04:06 -0600 [thread overview]
Message-ID: <20180723140406.GB10750@localhost.localdomain> (raw)
In-Reply-To: <20180723081231.GB19247@lst.de>
On Mon, Jul 23, 2018@10:12:31AM +0200, hch@lst.de wrote:
> > diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> > index 8932ae81a15a..902c30d3c0ed 100644
> > --- a/drivers/scsi/scsi_error.c
> > +++ b/drivers/scsi/scsi_error.c
> > @@ -296,6 +296,8 @@ enum blk_eh_timer_return scsi_times_out(struct request *req)
> > rtn = host->hostt->eh_timed_out(scmd);
> >
> > if (rtn == BLK_EH_DONE) {
> > + if (req->q->mq_ops && blk_mq_mark_complete(req))
> > + return rtn;
>
> This looks pretty sensible to me as a band-aid. It just needs a very
> detailed comment explaining what is going on here.
Sounds good, v2 will be sent shortly.
next prev parent reply other threads:[~2018-07-23 14:04 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 21:26 [PATCH 1/2] blk-mq: export setting request completion state Keith Busch
2018-07-19 21:26 ` Keith Busch
2018-07-19 21:26 ` [PATCH 2/2] scsi: set timed out out mq requests to complete Keith Busch
2018-07-19 21:26 ` Keith Busch
2018-07-20 6:52 ` Johannes Thumshirn
2018-07-20 6:52 ` Johannes Thumshirn
2018-07-20 14:05 ` Keith Busch
2018-07-20 14:05 ` Keith Busch
2018-07-20 14:41 ` Christoph Hellwig
2018-07-20 14:41 ` Christoph Hellwig
2018-07-20 14:50 ` Keith Busch
2018-07-20 14:50 ` Keith Busch
2018-07-20 15:12 ` Bart Van Assche
2018-07-20 15:12 ` Bart Van Assche
2018-07-20 15:56 ` Keith Busch
2018-07-20 15:56 ` Keith Busch
2018-07-20 16:03 ` Bart Van Assche
2018-07-20 16:03 ` Bart Van Assche
2018-07-20 16:12 ` Keith Busch
2018-07-20 16:12 ` Keith Busch
2018-07-20 16:20 ` Bart Van Assche
2018-07-20 16:20 ` Bart Van Assche
2018-07-20 16:23 ` Keith Busch
2018-07-20 16:23 ` Keith Busch
2018-07-20 16:45 ` Bart Van Assche
2018-07-20 16:45 ` Bart Van Assche
2018-07-20 17:24 ` Keith Busch
2018-07-20 17:24 ` Keith Busch
2018-07-23 8:12 ` hch
2018-07-23 8:12 ` hch
2018-07-23 13:59 ` Bart Van Assche
2018-07-23 13:59 ` Bart Van Assche
2018-07-23 14:04 ` Keith Busch [this message]
2018-07-23 14:04 ` Keith Busch
2018-07-23 8:09 ` [PATCH 1/2] blk-mq: export setting request completion state Christoph Hellwig
2018-07-23 8:09 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180723140406.GB10750@localhost.localdomain \
--to=keith.busch@linux.intel.com \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=jianchao.w.wang@oracle.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.