[Intel-wired-lan] [jkirsher-next-queue:XDP-hints-EXPERIMENTAL 1/1] drivers/net/ethernet/intel/i40e/i40e_txrx.c:2299:14: sparse: symbol 'len_ethhdr' was not declared. Should it be static?

[Intel-wired-lan] [jkirsher-next-queue:XDP-hints-EXPERIMENTAL 1/1] drivers/net/ethernet/intel/i40e/i40e_txrx.c:2299:14: sparse: symbol 'len_ethhdr' was not declared. Should it be static?

[kbuild test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git XDP-hints-EXPERIMENTAL
head:   58e0270bb7ac94a31ff0fe372385cfce4198b56c
commit: 58e0270bb7ac94a31ff0fe372385cfce4198b56c [1/1] i40e: Initial support to add hw hints for xdp
reproduce:
        # apt-get install sparse
        git checkout 58e0270bb7ac94a31ff0fe372385cfce4198b56c
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

   drivers/net/ethernet/intel/i40e/i40e_txrx.c:1118:23: sparse: expression using sizeof(void)
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:1118:23: sparse: expression using sizeof(void)
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2299:14: sparse: symbol 'len_ethhdr' was not declared. Should it be static?
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2300:14: sparse: symbol 'len_ipv4hdr' was not declared. Should it be static?
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2301:14: sparse: symbol 'len_ipv6hdr' was not declared. Should it be static?
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2346:38: sparse: missing braces around initializer
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2350:47: sparse: incorrect type in initializer (different base types) @@    expected unsigned long long [unsigned] [usertype] stserr @@    got g long [unsigned] [usertype] stserr @@
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2350:47:    expected unsigned long long [unsigned] [usertype] stserr
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2350:47:    got restricted __le64 [usertype] status_error_len
>> drivers/net/ethernet/intel/i40e/i40e_txrx.c:2438:36: sparse: incorrect type in assignment (different base types) @@    expected unsigned int [unsigned] [assigned] [usertype] hash @@    got igned] [assigned] [usertype] hash @@
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2438:36:    expected unsigned int [unsigned] [assigned] [usertype] hash
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2438:36:    got restricted __le32 [usertype] rss
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2761:27: sparse: expression using sizeof(void)
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2809:16: sparse: expression using sizeof(void)
   drivers/net/ethernet/intel/i40e/i40e_txrx.c:2809:16: sparse: expression using sizeof(void)

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[Intel-wired-lan] [RFC PATCH jkirsher-next-queue] i40e: len_ethhdr can be static

[kbuild test robot]

Fixes: 58e0270bb7ac ("i40e: Initial support to add hw hints for xdp")
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>
---
 i40e_txrx.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 09536d7e7..ab8b97f 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -2296,9 +2296,9 @@ static inline void i40e_xdp_ring_update_tail(struct i40e_ring *xdp_ring)
 	writel_relaxed(xdp_ring->next_to_use, xdp_ring->tail);
 };
 
-const size_t len_ethhdr = sizeof(struct ethhdr);
-const size_t len_ipv4hdr = sizeof(struct iphdr);
-const size_t len_ipv6hdr = sizeof(struct ipv6hdr);
+static const size_t len_ethhdr = sizeof(struct ethhdr);
+static const size_t len_ipv4hdr = sizeof(struct iphdr);
+static const size_t len_ipv6hdr = sizeof(struct ipv6hdr);
 
 enum XDP_META_PTYPE
 {