* [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
@ 2018-07-23 21:34 Mark Railton
2018-07-23 21:38 ` Randy Dunlap
2018-07-23 21:38 ` Randy Dunlap
0 siblings, 2 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:34 UTC (permalink / raw)
To: boris.ostrovsky, jgross; +Cc: xen-devel, linux-kernel, Mark Railton
Fixed issue with multi line comment
Signed-off-by: Mark Railton <mark@markrailton.com>
---
drivers/xen/xlate_mmu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
index 23f1387b3ef7..3b03bc1641ed 100644
--- a/drivers/xen/xlate_mmu.c
+++ b/drivers/xen/xlate_mmu.c
@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
struct remap_data data;
unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
- /* Kept here for the purpose of making sure code doesn't break
- x86 PVOPS */
+ /* Kept here for the purpose of making sure code doesn't
+ * break x86 PVOPS
+ */
BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
data.fgfn = gfn;
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:34 [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout Mark Railton
@ 2018-07-23 21:38 ` Randy Dunlap
2018-07-23 21:38 ` Randy Dunlap
1 sibling, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2018-07-23 21:38 UTC (permalink / raw)
To: Mark Railton, boris.ostrovsky, jgross; +Cc: xen-devel, linux-kernel
On 07/23/2018 02:34 PM, Mark Railton wrote:
> Fixed issue with multi line comment
Fix [not Fixed]
>
> Signed-off-by: Mark Railton <mark@markrailton.com>
> ---
> drivers/xen/xlate_mmu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> index 23f1387b3ef7..3b03bc1641ed 100644
> --- a/drivers/xen/xlate_mmu.c
> +++ b/drivers/xen/xlate_mmu.c
> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> struct remap_data data;
> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>
> - /* Kept here for the purpose of making sure code doesn't break
> - x86 PVOPS */
> + /* Kept here for the purpose of making sure code doesn't
> + * break x86 PVOPS
> + */
That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rst says:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
although Networking code has a slightly different preferred style (as in
your patch).
> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>
> data.fgfn = gfn;
>
--
~Randy
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:34 [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout Mark Railton
2018-07-23 21:38 ` Randy Dunlap
@ 2018-07-23 21:38 ` Randy Dunlap
2018-07-23 21:40 ` Mark Railton
2018-07-23 21:40 ` Mark Railton
1 sibling, 2 replies; 14+ messages in thread
From: Randy Dunlap @ 2018-07-23 21:38 UTC (permalink / raw)
To: Mark Railton, boris.ostrovsky, jgross; +Cc: xen-devel, linux-kernel
On 07/23/2018 02:34 PM, Mark Railton wrote:
> Fixed issue with multi line comment
Fix [not Fixed]
>
> Signed-off-by: Mark Railton <mark@markrailton.com>
> ---
> drivers/xen/xlate_mmu.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> index 23f1387b3ef7..3b03bc1641ed 100644
> --- a/drivers/xen/xlate_mmu.c
> +++ b/drivers/xen/xlate_mmu.c
> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> struct remap_data data;
> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>
> - /* Kept here for the purpose of making sure code doesn't break
> - x86 PVOPS */
> + /* Kept here for the purpose of making sure code doesn't
> + * break x86 PVOPS
> + */
That is still not the preferred kernel multi-line comment style.
Documentation/process/coding-style.rst says:
/*
* This is the preferred style for multi-line
* comments in the Linux kernel source code.
* Please use it consistently.
*
* Description: A column of asterisks on the left side,
* with beginning and ending almost-blank lines.
*/
although Networking code has a slightly different preferred style (as in
your patch).
> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>
> data.fgfn = gfn;
>
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:38 ` Randy Dunlap
@ 2018-07-23 21:40 ` Mark Railton
2018-07-23 21:44 ` Randy Dunlap
2018-07-23 21:44 ` Randy Dunlap
2018-07-23 21:40 ` Mark Railton
1 sibling, 2 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:40 UTC (permalink / raw)
To: Randy Dunlap; +Cc: boris.ostrovsky, jgross, xen-devel, linux-kernel
On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
> On 07/23/2018 02:34 PM, Mark Railton wrote:
> > Fixed issue with multi line comment
>
> Fix [not Fixed]
>
> >
> > Signed-off-by: Mark Railton <mark@markrailton.com>
> > ---
> > drivers/xen/xlate_mmu.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> > index 23f1387b3ef7..3b03bc1641ed 100644
> > --- a/drivers/xen/xlate_mmu.c
> > +++ b/drivers/xen/xlate_mmu.c
> > @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> > struct remap_data data;
> > unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >
> > - /* Kept here for the purpose of making sure code doesn't break
> > - x86 PVOPS */
> > + /* Kept here for the purpose of making sure code doesn't
> > + * break x86 PVOPS
> > + */
>
> That is still not the preferred kernel multi-line comment style.
> Documentation/process/coding-style.rst says:
>
> /*
> * This is the preferred style for multi-line
> * comments in the Linux kernel source code.
> * Please use it consistently.
> *
> * Description: A column of asterisks on the left side,
> * with beginning and ending almost-blank lines.
> */
>
> although Networking code has a slightly different preferred style (as in
> your patch).
>
> > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >
> > data.fgfn = gfn;
> >
>
>
> --
> ~Randy
Thank's for the feedback, I'll get that updated now.
I'm still kinda new to this, I assume I need to send the new patch via
git send-email?
Thanks,
Mark
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:40 ` Mark Railton
@ 2018-07-23 21:44 ` Randy Dunlap
2018-07-23 21:48 ` Mark Railton
2018-07-23 21:48 ` Mark Railton
2018-07-23 21:44 ` Randy Dunlap
1 sibling, 2 replies; 14+ messages in thread
From: Randy Dunlap @ 2018-07-23 21:44 UTC (permalink / raw)
To: Mark Railton; +Cc: boris.ostrovsky, jgross, xen-devel, linux-kernel
On 07/23/2018 02:40 PM, Mark Railton wrote:
> On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
>> On 07/23/2018 02:34 PM, Mark Railton wrote:
>>> Fixed issue with multi line comment
>>
>> Fix [not Fixed]
>>
>>>
>>> Signed-off-by: Mark Railton <mark@markrailton.com>
>>> ---
>>> drivers/xen/xlate_mmu.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
>>> index 23f1387b3ef7..3b03bc1641ed 100644
>>> --- a/drivers/xen/xlate_mmu.c
>>> +++ b/drivers/xen/xlate_mmu.c
>>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
>>> struct remap_data data;
>>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>>>
>>> - /* Kept here for the purpose of making sure code doesn't break
>>> - x86 PVOPS */
>>> + /* Kept here for the purpose of making sure code doesn't
>>> + * break x86 PVOPS
>>> + */
>>
>> That is still not the preferred kernel multi-line comment style.
>> Documentation/process/coding-style.rst says:
>>
>> /*
>> * This is the preferred style for multi-line
>> * comments in the Linux kernel source code.
>> * Please use it consistently.
>> *
>> * Description: A column of asterisks on the left side,
>> * with beginning and ending almost-blank lines.
>> */
>>
>> although Networking code has a slightly different preferred style (as in
>> your patch).
>>
>>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>>>
>>> data.fgfn = gfn;
>>>
>>
>>
>> --
>> ~Randy
>
> Thank's for the feedback, I'll get that updated now.
>
> I'm still kinda new to this, I assume I need to send the new patch via
> git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well.
See Documentation/process/email-clients.rst.
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:44 ` Randy Dunlap
@ 2018-07-23 21:48 ` Mark Railton
2018-07-23 21:48 ` Mark Railton
1 sibling, 0 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:48 UTC (permalink / raw)
To: Randy Dunlap; +Cc: jgross, xen-devel, boris.ostrovsky, linux-kernel
On Mon, Jul 23, 2018 at 02:44:28PM -0700, Randy Dunlap wrote:
> On 07/23/2018 02:40 PM, Mark Railton wrote:
> > On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
> >> On 07/23/2018 02:34 PM, Mark Railton wrote:
> >>> Fixed issue with multi line comment
> >>
> >> Fix [not Fixed]
> >>
> >>>
> >>> Signed-off-by: Mark Railton <mark@markrailton.com>
> >>> ---
> >>> drivers/xen/xlate_mmu.c | 5 +++--
> >>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> >>> index 23f1387b3ef7..3b03bc1641ed 100644
> >>> --- a/drivers/xen/xlate_mmu.c
> >>> +++ b/drivers/xen/xlate_mmu.c
> >>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> >>> struct remap_data data;
> >>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >>>
> >>> - /* Kept here for the purpose of making sure code doesn't break
> >>> - x86 PVOPS */
> >>> + /* Kept here for the purpose of making sure code doesn't
> >>> + * break x86 PVOPS
> >>> + */
> >>
> >> That is still not the preferred kernel multi-line comment style.
> >> Documentation/process/coding-style.rst says:
> >>
> >> /*
> >> * This is the preferred style for multi-line
> >> * comments in the Linux kernel source code.
> >> * Please use it consistently.
> >> *
> >> * Description: A column of asterisks on the left side,
> >> * with beginning and ending almost-blank lines.
> >> */
> >>
> >> although Networking code has a slightly different preferred style (as in
> >> your patch).
> >>
> >>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >>>
> >>> data.fgfn = gfn;
> >>>
> >>
> >>
> >> --
> >> ~Randy
> >
> > Thank's for the feedback, I'll get that updated now.
> >
> > I'm still kinda new to this, I assume I need to send the new patch via
> > git send-email?
>
> That is one option. Use whatever works for you.
>
> There are several email clients that also work well.
> See Documentation/process/email-clients.rst.
>
>
> --
> ~Randy
From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
From: Mark Railton <mark@markrailton.com>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
Fixed issue with multi line comment
Signed-off-by: Mark Railton <mark@markrailton.com>
---
drivers/xen/xlate_mmu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
index 23f1387b3ef7..2b77c79f8ce7 100644
--- a/drivers/xen/xlate_mmu.c
+++ b/drivers/xen/xlate_mmu.c
@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
struct remap_data data;
unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
- /* Kept here for the purpose of making sure code doesn't break
- x86 PVOPS */
+ /*
+ * Kept here for the purpose of making sure code doesn't
+ * break x86 PVOPS
+ */
BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
data.fgfn = gfn;
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:44 ` Randy Dunlap
2018-07-23 21:48 ` Mark Railton
@ 2018-07-23 21:48 ` Mark Railton
2018-07-23 21:55 ` Randy Dunlap
2018-07-23 21:55 ` Randy Dunlap
1 sibling, 2 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:48 UTC (permalink / raw)
To: Randy Dunlap; +Cc: boris.ostrovsky, jgross, xen-devel, linux-kernel
On Mon, Jul 23, 2018 at 02:44:28PM -0700, Randy Dunlap wrote:
> On 07/23/2018 02:40 PM, Mark Railton wrote:
> > On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
> >> On 07/23/2018 02:34 PM, Mark Railton wrote:
> >>> Fixed issue with multi line comment
> >>
> >> Fix [not Fixed]
> >>
> >>>
> >>> Signed-off-by: Mark Railton <mark@markrailton.com>
> >>> ---
> >>> drivers/xen/xlate_mmu.c | 5 +++--
> >>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>
> >>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> >>> index 23f1387b3ef7..3b03bc1641ed 100644
> >>> --- a/drivers/xen/xlate_mmu.c
> >>> +++ b/drivers/xen/xlate_mmu.c
> >>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> >>> struct remap_data data;
> >>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >>>
> >>> - /* Kept here for the purpose of making sure code doesn't break
> >>> - x86 PVOPS */
> >>> + /* Kept here for the purpose of making sure code doesn't
> >>> + * break x86 PVOPS
> >>> + */
> >>
> >> That is still not the preferred kernel multi-line comment style.
> >> Documentation/process/coding-style.rst says:
> >>
> >> /*
> >> * This is the preferred style for multi-line
> >> * comments in the Linux kernel source code.
> >> * Please use it consistently.
> >> *
> >> * Description: A column of asterisks on the left side,
> >> * with beginning and ending almost-blank lines.
> >> */
> >>
> >> although Networking code has a slightly different preferred style (as in
> >> your patch).
> >>
> >>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >>>
> >>> data.fgfn = gfn;
> >>>
> >>
> >>
> >> --
> >> ~Randy
> >
> > Thank's for the feedback, I'll get that updated now.
> >
> > I'm still kinda new to this, I assume I need to send the new patch via
> > git send-email?
>
> That is one option. Use whatever works for you.
>
> There are several email clients that also work well.
> See Documentation/process/email-clients.rst.
>
>
> --
> ~Randy
From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
From: Mark Railton <mark@markrailton.com>
Date: Mon, 23 Jul 2018 22:28:53 +0100
Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
Fixed issue with multi line comment
Signed-off-by: Mark Railton <mark@markrailton.com>
---
drivers/xen/xlate_mmu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
index 23f1387b3ef7..2b77c79f8ce7 100644
--- a/drivers/xen/xlate_mmu.c
+++ b/drivers/xen/xlate_mmu.c
@@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
struct remap_data data;
unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
- /* Kept here for the purpose of making sure code doesn't break
- x86 PVOPS */
+ /*
+ * Kept here for the purpose of making sure code doesn't
+ * break x86 PVOPS
+ */
BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
data.fgfn = gfn;
--
2.17.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:48 ` Mark Railton
@ 2018-07-23 21:55 ` Randy Dunlap
2018-07-23 21:58 ` Mark Railton
2018-07-23 21:58 ` Mark Railton
2018-07-23 21:55 ` Randy Dunlap
1 sibling, 2 replies; 14+ messages in thread
From: Randy Dunlap @ 2018-07-23 21:55 UTC (permalink / raw)
To: Mark Railton; +Cc: boris.ostrovsky, jgross, xen-devel, linux-kernel
On 07/23/2018 02:48 PM, Mark Railton wrote:
> On Mon, Jul 23, 2018 at 02:44:28PM -0700, Randy Dunlap wrote:
>> On 07/23/2018 02:40 PM, Mark Railton wrote:
>>> On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
>>>> On 07/23/2018 02:34 PM, Mark Railton wrote:
>>>>> Fixed issue with multi line comment
>>>>
>>>> Fix [not Fixed]
>>>>
>>>>>
>>>>> Signed-off-by: Mark Railton <mark@markrailton.com>
>>>>> ---
>>>>> drivers/xen/xlate_mmu.c | 5 +++--
>>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
>>>>> index 23f1387b3ef7..3b03bc1641ed 100644
>>>>> --- a/drivers/xen/xlate_mmu.c
>>>>> +++ b/drivers/xen/xlate_mmu.c
>>>>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
>>>>> struct remap_data data;
>>>>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>>>>>
>>>>> - /* Kept here for the purpose of making sure code doesn't break
>>>>> - x86 PVOPS */
>>>>> + /* Kept here for the purpose of making sure code doesn't
>>>>> + * break x86 PVOPS
>>>>> + */
>>>>
>>>> That is still not the preferred kernel multi-line comment style.
>>>> Documentation/process/coding-style.rst says:
>>>>
>>>> /*
>>>> * This is the preferred style for multi-line
>>>> * comments in the Linux kernel source code.
>>>> * Please use it consistently.
>>>> *
>>>> * Description: A column of asterisks on the left side,
>>>> * with beginning and ending almost-blank lines.
>>>> */
>>>>
>>>> although Networking code has a slightly different preferred style (as in
>>>> your patch).
>>>>
>>>>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>>>>>
>>>>> data.fgfn = gfn;
>>>>>
>>>>
>>>>
>>>> --
>>>> ~Randy
>>>
>>> Thank's for the feedback, I'll get that updated now.
>>>
>>> I'm still kinda new to this, I assume I need to send the new patch via
>>> git send-email?
>>
>> That is one option. Use whatever works for you.
>>
>> There are several email clients that also work well.
>> See Documentation/process/email-clients.rst.
>>
>>
>> --
>> ~Randy
>
> From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
> From: Mark Railton <mark@markrailton.com>
> Date: Mon, 23 Jul 2018 22:28:53 +0100
> Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
>
> Fixed issue with multi line comment
>
> Signed-off-by: Mark Railton <mark@markrailton.com>
> ---
> drivers/xen/xlate_mmu.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> index 23f1387b3ef7..2b77c79f8ce7 100644
> --- a/drivers/xen/xlate_mmu.c
> +++ b/drivers/xen/xlate_mmu.c
> @@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> struct remap_data data;
> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>
> - /* Kept here for the purpose of making sure code doesn't break
> - x86 PVOPS */
> + /*
> + * Kept here for the purpose of making sure code doesn't
> + * break x86 PVOPS
> + */
> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>
> data.fgfn = gfn;
> --
> 2.17.1
Hi,
a. The subject and the patch description should be in present tense, i.e.,
Fix instead of Fixed.
b. Ideally you start a new email thread for new versions of a patch (but Cc:
the interested parties).
For the patch itself:
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:55 ` Randy Dunlap
@ 2018-07-23 21:58 ` Mark Railton
2018-07-23 21:58 ` Mark Railton
1 sibling, 0 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:58 UTC (permalink / raw)
To: Randy Dunlap; +Cc: jgross, xen-devel, boris.ostrovsky, linux-kernel
On Mon, Jul 23, 2018 at 02:55:12PM -0700, Randy Dunlap wrote:
> On 07/23/2018 02:48 PM, Mark Railton wrote:
> > On Mon, Jul 23, 2018 at 02:44:28PM -0700, Randy Dunlap wrote:
> >> On 07/23/2018 02:40 PM, Mark Railton wrote:
> >>> On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
> >>>> On 07/23/2018 02:34 PM, Mark Railton wrote:
> >>>>> Fixed issue with multi line comment
> >>>>
> >>>> Fix [not Fixed]
> >>>>
> >>>>>
> >>>>> Signed-off-by: Mark Railton <mark@markrailton.com>
> >>>>> ---
> >>>>> drivers/xen/xlate_mmu.c | 5 +++--
> >>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> >>>>> index 23f1387b3ef7..3b03bc1641ed 100644
> >>>>> --- a/drivers/xen/xlate_mmu.c
> >>>>> +++ b/drivers/xen/xlate_mmu.c
> >>>>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> >>>>> struct remap_data data;
> >>>>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >>>>>
> >>>>> - /* Kept here for the purpose of making sure code doesn't break
> >>>>> - x86 PVOPS */
> >>>>> + /* Kept here for the purpose of making sure code doesn't
> >>>>> + * break x86 PVOPS
> >>>>> + */
> >>>>
> >>>> That is still not the preferred kernel multi-line comment style.
> >>>> Documentation/process/coding-style.rst says:
> >>>>
> >>>> /*
> >>>> * This is the preferred style for multi-line
> >>>> * comments in the Linux kernel source code.
> >>>> * Please use it consistently.
> >>>> *
> >>>> * Description: A column of asterisks on the left side,
> >>>> * with beginning and ending almost-blank lines.
> >>>> */
> >>>>
> >>>> although Networking code has a slightly different preferred style (as in
> >>>> your patch).
> >>>>
> >>>>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >>>>>
> >>>>> data.fgfn = gfn;
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> ~Randy
> >>>
> >>> Thank's for the feedback, I'll get that updated now.
> >>>
> >>> I'm still kinda new to this, I assume I need to send the new patch via
> >>> git send-email?
> >>
> >> That is one option. Use whatever works for you.
> >>
> >> There are several email clients that also work well.
> >> See Documentation/process/email-clients.rst.
> >>
> >>
> >> --
> >> ~Randy
> >
> > From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
> > From: Mark Railton <mark@markrailton.com>
> > Date: Mon, 23 Jul 2018 22:28:53 +0100
> > Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
> >
> > Fixed issue with multi line comment
> >
> > Signed-off-by: Mark Railton <mark@markrailton.com>
> > ---
> > drivers/xen/xlate_mmu.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> > index 23f1387b3ef7..2b77c79f8ce7 100644
> > --- a/drivers/xen/xlate_mmu.c
> > +++ b/drivers/xen/xlate_mmu.c
> > @@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> > struct remap_data data;
> > unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >
> > - /* Kept here for the purpose of making sure code doesn't break
> > - x86 PVOPS */
> > + /*
> > + * Kept here for the purpose of making sure code doesn't
> > + * break x86 PVOPS
> > + */
> > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >
> > data.fgfn = gfn;
> > --
> > 2.17.1
>
>
> Hi,
>
> a. The subject and the patch description should be in present tense, i.e.,
> Fix instead of Fixed.
>
> b. Ideally you start a new email thread for new versions of a patch (but Cc:
> the interested parties).
>
> For the patch itself:
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
> --
> ~Randy
Thank you for the feedback, I will make sure to take that on board.
Mark
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:55 ` Randy Dunlap
2018-07-23 21:58 ` Mark Railton
@ 2018-07-23 21:58 ` Mark Railton
1 sibling, 0 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:58 UTC (permalink / raw)
To: Randy Dunlap; +Cc: boris.ostrovsky, jgross, xen-devel, linux-kernel
On Mon, Jul 23, 2018 at 02:55:12PM -0700, Randy Dunlap wrote:
> On 07/23/2018 02:48 PM, Mark Railton wrote:
> > On Mon, Jul 23, 2018 at 02:44:28PM -0700, Randy Dunlap wrote:
> >> On 07/23/2018 02:40 PM, Mark Railton wrote:
> >>> On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
> >>>> On 07/23/2018 02:34 PM, Mark Railton wrote:
> >>>>> Fixed issue with multi line comment
> >>>>
> >>>> Fix [not Fixed]
> >>>>
> >>>>>
> >>>>> Signed-off-by: Mark Railton <mark@markrailton.com>
> >>>>> ---
> >>>>> drivers/xen/xlate_mmu.c | 5 +++--
> >>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
> >>>>>
> >>>>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> >>>>> index 23f1387b3ef7..3b03bc1641ed 100644
> >>>>> --- a/drivers/xen/xlate_mmu.c
> >>>>> +++ b/drivers/xen/xlate_mmu.c
> >>>>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> >>>>> struct remap_data data;
> >>>>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >>>>>
> >>>>> - /* Kept here for the purpose of making sure code doesn't break
> >>>>> - x86 PVOPS */
> >>>>> + /* Kept here for the purpose of making sure code doesn't
> >>>>> + * break x86 PVOPS
> >>>>> + */
> >>>>
> >>>> That is still not the preferred kernel multi-line comment style.
> >>>> Documentation/process/coding-style.rst says:
> >>>>
> >>>> /*
> >>>> * This is the preferred style for multi-line
> >>>> * comments in the Linux kernel source code.
> >>>> * Please use it consistently.
> >>>> *
> >>>> * Description: A column of asterisks on the left side,
> >>>> * with beginning and ending almost-blank lines.
> >>>> */
> >>>>
> >>>> although Networking code has a slightly different preferred style (as in
> >>>> your patch).
> >>>>
> >>>>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >>>>>
> >>>>> data.fgfn = gfn;
> >>>>>
> >>>>
> >>>>
> >>>> --
> >>>> ~Randy
> >>>
> >>> Thank's for the feedback, I'll get that updated now.
> >>>
> >>> I'm still kinda new to this, I assume I need to send the new patch via
> >>> git send-email?
> >>
> >> That is one option. Use whatever works for you.
> >>
> >> There are several email clients that also work well.
> >> See Documentation/process/email-clients.rst.
> >>
> >>
> >> --
> >> ~Randy
> >
> > From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
> > From: Mark Railton <mark@markrailton.com>
> > Date: Mon, 23 Jul 2018 22:28:53 +0100
> > Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
> >
> > Fixed issue with multi line comment
> >
> > Signed-off-by: Mark Railton <mark@markrailton.com>
> > ---
> > drivers/xen/xlate_mmu.c | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> > index 23f1387b3ef7..2b77c79f8ce7 100644
> > --- a/drivers/xen/xlate_mmu.c
> > +++ b/drivers/xen/xlate_mmu.c
> > @@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> > struct remap_data data;
> > unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >
> > - /* Kept here for the purpose of making sure code doesn't break
> > - x86 PVOPS */
> > + /*
> > + * Kept here for the purpose of making sure code doesn't
> > + * break x86 PVOPS
> > + */
> > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >
> > data.fgfn = gfn;
> > --
> > 2.17.1
>
>
> Hi,
>
> a. The subject and the patch description should be in present tense, i.e.,
> Fix instead of Fixed.
>
> b. Ideally you start a new email thread for new versions of a patch (but Cc:
> the interested parties).
>
> For the patch itself:
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
> Thanks.
>
> --
> ~Randy
Thank you for the feedback, I will make sure to take that on board.
Mark
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:48 ` Mark Railton
2018-07-23 21:55 ` Randy Dunlap
@ 2018-07-23 21:55 ` Randy Dunlap
1 sibling, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2018-07-23 21:55 UTC (permalink / raw)
To: Mark Railton; +Cc: jgross, xen-devel, boris.ostrovsky, linux-kernel
On 07/23/2018 02:48 PM, Mark Railton wrote:
> On Mon, Jul 23, 2018 at 02:44:28PM -0700, Randy Dunlap wrote:
>> On 07/23/2018 02:40 PM, Mark Railton wrote:
>>> On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
>>>> On 07/23/2018 02:34 PM, Mark Railton wrote:
>>>>> Fixed issue with multi line comment
>>>>
>>>> Fix [not Fixed]
>>>>
>>>>>
>>>>> Signed-off-by: Mark Railton <mark@markrailton.com>
>>>>> ---
>>>>> drivers/xen/xlate_mmu.c | 5 +++--
>>>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
>>>>> index 23f1387b3ef7..3b03bc1641ed 100644
>>>>> --- a/drivers/xen/xlate_mmu.c
>>>>> +++ b/drivers/xen/xlate_mmu.c
>>>>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
>>>>> struct remap_data data;
>>>>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>>>>>
>>>>> - /* Kept here for the purpose of making sure code doesn't break
>>>>> - x86 PVOPS */
>>>>> + /* Kept here for the purpose of making sure code doesn't
>>>>> + * break x86 PVOPS
>>>>> + */
>>>>
>>>> That is still not the preferred kernel multi-line comment style.
>>>> Documentation/process/coding-style.rst says:
>>>>
>>>> /*
>>>> * This is the preferred style for multi-line
>>>> * comments in the Linux kernel source code.
>>>> * Please use it consistently.
>>>> *
>>>> * Description: A column of asterisks on the left side,
>>>> * with beginning and ending almost-blank lines.
>>>> */
>>>>
>>>> although Networking code has a slightly different preferred style (as in
>>>> your patch).
>>>>
>>>>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>>>>>
>>>>> data.fgfn = gfn;
>>>>>
>>>>
>>>>
>>>> --
>>>> ~Randy
>>>
>>> Thank's for the feedback, I'll get that updated now.
>>>
>>> I'm still kinda new to this, I assume I need to send the new patch via
>>> git send-email?
>>
>> That is one option. Use whatever works for you.
>>
>> There are several email clients that also work well.
>> See Documentation/process/email-clients.rst.
>>
>>
>> --
>> ~Randy
>
> From 57c8104d2a30020005be16df2ca69ed66f6c4ae9 Mon Sep 17 00:00:00 2001
> From: Mark Railton <mark@markrailton.com>
> Date: Mon, 23 Jul 2018 22:28:53 +0100
> Subject: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
>
> Fixed issue with multi line comment
>
> Signed-off-by: Mark Railton <mark@markrailton.com>
> ---
> drivers/xen/xlate_mmu.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> index 23f1387b3ef7..2b77c79f8ce7 100644
> --- a/drivers/xen/xlate_mmu.c
> +++ b/drivers/xen/xlate_mmu.c
> @@ -151,8 +151,10 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> struct remap_data data;
> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>
> - /* Kept here for the purpose of making sure code doesn't break
> - x86 PVOPS */
> + /*
> + * Kept here for the purpose of making sure code doesn't
> + * break x86 PVOPS
> + */
> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>
> data.fgfn = gfn;
> --
> 2.17.1
Hi,
a. The subject and the patch description should be in present tense, i.e.,
Fix instead of Fixed.
b. Ideally you start a new email thread for new versions of a patch (but Cc:
the interested parties).
For the patch itself:
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Thanks.
--
~Randy
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:40 ` Mark Railton
2018-07-23 21:44 ` Randy Dunlap
@ 2018-07-23 21:44 ` Randy Dunlap
1 sibling, 0 replies; 14+ messages in thread
From: Randy Dunlap @ 2018-07-23 21:44 UTC (permalink / raw)
To: Mark Railton; +Cc: jgross, xen-devel, boris.ostrovsky, linux-kernel
On 07/23/2018 02:40 PM, Mark Railton wrote:
> On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
>> On 07/23/2018 02:34 PM, Mark Railton wrote:
>>> Fixed issue with multi line comment
>>
>> Fix [not Fixed]
>>
>>>
>>> Signed-off-by: Mark Railton <mark@markrailton.com>
>>> ---
>>> drivers/xen/xlate_mmu.c | 5 +++--
>>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
>>> index 23f1387b3ef7..3b03bc1641ed 100644
>>> --- a/drivers/xen/xlate_mmu.c
>>> +++ b/drivers/xen/xlate_mmu.c
>>> @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
>>> struct remap_data data;
>>> unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
>>>
>>> - /* Kept here for the purpose of making sure code doesn't break
>>> - x86 PVOPS */
>>> + /* Kept here for the purpose of making sure code doesn't
>>> + * break x86 PVOPS
>>> + */
>>
>> That is still not the preferred kernel multi-line comment style.
>> Documentation/process/coding-style.rst says:
>>
>> /*
>> * This is the preferred style for multi-line
>> * comments in the Linux kernel source code.
>> * Please use it consistently.
>> *
>> * Description: A column of asterisks on the left side,
>> * with beginning and ending almost-blank lines.
>> */
>>
>> although Networking code has a slightly different preferred style (as in
>> your patch).
>>
>>> BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
>>>
>>> data.fgfn = gfn;
>>>
>>
>>
>> --
>> ~Randy
>
> Thank's for the feedback, I'll get that updated now.
>
> I'm still kinda new to this, I assume I need to send the new patch via
> git send-email?
That is one option. Use whatever works for you.
There are several email clients that also work well.
See Documentation/process/email-clients.rst.
--
~Randy
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
2018-07-23 21:38 ` Randy Dunlap
2018-07-23 21:40 ` Mark Railton
@ 2018-07-23 21:40 ` Mark Railton
1 sibling, 0 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:40 UTC (permalink / raw)
To: Randy Dunlap; +Cc: jgross, xen-devel, boris.ostrovsky, linux-kernel
On Mon, Jul 23, 2018 at 02:38:20PM -0700, Randy Dunlap wrote:
> On 07/23/2018 02:34 PM, Mark Railton wrote:
> > Fixed issue with multi line comment
>
> Fix [not Fixed]
>
> >
> > Signed-off-by: Mark Railton <mark@markrailton.com>
> > ---
> > drivers/xen/xlate_mmu.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
> > index 23f1387b3ef7..3b03bc1641ed 100644
> > --- a/drivers/xen/xlate_mmu.c
> > +++ b/drivers/xen/xlate_mmu.c
> > @@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
> > struct remap_data data;
> > unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
> >
> > - /* Kept here for the purpose of making sure code doesn't break
> > - x86 PVOPS */
> > + /* Kept here for the purpose of making sure code doesn't
> > + * break x86 PVOPS
> > + */
>
> That is still not the preferred kernel multi-line comment style.
> Documentation/process/coding-style.rst says:
>
> /*
> * This is the preferred style for multi-line
> * comments in the Linux kernel source code.
> * Please use it consistently.
> *
> * Description: A column of asterisks on the left side,
> * with beginning and ending almost-blank lines.
> */
>
> although Networking code has a slightly different preferred style (as in
> your patch).
>
> > BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
> >
> > data.fgfn = gfn;
> >
>
>
> --
> ~Randy
Thank's for the feedback, I'll get that updated now.
I'm still kinda new to this, I assume I need to send the new patch via
git send-email?
Thanks,
Mark
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout
@ 2018-07-23 21:34 Mark Railton
0 siblings, 0 replies; 14+ messages in thread
From: Mark Railton @ 2018-07-23 21:34 UTC (permalink / raw)
To: boris.ostrovsky, jgross; +Cc: Mark Railton, xen-devel, linux-kernel
Fixed issue with multi line comment
Signed-off-by: Mark Railton <mark@markrailton.com>
---
drivers/xen/xlate_mmu.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/xen/xlate_mmu.c b/drivers/xen/xlate_mmu.c
index 23f1387b3ef7..3b03bc1641ed 100644
--- a/drivers/xen/xlate_mmu.c
+++ b/drivers/xen/xlate_mmu.c
@@ -151,8 +151,9 @@ int xen_xlate_remap_gfn_array(struct vm_area_struct *vma,
struct remap_data data;
unsigned long range = DIV_ROUND_UP(nr, XEN_PFN_PER_PAGE) << PAGE_SHIFT;
- /* Kept here for the purpose of making sure code doesn't break
- x86 PVOPS */
+ /* Kept here for the purpose of making sure code doesn't
+ * break x86 PVOPS
+ */
BUG_ON(!((vma->vm_flags & (VM_PFNMAP | VM_IO)) == (VM_PFNMAP | VM_IO)));
data.fgfn = gfn;
--
2.17.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-07-23 21:58 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-23 21:34 [PATCH] Drivers: Xen: xlate_mmu.c: Fixed comment layout Mark Railton
2018-07-23 21:38 ` Randy Dunlap
2018-07-23 21:38 ` Randy Dunlap
2018-07-23 21:40 ` Mark Railton
2018-07-23 21:44 ` Randy Dunlap
2018-07-23 21:48 ` Mark Railton
2018-07-23 21:48 ` Mark Railton
2018-07-23 21:55 ` Randy Dunlap
2018-07-23 21:58 ` Mark Railton
2018-07-23 21:58 ` Mark Railton
2018-07-23 21:55 ` Randy Dunlap
2018-07-23 21:44 ` Randy Dunlap
2018-07-23 21:40 ` Mark Railton
-- strict thread matches above, loose matches on Subject: below --
2018-07-23 21:34 Mark Railton
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.