All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Nadav Amit <namit@vmware.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Philippe Ombredanne <pombredanne@nexb.com>
Subject: Re: [PATCH v6 9/9] x86: jump-labels: use macros instead of inline assembly
Date: Tue, 24 Jul 2018 16:26:47 +0200	[thread overview]
Message-ID: <20180724142647.GA31700@gmail.com> (raw)
In-Reply-To: <20180622172212.199633-10-namit@vmware.com>


* Nadav Amit <namit@vmware.com> wrote:

> Use assembly macros for jump-labels and call them from inline assembly.
> This not only makes the code more readable, but also improves
> compilation decision, specifically inline decisions which GCC base on
> the number of new lines in inline assembly.
> 
> As a result the code size is slightly increased.
> 
>    text	   data	    bss	    dec	    hex	filename
> 18163528 10226300 2957312 31347140 1de51c4 ./vmlinux before
> 18163608 10227348 2957312 31348268 1de562c ./vmlinux after (+1128)
> 
> And functions such as intel_pstate_adjust_policy_max(),
> kvm_cpu_accept_dm_intr(), kvm_register_readl() are inlined.
> 
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Kate Stewart <kstewart@linuxfoundation.org>
> Cc: Philippe Ombredanne <pombredanne@nexb.com>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> Signed-off-by: Nadav Amit <namit@vmware.com>
> ---
>  arch/x86/entry/calling.h          |  2 +-
>  arch/x86/include/asm/jump_label.h | 77 +++++++++++--------------------
>  arch/x86/kernel/macros.S          |  1 +
>  3 files changed, 30 insertions(+), 50 deletions(-)

So I tried the series, and this patch causes a silent hard hang on bootup, with no 
(early-)console messages visible.

I've attached the config that triggers the problem, built with:

  gcc version 5.3.1 20160406 (Red Hat 5.3.1-6) (GCC) 

it's 100% reproducible on both Intel and AMD test systems.

I'll continue to test the series with this patch left out.

So both the xtensa build failure and this boot failure needs to be fixed before I 
can apply this series.

Thanks,

	Ingo

  reply	other threads:[~2018-07-24 14:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 17:22 [PATCH v6 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-06-22 17:22 ` Nadav Amit
2018-06-22 17:22 ` [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm Nadav Amit
2018-06-22 17:22   ` Nadav Amit
2018-07-18  1:46   ` Masahiro Yamada
2018-07-24 11:14     ` Ingo Molnar
2018-07-24 18:04       ` Nadav Amit
2018-06-22 17:22 ` [PATCH v6 2/9] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-06-22 17:22   ` Nadav Amit
2018-06-22 17:22 ` [PATCH v6 3/9] x86: refcount: prevent gcc distortions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 4/9] x86: alternatives: macrofy locks for better inlining Nadav Amit
2018-06-22 17:22 ` [PATCH v6 5/9] x86: bug: prevent gcc distortions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 6/9] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-06-22 17:22 ` [PATCH v6 7/9] x86: extable: use macros instead of inline assembly Nadav Amit
2018-06-22 17:22 ` [PATCH v6 8/9] x86: cpufeature: " Nadav Amit
2018-06-22 17:22 ` [PATCH v6 9/9] x86: jump-labels: " Nadav Amit
2018-07-24 14:26   ` Ingo Molnar [this message]
2018-07-24 16:29     ` Nadav Amit
2018-07-24 19:49       ` Ingo Molnar
2018-07-11  1:59 ` [PATCH v6 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-07-15 21:54   ` [kbuild ack?] " Ingo Molnar
2018-07-15 21:54     ` Ingo Molnar
2018-07-18  1:47     ` Masahiro Yamada
2018-07-18  1:47       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724142647.GA31700@gmail.com \
    --to=mingo@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namit@vmware.com \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.