All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Nadav Amit <namit@vmware.com>
Cc: Juergen Gross <jgross@suse.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Christopher Li <sparse@chrisli.org>, X86 ML <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	"virtualization@lists.linux-foundation.org"
	<virtualization@lists.linux-foundation.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	"linux-sparse@vger.kernel.org" <linux-sparse@vger.kernel.org>,
	Ingo Molnar <mingo@redhat.com>, Jan Beulich <JBeulich@suse.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Sam Ravnborg <sam@ravnborg.org>,
	Alok Kataria <akataria@vmware.com>
Subject: [kbuild ack?] Re: [PATCH v6 0/9] x86: macrofying inline asm for better compilation
Date: Sun, 15 Jul 2018 23:54:52 +0200	[thread overview]
Message-ID: <20180715215452.GA14040@gmail.com> (raw)
In-Reply-To: <BA4C0931-A51D-41AE-B918-C37EFFF35840@vmware.com>


* Nadav Amit <namit@vmware.com> wrote:

> > I ran some limited number of benchmarks, and in general the performance
> > impact is not very notable. You can still see >10 cycles shaved off some
> > syscalls that manipulate page-tables (e.g., mprotect()), in which
> > paravirt caused many functions not to be inlined. In addition this
> > patch-set can prevent issues such as [1], and improves code readability
> > and maintainability.

Ok, that's good enough as a benefit, I suppose.

> > Nadav Amit (9):
> >  Makefile: Prepare for using macros for inline asm

This non-trivial kbuild patch needs an Acked-by from Masahiro.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Nadav Amit <namit@vmware.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	X86 ML <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Sam Ravnborg <sam@ravnborg.org>,
	Alok Kataria <akataria@vmware.com>,
	Christopher Li <sparse@chrisli.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Jan Beulich <JBeulich@suse.com>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Juergen Gross <jgross@suse.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	"linux-sparse@vger.kernel.org" <linux-sparse@vger.kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: [kbuild ack?] Re: [PATCH v6 0/9] x86: macrofying inline asm for better compilation
Date: Sun, 15 Jul 2018 23:54:52 +0200	[thread overview]
Message-ID: <20180715215452.GA14040@gmail.com> (raw)
In-Reply-To: <BA4C0931-A51D-41AE-B918-C37EFFF35840@vmware.com>


* Nadav Amit <namit@vmware.com> wrote:

> > I ran some limited number of benchmarks, and in general the performance
> > impact is not very notable. You can still see >10 cycles shaved off some
> > syscalls that manipulate page-tables (e.g., mprotect()), in which
> > paravirt caused many functions not to be inlined. In addition this
> > patch-set can prevent issues such as [1], and improves code readability
> > and maintainability.

Ok, that's good enough as a benefit, I suppose.

> > Nadav Amit (9):
> >  Makefile: Prepare for using macros for inline asm

This non-trivial kbuild patch needs an Acked-by from Masahiro.

Thanks,

	Ingo

  reply	other threads:[~2018-07-15 21:54 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-22 17:22 [PATCH v6 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-06-22 17:22 ` Nadav Amit
2018-06-22 17:22 ` [PATCH v6 1/9] Makefile: Prepare for using macros for inline asm Nadav Amit
2018-06-22 17:22   ` Nadav Amit
2018-07-18  1:46   ` Masahiro Yamada
2018-07-24 11:14     ` Ingo Molnar
2018-07-24 18:04       ` Nadav Amit
2018-06-22 17:22 ` [PATCH v6 2/9] x86: objtool: use asm macro for better compiler decisions Nadav Amit
2018-06-22 17:22   ` Nadav Amit
2018-06-22 17:22 ` [PATCH v6 3/9] x86: refcount: prevent gcc distortions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 4/9] x86: alternatives: macrofy locks for better inlining Nadav Amit
2018-06-22 17:22 ` [PATCH v6 5/9] x86: bug: prevent gcc distortions Nadav Amit
2018-06-22 17:22 ` [PATCH v6 6/9] x86: prevent inline distortion by paravirt ops Nadav Amit
2018-06-22 17:22 ` [PATCH v6 7/9] x86: extable: use macros instead of inline assembly Nadav Amit
2018-06-22 17:22 ` [PATCH v6 8/9] x86: cpufeature: " Nadav Amit
2018-06-22 17:22 ` [PATCH v6 9/9] x86: jump-labels: " Nadav Amit
2018-07-24 14:26   ` Ingo Molnar
2018-07-24 16:29     ` Nadav Amit
2018-07-24 19:49       ` Ingo Molnar
2018-07-11  1:59 ` [PATCH v6 0/9] x86: macrofying inline asm for better compilation Nadav Amit
2018-07-15 21:54   ` Ingo Molnar [this message]
2018-07-15 21:54     ` [kbuild ack?] " Ingo Molnar
2018-07-18  1:47     ` Masahiro Yamada
2018-07-18  1:47       ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180715215452.GA14040@gmail.com \
    --to=mingo@kernel.org \
    --cc=JBeulich@suse.com \
    --cc=akataria@vmware.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jgross@suse.com \
    --cc=jpoimboe@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namit@vmware.com \
    --cc=peterz@infradead.org \
    --cc=pombredanne@nexb.com \
    --cc=sam@ravnborg.org \
    --cc=sparse@chrisli.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.