All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	Marc Zyngier <marc.zyngier@arm.com>,
	Hanna Hawa <hannah@marvell.com>
Subject: Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used
Date: Tue, 24 Jul 2018 14:44:07 +0000	[thread overview]
Message-ID: <20180724164407.4fa57d1f@windsurf> (raw)
In-Reply-To: <20180724143736.GA22088@ravnborg.org>

Hello,

Thanks for the review.

On Tue, 24 Jul 2018 16:37:36 +0200, Sam Ravnborg wrote:

> One nitpick below.
> But other than that this is a nice cleanup:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> > +/*
> > + * Locations of MSI Registers.
> > + */  
> 
> The SPARC way to format comments follows netdev style.
> So put it all in one line and everyone are happy:

Well, the code is being moved from arch/sparc to arch/sparc, so
apparently, it was already non-compliant to this specific coding style
rule. Should the comments be made compliant as part of the same commit,
or a separate one ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org,
	Marc Zyngier <marc.zyngier@arm.com>,
	Hanna Hawa <hannah@marvell.com>
Subject: Re: [PATCH 1/2] sparc: move MSI related definitions to where they are used
Date: Tue, 24 Jul 2018 16:44:07 +0200	[thread overview]
Message-ID: <20180724164407.4fa57d1f@windsurf> (raw)
In-Reply-To: <20180724143736.GA22088@ravnborg.org>

Hello,

Thanks for the review.

On Tue, 24 Jul 2018 16:37:36 +0200, Sam Ravnborg wrote:

> One nitpick below.
> But other than that this is a nice cleanup:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> > +/*
> > + * Locations of MSI Registers.
> > + */  
> 
> The SPARC way to format comments follows netdev style.
> So put it all in one line and everyone are happy:

Well, the code is being moved from arch/sparc to arch/sparc, so
apparently, it was already non-compliant to this specific coding style
rule. Should the comments be made compliant as part of the same commit,
or a separate one ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2018-07-24 14:44 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-24 11:53 [PATCH 1/2] sparc: move MSI related definitions to where they are used Thomas Petazzoni
2018-07-24 11:53 ` Thomas Petazzoni
2018-07-24 11:53 ` [PATCH 2/2] sparc: use asm-generic version of msi.h Thomas Petazzoni
2018-07-24 11:53   ` Thomas Petazzoni
2018-07-30 20:01   ` David Miller
2018-07-30 20:01     ` David Miller
2018-07-24 14:37 ` [PATCH 1/2] sparc: move MSI related definitions to where they are used Sam Ravnborg
2018-07-24 14:37   ` Sam Ravnborg
2018-07-24 14:44   ` Thomas Petazzoni [this message]
2018-07-24 14:44     ` Thomas Petazzoni
2018-07-24 14:55     ` Sam Ravnborg
2018-07-24 14:55       ` Sam Ravnborg
2018-07-30 20:01 ` David Miller
2018-07-30 20:01   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180724164407.4fa57d1f@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=davem@davemloft.net \
    --cc=hannah@marvell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=sam@ravnborg.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.