From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: Christoph Hellwig <hch@lst.de>,
keith.busch@intel.com, linux-nvme@lists.infradead.org,
sagi@grimberg.me, martin.petersen@oracle.com,
linux-block@vger.kernel.org, axboe@kernel.dk,
vladimirk@mellanox.com
Subject: Re: [PATCH 2/3] block: move dif_prepare/dif_complete functions to block layer
Date: Tue, 24 Jul 2018 19:41:04 +0200 [thread overview]
Message-ID: <20180724174104.GA1791@lst.de> (raw)
In-Reply-To: <2fdb170d-e8de-b7cc-429a-9b6e5f36de86@mellanox.com>
> /**
> * t10_pi_prepare() - prepate PI prior submitting request to device
no need for the braces here.
>
> * @rq: request with PI that should be prepared
> * @protection_type: PI type (Type 1/Type 2/Type 3)
> *
> * Description:
No need for the description tag either (although I don't think it
is actively harmful)
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 2/3] block: move dif_prepare/dif_complete functions to block layer
Date: Tue, 24 Jul 2018 19:41:04 +0200 [thread overview]
Message-ID: <20180724174104.GA1791@lst.de> (raw)
In-Reply-To: <2fdb170d-e8de-b7cc-429a-9b6e5f36de86@mellanox.com>
> /**
> * t10_pi_prepare() - prepate PI prior submitting request to device
no need for the braces here.
>
> * @rq: request with PI that should be prepared
> * @protection_type: PI type (Type 1/Type 2/Type 3)
> *
> * Description:
No need for the description tag either (although I don't think it
is actively harmful)
next prev parent reply other threads:[~2018-07-24 17:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 13:33 [PATCH 1/3] block: move ref_tag calculation func to the block layer Max Gurtovoy
2018-07-24 13:33 ` Max Gurtovoy
2018-07-24 13:33 ` [PATCH 2/3] block: move dif_prepare/dif_complete functions to " Max Gurtovoy
2018-07-24 13:33 ` Max Gurtovoy
2018-07-24 13:55 ` Christoph Hellwig
2018-07-24 13:55 ` Christoph Hellwig
2018-07-24 14:33 ` Max Gurtovoy
2018-07-24 14:33 ` Max Gurtovoy
2018-07-24 17:41 ` Christoph Hellwig [this message]
2018-07-24 17:41 ` Christoph Hellwig
2018-07-24 20:33 ` Keith Busch
2018-07-24 20:33 ` Keith Busch
2018-07-24 22:32 ` Max Gurtovoy
2018-07-24 22:32 ` Max Gurtovoy
2018-07-24 13:33 ` [PATCH 3/3] nvme: use blk API to remap ref tags for IOs with metadata Max Gurtovoy
2018-07-24 13:33 ` Max Gurtovoy
2018-07-24 13:56 ` Christoph Hellwig
2018-07-24 13:56 ` Christoph Hellwig
2018-07-24 13:52 ` [PATCH 1/3] block: move ref_tag calculation func to the block layer Christoph Hellwig
2018-07-24 13:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724174104.GA1791@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.