From: Keith Busch <keith.busch@intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
Ross Zwisler <zwisler@kernel.org>
Subject: Re: [PATCH] libnvdimm: fix NULL pointer dereference
Date: Tue, 24 Jul 2018 13:46:29 -0600 [thread overview]
Message-ID: <20180724194629.GA13685@localhost.localdomain> (raw)
In-Reply-To: <20180724134006.GA2775@embeddedor.com>
On Tue, Jul 24, 2018 at 08:40:06AM -0500, Gustavo A. R. Silva wrote:
> ndd is being dereferenced before it is null checked, hence there is a
> potential null pointer dereference.
>
> Fix this by moving the pointer dereference after ndd has been properly
> null checked at line 554: if (!ndd)
I'll fold this into v4 of the patch since Vishal found an issue when a
DIMM has multiple regions.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <zwisler@kernel.org>,
Vishal Verma <vishal.l.verma@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libnvdimm: fix NULL pointer dereference
Date: Tue, 24 Jul 2018 13:46:29 -0600 [thread overview]
Message-ID: <20180724194629.GA13685@localhost.localdomain> (raw)
In-Reply-To: <20180724134006.GA2775@embeddedor.com>
On Tue, Jul 24, 2018 at 08:40:06AM -0500, Gustavo A. R. Silva wrote:
> ndd is being dereferenced before it is null checked, hence there is a
> potential null pointer dereference.
>
> Fix this by moving the pointer dereference after ndd has been properly
> null checked at line 554: if (!ndd)
I'll fold this into v4 of the patch since Vishal found an issue when a
DIMM has multiple regions.
next prev parent reply other threads:[~2018-07-24 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 13:40 [PATCH] libnvdimm: fix NULL pointer dereference Gustavo A. R. Silva
2018-07-24 13:40 ` Gustavo A. R. Silva
2018-07-24 19:46 ` Keith Busch [this message]
2018-07-24 19:46 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724194629.GA13685@localhost.localdomain \
--to=keith.busch@intel.com \
--cc=gustavo@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=zwisler@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.