All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <keith.busch@linux.intel.com>
To: dgilbert@interlog.com
Cc: Bart Van Assche <bart.vanassche@wdc.com>,
	Keith Busch <keith.busch@intel.com>,
	linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>,
	Jianchao Wang <jianchao.w.wang@oracle.com>,
	linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
Date: Tue, 24 Jul 2018 20:48:16 -0600	[thread overview]
Message-ID: <20180725024816.GB14596@localhost.localdomain> (raw)
In-Reply-To: <70619fc4-3b98-4213-0d4e-aa7aa248f88d@interlog.com>

On Tue, Jul 24, 2018 at 09:56:35PM -0400, dgilbert@interlog.com wrote:
> No LLD should be calling scsi_finish_command() IMO.

Agreed. I don't even think scsi's error handler should directly call it
either, but detangling that may take some time, if ever.

WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@linux.intel.com (Keith Busch)
Subject: [PATCHv2 2/2] scsi: set timed out out mq requests to complete
Date: Tue, 24 Jul 2018 20:48:16 -0600	[thread overview]
Message-ID: <20180725024816.GB14596@localhost.localdomain> (raw)
In-Reply-To: <70619fc4-3b98-4213-0d4e-aa7aa248f88d@interlog.com>

On Tue, Jul 24, 2018@09:56:35PM -0400, dgilbert@interlog.com wrote:
> No LLD should be calling scsi_finish_command() IMO.

Agreed. I don't even think scsi's error handler should directly call it
either, but detangling that may take some time, if ever.

  reply	other threads:[~2018-07-25  2:48 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-23 14:37 [PATCHv2 1/2] blk-mq: export setting request completion state Keith Busch
2018-07-23 14:37 ` Keith Busch
2018-07-23 14:37 ` [PATCHv2 2/2] scsi: set timed out out mq requests to complete Keith Busch
2018-07-23 14:37   ` Keith Busch
2018-07-24  7:56   ` Christoph Hellwig
2018-07-24  7:56     ` Christoph Hellwig
2018-07-24 22:46   ` Bart Van Assche
2018-07-24 22:46     ` Bart Van Assche
2018-07-25  1:15     ` Keith Busch
2018-07-25  1:15       ` Keith Busch
2018-07-25  1:56       ` Douglas Gilbert
2018-07-25  1:56         ` Douglas Gilbert
2018-07-25  2:48         ` Keith Busch [this message]
2018-07-25  2:48           ` Keith Busch
2018-07-25 15:52   ` Bart Van Assche
2018-07-25 15:52     ` Bart Van Assche
2018-07-25 16:48     ` Keith Busch
2018-07-25 16:48       ` Keith Busch
2018-07-24  7:56 ` [PATCHv2 1/2] blk-mq: export setting request completion state Christoph Hellwig
2018-07-24  7:56   ` Christoph Hellwig
2018-07-24 20:42 ` Jens Axboe
2018-07-24 20:42   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180725024816.GB14596@localhost.localdomain \
    --to=keith.busch@linux.intel.com \
    --cc=axboe@kernel.dk \
    --cc=bart.vanassche@wdc.com \
    --cc=dgilbert@interlog.com \
    --cc=hch@lst.de \
    --cc=jianchao.w.wang@oracle.com \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.