* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
@ 2018-07-23 15:39 ` Jonathan Corbet
0 siblings, 0 replies; 11+ messages in thread
From: Jonathan Corbet @ 2018-07-23 15:39 UTC (permalink / raw)
To: Marcel Ziswiler
Cc: linux-mtd, Marcel Ziswiler, Gregory CLEMENT, H Hartley Sweeten,
linux-doc, linux-kernel, Krzysztof Kozlowski, Boris Brezillon,
Vladimir Zapolskiy
On Fri, 20 Jul 2018 09:53:33 +0200
Marcel Ziswiler <marcel@ziswiler.com> wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> This fixes some spelling mistakes.
So I hate to complain about a documentation improvement, but...
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> Documentation/driver-api/mtdnand.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/driver-api/mtdnand.rst b/Documentation/driver-api/mtdnand.rst
> index dcd63599f700..c55a6034c397 100644
> --- a/Documentation/driver-api/mtdnand.rst
> +++ b/Documentation/driver-api/mtdnand.rst
> @@ -374,7 +374,7 @@ The nand driver supports three different types of hardware ECC.
>
> - NAND_ECC_HW8_512
>
> - Hardware ECC generator providing 6 bytes ECC per 512 byte.
> + Hardware ECC generator providing 8 bytes ECC per 512 byte.
That's not a spelling mistake, that's a factual change. I'll apply the
patch since it appears to be correct, but will be tweaking the changelog.
Thanks,
jon
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
2018-07-23 15:39 ` Jonathan Corbet
(?)
@ 2018-07-23 15:44 ` Marcel Ziswiler
-1 siblings, 0 replies; 11+ messages in thread
From: Marcel Ziswiler @ 2018-07-23 15:44 UTC (permalink / raw)
To: corbet@lwn.net
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
krzk@kernel.org, hsweeten@visionengravers.com,
boris.brezillon@bootlin.com, gregory.clement@bootlin.com,
vz@mleia.com, linux-doc@vger.kernel.org
On Mon, 2018-07-23 at 09:39 -0600, Jonathan Corbet wrote:
> On Fri, 20 Jul 2018 09:53:33 +0200
> Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > This fixes some spelling mistakes.
>
> So I hate to complain about a documentation improvement, but...
>
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > Documentation/driver-api/mtdnand.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/driver-api/mtdnand.rst
> > b/Documentation/driver-api/mtdnand.rst
> > index dcd63599f700..c55a6034c397 100644
> > --- a/Documentation/driver-api/mtdnand.rst
> > +++ b/Documentation/driver-api/mtdnand.rst
> > @@ -374,7 +374,7 @@ The nand driver supports three different types
> > of hardware ECC.
> >
> > - NAND_ECC_HW8_512
> >
> > - Hardware ECC generator providing 6 bytes ECC per 512 byte.
> > + Hardware ECC generator providing 8 bytes ECC per 512 byte.
>
> That's not a spelling mistake, that's a factual change. I'll apply
> the
> patch since it appears to be correct, but will be tweaking the
> changelog.
Yeah, probably a copy/paste mistake. No pun intended.
> Thanks,
>
> jon
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
2018-07-23 15:39 ` Jonathan Corbet
@ 2018-07-23 16:19 ` Boris Brezillon
-1 siblings, 0 replies; 11+ messages in thread
From: Boris Brezillon @ 2018-07-23 16:19 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Marcel Ziswiler, linux-mtd, Marcel Ziswiler, Gregory CLEMENT,
H Hartley Sweeten, linux-doc, linux-kernel, Krzysztof Kozlowski,
Vladimir Zapolskiy, Miquel Raynal
Hi Jonathan,
On Mon, 23 Jul 2018 09:39:24 -0600
Jonathan Corbet <corbet@lwn.net> wrote:
> On Fri, 20 Jul 2018 09:53:33 +0200
> Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > This fixes some spelling mistakes.
>
> So I hate to complain about a documentation improvement, but...
>
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > Documentation/driver-api/mtdnand.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/driver-api/mtdnand.rst b/Documentation/driver-api/mtdnand.rst
> > index dcd63599f700..c55a6034c397 100644
> > --- a/Documentation/driver-api/mtdnand.rst
> > +++ b/Documentation/driver-api/mtdnand.rst
> > @@ -374,7 +374,7 @@ The nand driver supports three different types of hardware ECC.
> >
> > - NAND_ECC_HW8_512
> >
> > - Hardware ECC generator providing 6 bytes ECC per 512 byte.
> > + Hardware ECC generator providing 8 bytes ECC per 512 byte.
>
> That's not a spelling mistake, that's a factual change. I'll apply the
> patch since it appears to be correct, but will be tweaking the changelog.
I think Miquel had planned to apply this patch to the NAND tree, but we
don't seem to have conflicting changes on this file, so feel free to
take it in the doc tree.
Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
Regards,
Boris
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
@ 2018-07-23 16:19 ` Boris Brezillon
0 siblings, 0 replies; 11+ messages in thread
From: Boris Brezillon @ 2018-07-23 16:19 UTC (permalink / raw)
To: Jonathan Corbet
Cc: Marcel Ziswiler, linux-mtd, Marcel Ziswiler, Gregory CLEMENT,
H Hartley Sweeten, linux-doc, linux-kernel, Krzysztof Kozlowski,
Vladimir Zapolskiy, Miquel Raynal
Hi Jonathan,
On Mon, 23 Jul 2018 09:39:24 -0600
Jonathan Corbet <corbet@lwn.net> wrote:
> On Fri, 20 Jul 2018 09:53:33 +0200
> Marcel Ziswiler <marcel@ziswiler.com> wrote:
>
> > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > This fixes some spelling mistakes.
>
> So I hate to complain about a documentation improvement, but...
>
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > Documentation/driver-api/mtdnand.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/driver-api/mtdnand.rst b/Documentation/driver-api/mtdnand.rst
> > index dcd63599f700..c55a6034c397 100644
> > --- a/Documentation/driver-api/mtdnand.rst
> > +++ b/Documentation/driver-api/mtdnand.rst
> > @@ -374,7 +374,7 @@ The nand driver supports three different types of hardware ECC.
> >
> > - NAND_ECC_HW8_512
> >
> > - Hardware ECC generator providing 6 bytes ECC per 512 byte.
> > + Hardware ECC generator providing 8 bytes ECC per 512 byte.
>
> That's not a spelling mistake, that's a factual change. I'll apply the
> patch since it appears to be correct, but will be tweaking the changelog.
I think Miquel had planned to apply this patch to the NAND tree, but we
don't seem to have conflicting changes on this file, so feel free to
take it in the doc tree.
Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
Regards,
Boris
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
2018-07-23 16:19 ` Boris Brezillon
@ 2018-07-25 7:29 ` Miquel Raynal
-1 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2018-07-25 7:29 UTC (permalink / raw)
To: Boris Brezillon
Cc: Jonathan Corbet, Marcel Ziswiler, linux-mtd, Marcel Ziswiler,
Gregory CLEMENT, H Hartley Sweeten, linux-doc, linux-kernel,
Krzysztof Kozlowski, Vladimir Zapolskiy
Hi Jonathan,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Mon, 23 Jul 2018
18:19:15 +0200:
> Hi Jonathan,
>
> On Mon, 23 Jul 2018 09:39:24 -0600
> Jonathan Corbet <corbet@lwn.net> wrote:
>
> > On Fri, 20 Jul 2018 09:53:33 +0200
> > Marcel Ziswiler <marcel@ziswiler.com> wrote:
> >
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > This fixes some spelling mistakes.
> >
> > So I hate to complain about a documentation improvement, but...
> >
> > >
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > ---
> > >
> > > Documentation/driver-api/mtdnand.rst | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/driver-api/mtdnand.rst b/Documentation/driver-api/mtdnand.rst
> > > index dcd63599f700..c55a6034c397 100644
> > > --- a/Documentation/driver-api/mtdnand.rst
> > > +++ b/Documentation/driver-api/mtdnand.rst
> > > @@ -374,7 +374,7 @@ The nand driver supports three different types of hardware ECC.
> > >
> > > - NAND_ECC_HW8_512
> > >
> > > - Hardware ECC generator providing 6 bytes ECC per 512 byte.
> > > + Hardware ECC generator providing 8 bytes ECC per 512 byte.
> >
> > That's not a spelling mistake, that's a factual change. I'll apply the
> > patch since it appears to be correct, but will be tweaking the changelog.
>
> I think Miquel had planned to apply this patch to the NAND tree, but we
> don't seem to have conflicting changes on this file, so feel free to
> take it in the doc tree.
>
> Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
Can you confirm you will take this patch?
Thanks,
Miquèl
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
@ 2018-07-25 7:29 ` Miquel Raynal
0 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2018-07-25 7:29 UTC (permalink / raw)
To: Boris Brezillon
Cc: Jonathan Corbet, Marcel Ziswiler, linux-mtd, Marcel Ziswiler,
Gregory CLEMENT, H Hartley Sweeten, linux-doc, linux-kernel,
Krzysztof Kozlowski, Vladimir Zapolskiy
Hi Jonathan,
Boris Brezillon <boris.brezillon@bootlin.com> wrote on Mon, 23 Jul 2018
18:19:15 +0200:
> Hi Jonathan,
>
> On Mon, 23 Jul 2018 09:39:24 -0600
> Jonathan Corbet <corbet@lwn.net> wrote:
>
> > On Fri, 20 Jul 2018 09:53:33 +0200
> > Marcel Ziswiler <marcel@ziswiler.com> wrote:
> >
> > > From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > This fixes some spelling mistakes.
> >
> > So I hate to complain about a documentation improvement, but...
> >
> > >
> > > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> > >
> > > ---
> > >
> > > Documentation/driver-api/mtdnand.rst | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/driver-api/mtdnand.rst b/Documentation/driver-api/mtdnand.rst
> > > index dcd63599f700..c55a6034c397 100644
> > > --- a/Documentation/driver-api/mtdnand.rst
> > > +++ b/Documentation/driver-api/mtdnand.rst
> > > @@ -374,7 +374,7 @@ The nand driver supports three different types of hardware ECC.
> > >
> > > - NAND_ECC_HW8_512
> > >
> > > - Hardware ECC generator providing 6 bytes ECC per 512 byte.
> > > + Hardware ECC generator providing 8 bytes ECC per 512 byte.
> >
> > That's not a spelling mistake, that's a factual change. I'll apply the
> > patch since it appears to be correct, but will be tweaking the changelog.
>
> I think Miquel had planned to apply this patch to the NAND tree, but we
> don't seem to have conflicting changes on this file, so feel free to
> take it in the doc tree.
>
> Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
Can you confirm you will take this patch?
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
2018-07-25 7:29 ` Miquel Raynal
@ 2018-07-25 14:15 ` Jonathan Corbet
-1 siblings, 0 replies; 11+ messages in thread
From: Jonathan Corbet @ 2018-07-25 14:15 UTC (permalink / raw)
To: Miquel Raynal
Cc: Boris Brezillon, Marcel Ziswiler, linux-mtd, Marcel Ziswiler,
Gregory CLEMENT, H Hartley Sweeten, linux-doc, linux-kernel,
Krzysztof Kozlowski, Vladimir Zapolskiy
On Wed, 25 Jul 2018 09:29:28 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > That's not a spelling mistake, that's a factual change. I'll apply the
> > > patch since it appears to be correct, but will be tweaking the changelog.
> >
> > I think Miquel had planned to apply this patch to the NAND tree, but we
> > don't seem to have conflicting changes on this file, so feel free to
> > take it in the doc tree.
> >
> > Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
> Can you confirm you will take this patch?
Yeah, that's what the "I'll apply the patch" part above means :) It's
already in docs-next.
Thanks,
jon
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] mtd: nand: fix spelling in driver api documentation
@ 2018-07-25 14:15 ` Jonathan Corbet
0 siblings, 0 replies; 11+ messages in thread
From: Jonathan Corbet @ 2018-07-25 14:15 UTC (permalink / raw)
To: Miquel Raynal
Cc: Boris Brezillon, Marcel Ziswiler, linux-mtd, Marcel Ziswiler,
Gregory CLEMENT, H Hartley Sweeten, linux-doc, linux-kernel,
Krzysztof Kozlowski, Vladimir Zapolskiy
On Wed, 25 Jul 2018 09:29:28 +0200
Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > That's not a spelling mistake, that's a factual change. I'll apply the
> > > patch since it appears to be correct, but will be tweaking the changelog.
> >
> > I think Miquel had planned to apply this patch to the NAND tree, but we
> > don't seem to have conflicting changes on this file, so feel free to
> > take it in the doc tree.
> >
> > Acked-by: Boris Brezillon <boris.brezillon@bootlin.com>
>
> Can you confirm you will take this patch?
Yeah, that's what the "I'll apply the patch" part above means :) It's
already in docs-next.
Thanks,
jon
^ permalink raw reply [flat|nested] 11+ messages in thread