From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Russell King <linux@armlinux.org.uk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ARM: at91: remove unused duplicated filechk_offsets
Date: Wed, 25 Jul 2018 12:17:51 +0200 [thread overview]
Message-ID: <20180725101751.GB3539@piout.net> (raw)
In-Reply-To: <1532495771-10255-1-git-send-email-yamada.masahiro@socionext.com>
On 25/07/2018 14:16:10+0900, Masahiro Yamada wrote:
> The filechk_offsets in arch/arm/mach-at91/Makefile is never
> used because it is always overridden by the equivalent one in
> scripts/Makefile.lib
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>
> I will queue this to my kbuild tree.
>
>
> arch/arm/mach-at91/Makefile | 25 -------------------------
> 1 file changed, 25 deletions(-)
>
> diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> index 4ea93c9..7415f18 100644
> --- a/arch/arm/mach-at91/Makefile
> +++ b/arch/arm/mach-at91/Makefile
> @@ -19,31 +19,6 @@ ifeq ($(CONFIG_PM_DEBUG),y)
> CFLAGS_pm.o += -DDEBUG
> endif
>
> -# Default sed regexp - multiline due to syntax constraints
> -define sed-y
> - "/^->/{s:->#\(.*\):/* \1 */:; \
> - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \
> - s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \
> - s:->::; p;}"
> -endef
> -
> -# Use filechk to avoid rebuilds when a header changes, but the resulting file
> -# does not
> -define filechk_offsets
> - (set -e; \
> - echo "#ifndef $2"; \
> - echo "#define $2"; \
> - echo "/*"; \
> - echo " * DO NOT MODIFY."; \
> - echo " *"; \
> - echo " * This file was generated by Kbuild"; \
> - echo " */"; \
> - echo ""; \
> - sed -ne $(sed-y); \
> - echo ""; \
> - echo "#endif" )
> -endef
> -
> arch/arm/mach-at91/pm_data-offsets.s: arch/arm/mach-at91/pm_data-offsets.c
> $(call if_changed_dep,cc_s_c)
>
> --
> 2.7.4
>
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: alexandre.belloni@bootlin.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: at91: remove unused duplicated filechk_offsets
Date: Wed, 25 Jul 2018 12:17:51 +0200 [thread overview]
Message-ID: <20180725101751.GB3539@piout.net> (raw)
In-Reply-To: <1532495771-10255-1-git-send-email-yamada.masahiro@socionext.com>
On 25/07/2018 14:16:10+0900, Masahiro Yamada wrote:
> The filechk_offsets in arch/arm/mach-at91/Makefile is never
> used because it is always overridden by the equivalent one in
> scripts/Makefile.lib
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> ---
>
> I will queue this to my kbuild tree.
>
>
> arch/arm/mach-at91/Makefile | 25 -------------------------
> 1 file changed, 25 deletions(-)
>
> diff --git a/arch/arm/mach-at91/Makefile b/arch/arm/mach-at91/Makefile
> index 4ea93c9..7415f18 100644
> --- a/arch/arm/mach-at91/Makefile
> +++ b/arch/arm/mach-at91/Makefile
> @@ -19,31 +19,6 @@ ifeq ($(CONFIG_PM_DEBUG),y)
> CFLAGS_pm.o += -DDEBUG
> endif
>
> -# Default sed regexp - multiline due to syntax constraints
> -define sed-y
> - "/^->/{s:->#\(.*\):/* \1 */:; \
> - s:^->\([^ ]*\) [\$$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; \
> - s:^->\([^ ]*\) [\$$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; \
> - s:->::; p;}"
> -endef
> -
> -# Use filechk to avoid rebuilds when a header changes, but the resulting file
> -# does not
> -define filechk_offsets
> - (set -e; \
> - echo "#ifndef $2"; \
> - echo "#define $2"; \
> - echo "/*"; \
> - echo " * DO NOT MODIFY."; \
> - echo " *"; \
> - echo " * This file was generated by Kbuild"; \
> - echo " */"; \
> - echo ""; \
> - sed -ne $(sed-y); \
> - echo ""; \
> - echo "#endif" )
> -endef
> -
> arch/arm/mach-at91/pm_data-offsets.s: arch/arm/mach-at91/pm_data-offsets.c
> $(call if_changed_dep,cc_s_c)
>
> --
> 2.7.4
>
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-07-25 11:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 5:16 [PATCH 1/2] ARM: at91: remove unused duplicated filechk_offsets Masahiro Yamada
2018-07-25 5:16 ` Masahiro Yamada
2018-07-25 5:16 ` [PATCH 2/2] kbuild: do not redirect the first prerequisite for filechk Masahiro Yamada
2018-07-25 5:16 ` Masahiro Yamada
2018-07-25 10:17 ` Alexandre Belloni [this message]
2018-07-25 10:17 ` [PATCH 1/2] ARM: at91: remove unused duplicated filechk_offsets Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725101751.GB3539@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nicolas.ferre@microchip.com \
--cc=sam@ravnborg.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.