From: Christoph Hellwig <hch@lst.de>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: keith.busch@intel.com, linux-nvme@lists.infradead.org,
sagi@grimberg.me, hch@lst.de, martin.petersen@oracle.com,
linux-block@vger.kernel.org, axboe@kernel.dk,
vladimirk@mellanox.com
Subject: Re: [PATCH v3 2/3] block: move dif_prepare/dif_complete functions to block layer
Date: Wed, 25 Jul 2018 13:22:47 +0200 [thread overview]
Message-ID: <20180725112247.GA24190@lst.de> (raw)
In-Reply-To: <1532508421-2711-2-git-send-email-maxg@mellanox.com>
> + pmap = kmap_atomic(iv.bv_page) + iv.bv_offset;
> + p = pmap;
Maybe:
pmap = p = kmap_atomic(iv.bv_page) + iv.bv_offset;
> + for (j = 0; j < iv.bv_len; j += tuple_sz) {
> + pi = (struct t10_pi_tuple *)p;
No need for the cast, also the pi declaration can be moved into the
inner scope:
struct t10_pi_tuple *pi = p;
> + pmap = kmap_atomic(iv.bv_page) + iv.bv_offset;
> + p = pmap;
> + for (j = 0; j < iv.bv_len; j += tuple_sz) {
> + if (intervals == 0) {
> + kunmap_atomic(pmap);
> + return;
> + }
> + pi = (struct t10_pi_tuple *)p;
Same here.
Also the intervals check would make sense in the for loop I think, e.g.:
pmap = p = kmap_atomic(iv.bv_page) + iv.bv_offset;
for (j = 0; j < iv.bv_len && intervals; j += tuple_sz) {
struct t10_pi_tuple *pi = p;
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH v3 2/3] block: move dif_prepare/dif_complete functions to block layer
Date: Wed, 25 Jul 2018 13:22:47 +0200 [thread overview]
Message-ID: <20180725112247.GA24190@lst.de> (raw)
In-Reply-To: <1532508421-2711-2-git-send-email-maxg@mellanox.com>
> + pmap = kmap_atomic(iv.bv_page) + iv.bv_offset;
> + p = pmap;
Maybe:
pmap = p = kmap_atomic(iv.bv_page) + iv.bv_offset;
> + for (j = 0; j < iv.bv_len; j += tuple_sz) {
> + pi = (struct t10_pi_tuple *)p;
No need for the cast, also the pi declaration can be moved into the
inner scope:
struct t10_pi_tuple *pi = p;
> + pmap = kmap_atomic(iv.bv_page) + iv.bv_offset;
> + p = pmap;
> + for (j = 0; j < iv.bv_len; j += tuple_sz) {
> + if (intervals == 0) {
> + kunmap_atomic(pmap);
> + return;
> + }
> + pi = (struct t10_pi_tuple *)p;
Same here.
Also the intervals check would make sense in the for loop I think, e.g.:
pmap = p = kmap_atomic(iv.bv_page) + iv.bv_offset;
for (j = 0; j < iv.bv_len && intervals; j += tuple_sz) {
struct t10_pi_tuple *pi = p;
next prev parent reply other threads:[~2018-07-25 11:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 8:46 [PATCH v3 1/3] block: move ref_tag calculation func to the block layer Max Gurtovoy
2018-07-25 8:46 ` Max Gurtovoy
2018-07-25 8:47 ` [PATCH v3 2/3] block: move dif_prepare/dif_complete functions to " Max Gurtovoy
2018-07-25 8:47 ` Max Gurtovoy
2018-07-25 11:22 ` Christoph Hellwig [this message]
2018-07-25 11:22 ` Christoph Hellwig
2018-07-25 11:47 ` Max Gurtovoy
2018-07-25 11:47 ` Max Gurtovoy
2018-07-25 14:53 ` Keith Busch
2018-07-25 14:53 ` Keith Busch
2018-07-25 8:47 ` [PATCH v3 3/3] nvme: use blk API to remap ref tags for IOs with metadata Max Gurtovoy
2018-07-25 8:47 ` Max Gurtovoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725112247.GA24190@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=sagi@grimberg.me \
--cc=vladimirk@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.