From: Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>
To: Vivek Gautam <vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 3/3] iommu/arm-smmu: Error out only if not enough context interrupts
Date: Wed, 25 Jul 2018 12:57:30 +0100 [thread overview]
Message-ID: <20180725115729.GA31576@arm.com> (raw)
In-Reply-To: <d6796a00-17da-c03e-ca7f-7a67139ad99a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Tue, Jul 24, 2018 at 03:09:41PM +0530, Vivek Gautam wrote:
> On 7/24/2018 2:06 PM, Will Deacon wrote:
> >On Thu, Jul 19, 2018 at 11:23:56PM +0530, Vivek Gautam wrote:
> >>diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> >>index 7c69736a30f8..4cb53bf4f423 100644
> >>--- a/drivers/iommu/arm-smmu.c
> >>+++ b/drivers/iommu/arm-smmu.c
> >>@@ -2229,12 +2229,19 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
> >> if (err)
> >> return err;
> >>- if (smmu->version == ARM_SMMU_V2 &&
> >>- smmu->num_context_banks != smmu->num_context_irqs) {
> >>- dev_err(dev,
> >>- "found only %d context interrupt(s) but %d required\n",
> >>- smmu->num_context_irqs, smmu->num_context_banks);
> >>- return -ENODEV;
> >>+ if (smmu->version == ARM_SMMU_V2) {
> >>+ if (smmu->num_context_banks > smmu->num_context_irqs) {
> >>+ dev_err(dev,
> >>+ "found only %d context irq(s) but %d required\n",
> >>+ smmu->num_context_irqs, smmu->num_context_banks);
> >>+ return -ENODEV;
> >>+ } else if (smmu->num_context_banks < smmu->num_context_irqs) {
> >>+ /* loose extra context interrupts */
> >>+ dev_notice(dev,
> >>+ "found %d context irq(s) but only %d required\n",
> >>+ smmu->num_context_irqs, smmu->num_context_banks);
> >>+ smmu->num_context_irqs = smmu->num_context_banks;
> >>+ }
> >I don't see the utility in the new message. Can you simplify with the patch
> >below on top? It's a bit weird that we only decide to ignore the extra irqs
> >after calling platform_get_irq() on them, but that seems to be harmless.
>
> Thanks. I will modify as suggested below and respin.
It's ok, I can make the change locally.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] iommu/arm-smmu: Error out only if not enough context interrupts
Date: Wed, 25 Jul 2018 12:57:30 +0100 [thread overview]
Message-ID: <20180725115729.GA31576@arm.com> (raw)
In-Reply-To: <d6796a00-17da-c03e-ca7f-7a67139ad99a@codeaurora.org>
On Tue, Jul 24, 2018 at 03:09:41PM +0530, Vivek Gautam wrote:
> On 7/24/2018 2:06 PM, Will Deacon wrote:
> >On Thu, Jul 19, 2018 at 11:23:56PM +0530, Vivek Gautam wrote:
> >>diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> >>index 7c69736a30f8..4cb53bf4f423 100644
> >>--- a/drivers/iommu/arm-smmu.c
> >>+++ b/drivers/iommu/arm-smmu.c
> >>@@ -2229,12 +2229,19 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
> >> if (err)
> >> return err;
> >>- if (smmu->version == ARM_SMMU_V2 &&
> >>- smmu->num_context_banks != smmu->num_context_irqs) {
> >>- dev_err(dev,
> >>- "found only %d context interrupt(s) but %d required\n",
> >>- smmu->num_context_irqs, smmu->num_context_banks);
> >>- return -ENODEV;
> >>+ if (smmu->version == ARM_SMMU_V2) {
> >>+ if (smmu->num_context_banks > smmu->num_context_irqs) {
> >>+ dev_err(dev,
> >>+ "found only %d context irq(s) but %d required\n",
> >>+ smmu->num_context_irqs, smmu->num_context_banks);
> >>+ return -ENODEV;
> >>+ } else if (smmu->num_context_banks < smmu->num_context_irqs) {
> >>+ /* loose extra context interrupts */
> >>+ dev_notice(dev,
> >>+ "found %d context irq(s) but only %d required\n",
> >>+ smmu->num_context_irqs, smmu->num_context_banks);
> >>+ smmu->num_context_irqs = smmu->num_context_banks;
> >>+ }
> >I don't see the utility in the new message. Can you simplify with the patch
> >below on top? It's a bit weird that we only decide to ignore the extra irqs
> >after calling platform_get_irq() on them, but that seems to be harmless.
>
> Thanks. I will modify as suggested below and respin.
It's ok, I can make the change locally.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: joro@8bytes.org, robh+dt@kernel.org, robin.murphy@arm.com,
andy.gross@linaro.org, mark.rutland@arm.com,
iommu@lists.linux-foundation.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, tfiga@chromium.org,
sricharan@codeaurora.org, linux-arm-msm@vger.kernel.org,
david.brown@linaro.org, linux-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] iommu/arm-smmu: Error out only if not enough context interrupts
Date: Wed, 25 Jul 2018 12:57:30 +0100 [thread overview]
Message-ID: <20180725115729.GA31576@arm.com> (raw)
In-Reply-To: <d6796a00-17da-c03e-ca7f-7a67139ad99a@codeaurora.org>
On Tue, Jul 24, 2018 at 03:09:41PM +0530, Vivek Gautam wrote:
> On 7/24/2018 2:06 PM, Will Deacon wrote:
> >On Thu, Jul 19, 2018 at 11:23:56PM +0530, Vivek Gautam wrote:
> >>diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> >>index 7c69736a30f8..4cb53bf4f423 100644
> >>--- a/drivers/iommu/arm-smmu.c
> >>+++ b/drivers/iommu/arm-smmu.c
> >>@@ -2229,12 +2229,19 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
> >> if (err)
> >> return err;
> >>- if (smmu->version == ARM_SMMU_V2 &&
> >>- smmu->num_context_banks != smmu->num_context_irqs) {
> >>- dev_err(dev,
> >>- "found only %d context interrupt(s) but %d required\n",
> >>- smmu->num_context_irqs, smmu->num_context_banks);
> >>- return -ENODEV;
> >>+ if (smmu->version == ARM_SMMU_V2) {
> >>+ if (smmu->num_context_banks > smmu->num_context_irqs) {
> >>+ dev_err(dev,
> >>+ "found only %d context irq(s) but %d required\n",
> >>+ smmu->num_context_irqs, smmu->num_context_banks);
> >>+ return -ENODEV;
> >>+ } else if (smmu->num_context_banks < smmu->num_context_irqs) {
> >>+ /* loose extra context interrupts */
> >>+ dev_notice(dev,
> >>+ "found %d context irq(s) but only %d required\n",
> >>+ smmu->num_context_irqs, smmu->num_context_banks);
> >>+ smmu->num_context_irqs = smmu->num_context_banks;
> >>+ }
> >I don't see the utility in the new message. Can you simplify with the patch
> >below on top? It's a bit weird that we only decide to ignore the extra irqs
> >after calling platform_get_irq() on them, but that seems to be harmless.
>
> Thanks. I will modify as suggested below and respin.
It's ok, I can make the change locally.
Will
next prev parent reply other threads:[~2018-07-25 11:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 17:53 [PATCH 0/3] Enable smmu support on sdm845 Vivek Gautam
2018-07-19 17:53 ` Vivek Gautam
2018-07-19 17:53 ` [PATCH 1/3] dts: arm64/sdm845: Add node for arm,mmu-500 Vivek Gautam
2018-07-19 17:53 ` Vivek Gautam
2018-07-19 23:08 ` Rob Herring
2018-07-19 23:08 ` Rob Herring
2018-07-20 8:26 ` Vivek Gautam
2018-07-20 8:26 ` Vivek Gautam
[not found] ` <20180719175356.14753-2-vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-08-10 22:18 ` Doug Anderson via iommu
2018-08-10 22:18 ` Doug Anderson
2018-08-10 22:18 ` Doug Anderson
2018-08-10 22:30 ` Doug Anderson
2018-08-10 22:30 ` Doug Anderson
[not found] ` <CAD=FV=XqBU0dc6smZsEssXAro5UMqqrgLudBQKqG1zznpg9cSA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-08-13 5:29 ` Vivek Gautam
2018-08-13 5:29 ` Vivek Gautam
2018-08-13 5:29 ` Vivek Gautam
2018-07-19 17:53 ` [PATCH 2/3] dts: arm64/sdm845: Add node for qcom,smmu-v2 Vivek Gautam
2018-07-19 17:53 ` Vivek Gautam
2018-07-19 17:53 ` [PATCH 3/3] iommu/arm-smmu: Error out only if not enough context interrupts Vivek Gautam
2018-07-19 17:53 ` Vivek Gautam
2018-07-24 8:36 ` Will Deacon
2018-07-24 8:36 ` Will Deacon
[not found] ` <20180724083633.GA19324-5wv7dgnIgG8@public.gmane.org>
2018-07-24 9:39 ` Vivek Gautam
2018-07-24 9:39 ` Vivek Gautam
2018-07-24 9:39 ` Vivek Gautam
[not found] ` <d6796a00-17da-c03e-ca7f-7a67139ad99a-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-07-25 11:57 ` Will Deacon [this message]
2018-07-25 11:57 ` Will Deacon
2018-07-25 11:57 ` Will Deacon
[not found] ` <20180725115729.GA31576-5wv7dgnIgG8@public.gmane.org>
2018-07-27 9:57 ` Vivek Gautam
2018-07-27 9:57 ` Vivek Gautam
2018-07-27 9:57 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725115729.GA31576@arm.com \
--to=will.deacon-5wv7dgnigg8@public.gmane.org \
--cc=andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.