From: Nicholas Piggin <npiggin@gmail.com>
To: linux-mm@kvack.org
Cc: linux-arch@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Nicholas Piggin <npiggin@gmail.com>
Subject: [RFC PATCH 1/4] mm: move tlb_table_flush to tlb_flush_mmu_free
Date: Thu, 26 Jul 2018 00:06:38 +1000 [thread overview]
Message-ID: <20180725140641.30372-2-npiggin@gmail.com> (raw)
In-Reply-To: <20180725140641.30372-1-npiggin@gmail.com>
There is no need to call this from tlb_flush_mmu_tlbonly, it
logically belongs with tlb_flush_mmu_free. This allows some
code consolidation with a subsequent fix.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
mm/memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 7206a634270b..bc053d5e9d41 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -245,9 +245,6 @@ static void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb)
tlb_flush(tlb);
mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end);
-#ifdef CONFIG_HAVE_RCU_TABLE_FREE
- tlb_table_flush(tlb);
-#endif
__tlb_reset_range(tlb);
}
@@ -255,6 +252,9 @@ static void tlb_flush_mmu_free(struct mmu_gather *tlb)
{
struct mmu_gather_batch *batch;
+#ifdef CONFIG_HAVE_RCU_TABLE_FREE
+ tlb_table_flush(tlb);
+#endif
for (batch = &tlb->local; batch && batch->nr; batch = batch->next) {
free_pages_and_swap_cache(batch->pages, batch->nr);
batch->nr = 0;
--
2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: linux-mm@kvack.org
Cc: Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] mm: move tlb_table_flush to tlb_flush_mmu_free
Date: Thu, 26 Jul 2018 00:06:38 +1000 [thread overview]
Message-ID: <20180725140641.30372-2-npiggin@gmail.com> (raw)
Message-ID: <20180725140638.bn86ndwCcFpfJkmSwfPUwf-PBQp7uhBPXEW5_bsfZQ0@z> (raw)
In-Reply-To: <20180725140641.30372-1-npiggin@gmail.com>
There is no need to call this from tlb_flush_mmu_tlbonly, it
logically belongs with tlb_flush_mmu_free. This allows some
code consolidation with a subsequent fix.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
mm/memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 7206a634270b..bc053d5e9d41 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -245,9 +245,6 @@ static void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb)
tlb_flush(tlb);
mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end);
-#ifdef CONFIG_HAVE_RCU_TABLE_FREE
- tlb_table_flush(tlb);
-#endif
__tlb_reset_range(tlb);
}
@@ -255,6 +252,9 @@ static void tlb_flush_mmu_free(struct mmu_gather *tlb)
{
struct mmu_gather_batch *batch;
+#ifdef CONFIG_HAVE_RCU_TABLE_FREE
+ tlb_table_flush(tlb);
+#endif
for (batch = &tlb->local; batch && batch->nr; batch = batch->next) {
free_pages_and_swap_cache(batch->pages, batch->nr);
batch->nr = 0;
--
2.17.0
WARNING: multiple messages have this Message-ID (diff)
From: npiggin@gmail.com (Nicholas Piggin)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 1/4] mm: move tlb_table_flush to tlb_flush_mmu_free
Date: Thu, 26 Jul 2018 00:06:38 +1000 [thread overview]
Message-ID: <20180725140641.30372-2-npiggin@gmail.com> (raw)
In-Reply-To: <20180725140641.30372-1-npiggin@gmail.com>
There is no need to call this from tlb_flush_mmu_tlbonly, it
logically belongs with tlb_flush_mmu_free. This allows some
code consolidation with a subsequent fix.
Signed-off-by: Nicholas Piggin <npiggin@gmail.com>
---
mm/memory.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/memory.c b/mm/memory.c
index 7206a634270b..bc053d5e9d41 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -245,9 +245,6 @@ static void tlb_flush_mmu_tlbonly(struct mmu_gather *tlb)
tlb_flush(tlb);
mmu_notifier_invalidate_range(tlb->mm, tlb->start, tlb->end);
-#ifdef CONFIG_HAVE_RCU_TABLE_FREE
- tlb_table_flush(tlb);
-#endif
__tlb_reset_range(tlb);
}
@@ -255,6 +252,9 @@ static void tlb_flush_mmu_free(struct mmu_gather *tlb)
{
struct mmu_gather_batch *batch;
+#ifdef CONFIG_HAVE_RCU_TABLE_FREE
+ tlb_table_flush(tlb);
+#endif
for (batch = &tlb->local; batch && batch->nr; batch = batch->next) {
free_pages_and_swap_cache(batch->pages, batch->nr);
batch->nr = 0;
--
2.17.0
next prev parent reply other threads:[~2018-07-25 14:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 14:06 [RFC PATCH 0/4] mm: mmu_gather changes to support explicit paging Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin [this message]
2018-07-25 14:06 ` [RFC PATCH 1/4] mm: move tlb_table_flush to tlb_flush_mmu_free Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` [RFC PATCH 2/4] mm: mmu_notifier fix for tlb_end_vma Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` [RFC PATCH 3/4] mm: allow arch to have tlb_flush caled on an empty TLB range Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` [RFC PATCH 4/4] powerpc/64s/radix: optimise TLB flush with precise TLB ranges in mmu_gather Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
2018-07-25 14:06 ` Nicholas Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180725140641.30372-2-npiggin@gmail.com \
--to=npiggin@gmail.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.