All of lore.kernel.org
 help / color / mirror / Atom feed
From: <jiang.biao2@zte.com.cn>
To: mhocko@kernel.org
Cc: akpm@linux-foundation.org, hannes@cmpxchg.org,
	hillf.zj@alibaba-inc.com, minchan@kernel.org,
	ying.huang@intel.com, mgorman@techsingularity.net,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	zhong.weidong@zte.com.cn
Subject: Re: [PATCH] mm/vmscan: fix page_freeze_refs in comment.
Date: Thu, 26 Jul 2018 14:59:28 +0800 (CST)	[thread overview]
Message-ID: <201807261459282984111@zte.com.cn> (raw)
In-Reply-To: <20180726061115.GR28386@dhcp22.suse.cz>


[-- Attachment #1.1: Type: text/plain, Size: 830 bytes --]

Hi,
> On Thu 26-07-18 07:34:17, Jiang Biao wrote:
>> page_freeze_refs has already been relplaced by page_ref_freeze, but
>> it is not modified in the comment.
> 
> Hmm
> $ git grep page_refs_freeze origin/master
> $
> 
> The same is the case in the linux-next tree. Which tree are you looking at?
I'm sorry, it should be *page_ref_freeze*, I misspelled the word.  
And I checked  again with git grep, found there are other places with the same
problem.
# git grep page_freeze_refs master
master:mm/ksm.c:         * however, it might mean that the page is under page_freeze_refs().
master:mm/memory-failure.c:      * that may make page_freeze_refs()/page_unfreeze_refs() mismatch.
master:mm/vmscan.c:     /* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */

I'll send v2 to fix all of these.
Thanks.

Jiang,
Regards

WARNING: multiple messages have this Message-ID (diff)
From: <jiang.biao2@zte.com.cn>
To: <mhocko@kernel.org>
Cc: <akpm@linux-foundation.org>, <hannes@cmpxchg.org>,
	<hillf.zj@alibaba-inc.com>, <minchan@kernel.org>,
	<ying.huang@intel.com>, <mgorman@techsingularity.net>,
	<linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	<zhong.weidong@zte.com.cn>
Subject: Re: [PATCH] mm/vmscan: fix page_freeze_refs in comment.
Date: Thu, 26 Jul 2018 14:59:28 +0800 (CST)	[thread overview]
Message-ID: <201807261459282984111@zte.com.cn> (raw)
In-Reply-To: <20180726061115.GR28386@dhcp22.suse.cz>


[-- Attachment #1.1: Type: text/plain, Size: 830 bytes --]

Hi,
> On Thu 26-07-18 07:34:17, Jiang Biao wrote:
>> page_freeze_refs has already been relplaced by page_ref_freeze, but
>> it is not modified in the comment.
> 
> Hmm
> $ git grep page_refs_freeze origin/master
> $
> 
> The same is the case in the linux-next tree. Which tree are you looking at?
I'm sorry, it should be *page_ref_freeze*, I misspelled the word.  
And I checked  again with git grep, found there are other places with the same
problem.
# git grep page_freeze_refs master
master:mm/ksm.c:         * however, it might mean that the page is under page_freeze_refs().
master:mm/memory-failure.c:      * that may make page_freeze_refs()/page_unfreeze_refs() mismatch.
master:mm/vmscan.c:     /* note: atomic_cmpxchg in page_freeze_refs provides the smp_rmb */

I'll send v2 to fix all of these.
Thanks.

Jiang,
Regards

  reply	other threads:[~2018-07-26  6:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-25 23:34 [PATCH] mm/vmscan: fix page_freeze_refs in comment Jiang Biao
2018-07-26  6:11 ` Michal Hocko
2018-07-26  6:59   ` jiang.biao2 [this message]
2018-07-26  6:59     ` jiang.biao2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201807261459282984111@zte.com.cn \
    --to=jiang.biao2@zte.com.cn \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=hillf.zj@alibaba-inc.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=minchan@kernel.org \
    --cc=ying.huang@intel.com \
    --cc=zhong.weidong@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.