All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver
Date: Thu, 26 Jul 2018 21:06:36 +0200	[thread overview]
Message-ID: <20180726190636.GG10686@lunn.ch> (raw)
In-Reply-To: <1532630184-29450-3-git-send-email-arun.parameswaran@broadcom.com>

On Thu, Jul 26, 2018 at 11:36:19AM -0700, Arun Parameswaran wrote:
> Modify the register offsets in the Broadcom iProc mdio mux to start
> from the top of the register address space.
> 
> Earlier the base address specified was from the middle of the block's
> register space. The base address will now point to the start of the
> mdio's address space. The offsets have been fixed to match this.

Hi Arun

Did you consider a change something like:

diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
index 0831b7142df7..2d53e609498c 100644
--- a/drivers/net/phy/mdio-mux-bcm-iproc.c
+++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
@@ -169,6 +169,12 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
        md->dev = &pdev->dev;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+       if (res->start & 0xfff != 0) {
+               dev_info(&pdev->dev, "Please upgrade your device tree blob.\n");
+               res->start &= ~0xfff;
+       }
+
        md->base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(md->base)) {
                dev_err(&pdev->dev, "failed to ioremap register\n");


	Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Arun Parameswaran <arun.parameswaran@broadcom.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
	Scott Branden <sbranden@broadcom.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver
Date: Thu, 26 Jul 2018 21:06:36 +0200	[thread overview]
Message-ID: <20180726190636.GG10686@lunn.ch> (raw)
In-Reply-To: <1532630184-29450-3-git-send-email-arun.parameswaran@broadcom.com>

On Thu, Jul 26, 2018 at 11:36:19AM -0700, Arun Parameswaran wrote:
> Modify the register offsets in the Broadcom iProc mdio mux to start
> from the top of the register address space.
> 
> Earlier the base address specified was from the middle of the block's
> register space. The base address will now point to the start of the
> mdio's address space. The offsets have been fixed to match this.

Hi Arun

Did you consider a change something like:

diff --git a/drivers/net/phy/mdio-mux-bcm-iproc.c b/drivers/net/phy/mdio-mux-bcm-iproc.c
index 0831b7142df7..2d53e609498c 100644
--- a/drivers/net/phy/mdio-mux-bcm-iproc.c
+++ b/drivers/net/phy/mdio-mux-bcm-iproc.c
@@ -169,6 +169,12 @@ static int mdio_mux_iproc_probe(struct platform_device *pdev)
        md->dev = &pdev->dev;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+
+       if (res->start & 0xfff != 0) {
+               dev_info(&pdev->dev, "Please upgrade your device tree blob.\n");
+               res->start &= ~0xfff;
+       }
+
        md->base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(md->base)) {
                dev_err(&pdev->dev, "failed to ioremap register\n");


	Andrew

  reply	other threads:[~2018-07-26 19:06 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-26 18:36 [PATCH 0/7] Add clock config and pm support to bcm iProc mdio mux Arun Parameswaran
2018-07-26 18:36 ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 1/7] dt-bindings: net: Fix Broadcom iProc mdio mux driver base address Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 19:01   ` Andrew Lunn
2018-07-26 19:01     ` Andrew Lunn
2018-07-26 19:15     ` Arun Parameswaran
2018-07-26 19:15       ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 2/7] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 19:06   ` Andrew Lunn [this message]
2018-07-26 19:06     ` Andrew Lunn
2018-07-26 19:16     ` Arun Parameswaran
2018-07-26 19:16       ` Arun Parameswaran
2018-07-26 19:25       ` Ray Jui
2018-07-26 19:25         ` Ray Jui
2018-07-26 19:29         ` Andrew Lunn
2018-07-26 19:29           ` Andrew Lunn
2018-07-26 18:36 ` [PATCH 3/7] arm64: dts: Fix the base address of the Broadcom iProc mdio mux Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 4/7] dt-bindings: net: Add clock handle to " Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 5/7] net: phy: Add support to configure clock in " Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 19:13   ` Andrew Lunn
2018-07-26 19:13     ` Andrew Lunn
2018-07-26 19:20     ` Arun Parameswaran
2018-07-26 19:20       ` Arun Parameswaran
2018-07-26 19:26   ` Andrew Lunn
2018-07-26 19:26     ` Andrew Lunn
2018-07-26 20:00     ` Arun Parameswaran
2018-07-26 20:00       ` Arun Parameswaran
2018-07-26 18:36 ` [PATCH 6/7] net: phy: Add pm support to Broadcom iProc mdio mux driver Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 19:16   ` Andrew Lunn
2018-07-26 19:16     ` Andrew Lunn
2018-07-26 18:36 ` [PATCH 7/7] net: phy: Add pm support for scan ctrl register to bcm mdio mux Arun Parameswaran
2018-07-26 18:36   ` Arun Parameswaran
2018-07-26 19:20   ` Andrew Lunn
2018-07-26 19:20     ` Andrew Lunn
2018-07-26 19:33     ` Arun Parameswaran
2018-07-26 19:33       ` Arun Parameswaran
2018-07-26 19:36       ` Andrew Lunn
2018-07-26 19:36         ` Andrew Lunn
2018-07-26 19:51         ` Arun Parameswaran
2018-07-26 19:51           ` Arun Parameswaran
2018-07-26 18:52 ` [PATCH 0/7] Add clock config and pm support to bcm iProc " Andrew Lunn
2018-07-26 18:52   ` Andrew Lunn
2018-07-26 19:00   ` Arun Parameswaran
2018-07-26 19:00     ` Arun Parameswaran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180726190636.GG10686@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.