From: Ben Dooks <ben@trinity.fluff.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
jonathanh@nvidia.com
Subject: Re: [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback
Date: Mon, 30 Jul 2018 10:04:42 +0100 [thread overview]
Message-ID: <20180730090441.GE28143@trinity.fluff.org> (raw)
In-Reply-To: <20180730084908.GB5789@sirena.org.uk>
On Mon, Jul 30, 2018 at 09:49:08AM +0100, Mark Brown wrote:
> On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote:
> > From: Edward Cragg <edward.cragg@codethink.co.uk>
> >
> > Add a callback to configure TDM settings for the Tegra30
> > I2S ASoC 'platform' driver.
> >
> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
>
> This says it was britten by Edward but there's a signoff from Ben before
> his?
Editing accdient, I was originally going to submit this series.
> > + dev_dbg(dai->dev, "%s: setting TDM: tx_mask: 0x%08x rx_mask: 0x%08x"
> > + "slots: 0x%08x width: %d\n",
> > + __func__, tx_mask, rx_mask, slots, slot_width);
>
> Please don't split log messages over lines, it makes it harder to grep
> for them. Just use a long line.
>
> I'm also not seeing any validation of the parameters?
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
WARNING: multiple messages have this Message-ID (diff)
From: Ben Dooks <ben@trinity.fluff.org>
To: Mark Brown <broonie@kernel.org>
Cc: Jorge Sanjuan <jorge.sanjuan@codethink.co.uk>,
linux-kernel@lists.codethink.co.uk, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
jonathanh@nvidia.com
Subject: Re: [alsa-devel] [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback
Date: Mon, 30 Jul 2018 10:04:42 +0100 [thread overview]
Message-ID: <20180730090441.GE28143@trinity.fluff.org> (raw)
In-Reply-To: <20180730084908.GB5789@sirena.org.uk>
On Mon, Jul 30, 2018 at 09:49:08AM +0100, Mark Brown wrote:
> On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote:
> > From: Edward Cragg <edward.cragg@codethink.co.uk>
> >
> > Add a callback to configure TDM settings for the Tegra30
> > I2S ASoC 'platform' driver.
> >
> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> > Signed-off-by: Edward Cragg <edward.cragg@codethink.co.uk>
>
> This says it was britten by Edward but there's a signoff from Ben before
> his?
Editing accdient, I was originally going to submit this series.
> > + dev_dbg(dai->dev, "%s: setting TDM: tx_mask: 0x%08x rx_mask: 0x%08x"
> > + "slots: 0x%08x width: %d\n",
> > + __func__, tx_mask, rx_mask, slots, slot_width);
>
> Please don't split log messages over lines, it makes it harder to grep
> for them. Just use a long line.
>
> I'm also not seeing any validation of the parameters?
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2018-07-30 9:04 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 12:59 [PATCH 0/4] ASoC: Tegra30 TDM support Jorge Sanjuan
2018-07-27 12:59 ` Jorge Sanjuan
2018-07-27 12:59 ` [PATCH 1/4] ASoC: tegra: i2s: Fix typo/broken macro Jorge Sanjuan
2018-07-27 12:59 ` Jorge Sanjuan
2018-07-30 8:58 ` Jon Hunter
2018-07-30 8:58 ` Jon Hunter
2018-07-30 11:04 ` Applied "ASoC: tegra: i2s: Fix typo/broken macro" to the asoc tree Mark Brown
2018-07-30 11:04 ` Mark Brown
2018-07-30 11:04 ` Mark Brown
2018-07-27 12:59 ` [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback Jorge Sanjuan
2018-07-30 8:49 ` Mark Brown
2018-07-30 8:49 ` Mark Brown
2018-07-30 9:04 ` Ben Dooks [this message]
2018-07-30 9:04 ` [alsa-devel] " Ben Dooks
2018-07-30 9:31 ` Jon Hunter
2018-07-30 9:31 ` Jon Hunter
2018-07-30 10:18 ` Mark Brown
2018-07-30 10:18 ` Mark Brown
2018-07-30 14:04 ` Jon Hunter
2018-07-30 14:04 ` Jon Hunter
2018-07-30 14:15 ` Jon Hunter
2018-07-30 14:15 ` Jon Hunter
2018-07-30 15:07 ` Mark Brown
2018-07-30 15:07 ` Mark Brown
2018-07-30 17:39 ` [Linux-kernel] " Ben Dooks
2018-07-30 17:39 ` Ben Dooks
2018-07-27 12:59 ` [PATCH 3/4] ASoC: tegra: Allow 32-bit and 24-bit samples Jorge Sanjuan
2018-07-27 12:59 ` Jorge Sanjuan
2018-07-28 22:28 ` kbuild test robot
2018-07-28 22:28 ` kbuild test robot
2018-07-29 9:21 ` Ben Dooks
2018-07-29 9:21 ` [Linux-kernel] " Ben Dooks
2018-07-27 12:59 ` [PATCH 4/4] ASoC: tegra: i2s: Add support for more than 2 channels Jorge Sanjuan
2018-07-30 9:46 ` Jon Hunter
2018-07-30 9:46 ` Jon Hunter
2018-07-30 10:21 ` Mark Brown
2018-07-30 17:22 ` [PATCH 0/4] ASoC: Tegra30 TDM support Ben Dooks
2018-07-30 17:22 ` [Linux-kernel] " Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730090441.GE28143@trinity.fluff.org \
--to=ben@trinity.fluff.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=jorge.sanjuan@codethink.co.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@lists.codethink.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.