From: Mark Brown <broonie@kernel.org>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: alsa-devel@alsa-project.org, anish kumar <yesanishhere@gmail.com>
Subject: Re: [PATCH v0 1/3] ASoC: max9867: Take device out of shutdown
Date: Mon, 30 Jul 2018 10:23:46 +0100 [thread overview]
Message-ID: <20180730092346.GC5789@sirena.org.uk> (raw)
In-Reply-To: <20180728154226.GB9665@lenoch>
[-- Attachment #1.1: Type: text/plain, Size: 423 bytes --]
On Sat, Jul 28, 2018 at 05:42:26PM +0200, Ladislav Michl wrote:
> Move device enable to probe function to make line bypass
> and mic sidetone work. Doing that from prepare callback
> lets only DAC to produce output.
> While here move suspend and resume functions to the more
> common place.
It'd be better to move this to DAPM so that the device is enabled only
when one of the paths in use - do it from set_bias_level().
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-07-30 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 15:41 [PATCH v0 0/3] ASoC: max9867: driver update Ladislav Michl
2018-07-28 15:42 ` [PATCH v0 1/3] ASoC: max9867: Take device out of shutdown Ladislav Michl
2018-07-30 9:23 ` Mark Brown [this message]
2018-07-28 15:43 ` [PATCH v0 2/3] ASoC: max9867: Calculate LRCLK divider Ladislav Michl
2018-07-28 15:44 ` [PATCH v0 3/3] ASoC: max9867: Fix volume controls Ladislav Michl
2018-07-30 10:11 ` Mark Brown
2018-07-30 10:45 ` Ladislav Michl
2018-07-30 10:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730092346.GC5789@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ladis@linux-mips.org \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.