From: Mark Brown <broonie@kernel.org>
To: Ladislav Michl <ladis@linux-mips.org>
Cc: alsa-devel@alsa-project.org, anish kumar <yesanishhere@gmail.com>
Subject: Re: [PATCH v0 3/3] ASoC: max9867: Fix volume controls
Date: Mon, 30 Jul 2018 11:11:15 +0100 [thread overview]
Message-ID: <20180730101115.GD5789@sirena.org.uk> (raw)
In-Reply-To: <20180728154415.GD9665@lenoch>
[-- Attachment #1.1: Type: text/plain, Size: 740 bytes --]
On Sat, Jul 28, 2018 at 05:44:15PM +0200, Ladislav Michl wrote:
> Build proper audio paths and fix volume controls to match datasheet.
This sounds like it should be split up into separate patches for at
least the routing and volume control stuff. It also needs a bit of a
better changelog as I'm not sure what the issues with the volume
controls were or what was improper about the old audio paths.
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
> I'm still unsure about control names, please see yet unaswered mail
> here: https://www.spinics.net/lists/alsa-devel/msg80006.html
Always CC maintainers on mails - you really shouldn't rely on anyone
seeing anything that only goes to the lists, they're quite high volume.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-07-30 10:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 15:41 [PATCH v0 0/3] ASoC: max9867: driver update Ladislav Michl
2018-07-28 15:42 ` [PATCH v0 1/3] ASoC: max9867: Take device out of shutdown Ladislav Michl
2018-07-30 9:23 ` Mark Brown
2018-07-28 15:43 ` [PATCH v0 2/3] ASoC: max9867: Calculate LRCLK divider Ladislav Michl
2018-07-28 15:44 ` [PATCH v0 3/3] ASoC: max9867: Fix volume controls Ladislav Michl
2018-07-30 10:11 ` Mark Brown [this message]
2018-07-30 10:45 ` Ladislav Michl
2018-07-30 10:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730101115.GD5789@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ladis@linux-mips.org \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.