[Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Peter Maydell]

The tests in tests/vm/ seem to make some attempt to cope with the
host system not allowing the user to use KVM, but it doesn't quite
work. The problem is that tests/vm/basevm.py always uses "-cpu host"
in the QEMU options it uses to run the VM, and that only works if
KVM is enabled. If the user can't run KVM then we correctly avoid
passing it "-enable-kvm" but then QEMU doesn't run because "-cpu host"
isn't supported...

I guess the right fix here is to use "-cpu max" ?

thanks
-- PMM

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Daniel P. Berrangé]

On Mon, Jul 30, 2018 at 02:23:50PM +0100, Peter Maydell wrote:
> The tests in tests/vm/ seem to make some attempt to cope with the
> host system not allowing the user to use KVM, but it doesn't quite
> work. The problem is that tests/vm/basevm.py always uses "-cpu host"
> in the QEMU options it uses to run the VM, and that only works if
> KVM is enabled. If the user can't run KVM then we correctly avoid
> passing it "-enable-kvm" but then QEMU doesn't run because "-cpu host"
> isn't supported...
> 
> I guess the right fix here is to use "-cpu max" ?

Yes, sounds like exactly the kind of scenario that 'max' was intended
to support.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Peter Maydell]

On 30 July 2018 at 14:23, Peter Maydell <peter.maydell@linaro.org> wrote:
> The tests in tests/vm/ seem to make some attempt to cope with the
> host system not allowing the user to use KVM, but it doesn't quite
> work.

Also, passing V=1 to the outer make command like:
 make vm-build-freebsd J=16 V=1
isn't propagated through to the VM: test output looks like
  GTESTER check-qtest-aarch64
  GTESTER check-qtest-alpha
instead of the proper verbose output with a line per subtest.

thanks
-- PMM

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Peter Maydell]

On 30 July 2018 at 14:36, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 30 July 2018 at 14:23, Peter Maydell <peter.maydell@linaro.org> wrote:
>> The tests in tests/vm/ seem to make some attempt to cope with the
>> host system not allowing the user to use KVM, but it doesn't quite
>> work.
>
> Also, passing V=1 to the outer make command like:
>  make vm-build-freebsd J=16 V=1
> isn't propagated through to the VM: test output looks like
>   GTESTER check-qtest-aarch64
>   GTESTER check-qtest-alpha
> instead of the proper verbose output with a line per subtest.

Nor is the J=16 option passed through to "make check":
tests/vm/freebsd &c have
        gmake -j{jobs};
        gmake check;

(This is presumably also where they should be passing through
the V=1 flag.)

thanks
-- PMM

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Peter Maydell]

On 30 July 2018 at 14:40, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 30 July 2018 at 14:36, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 30 July 2018 at 14:23, Peter Maydell <peter.maydell@linaro.org> wrote:
>>> The tests in tests/vm/ seem to make some attempt to cope with the
>>> host system not allowing the user to use KVM, but it doesn't quite
>>> work.
>>
>> Also, passing V=1 to the outer make command like:
>>  make vm-build-freebsd J=16 V=1
>> isn't propagated through to the VM: test output looks like
>>   GTESTER check-qtest-aarch64
>>   GTESTER check-qtest-alpha
>> instead of the proper verbose output with a line per subtest.
>
> Nor is the J=16 option passed through to "make check":

Patches for these things on the way, once I've completed a test run.

thanks
-- PMM

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Fam Zheng]

On Mon, 07/30 16:20, Peter Maydell wrote:
> On 30 July 2018 at 14:40, Peter Maydell <peter.maydell@linaro.org> wrote:
> > On 30 July 2018 at 14:36, Peter Maydell <peter.maydell@linaro.org> wrote:
> >> On 30 July 2018 at 14:23, Peter Maydell <peter.maydell@linaro.org> wrote:
> >>> The tests in tests/vm/ seem to make some attempt to cope with the
> >>> host system not allowing the user to use KVM, but it doesn't quite
> >>> work.
> >>
> >> Also, passing V=1 to the outer make command like:
> >>  make vm-build-freebsd J=16 V=1
> >> isn't propagated through to the VM: test output looks like
> >>   GTESTER check-qtest-aarch64
> >>   GTESTER check-qtest-alpha
> >> instead of the proper verbose output with a line per subtest.
> >
> > Nor is the J=16 option passed through to "make check":
> 
> Patches for these things on the way, once I've completed a test run.

All good catches! Looking forward to the fixes. Thanks.

Fam

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Philippe Mathieu-Daudé]

Hi Peter,

On 07/30/2018 10:23 AM, Peter Maydell wrote:
> The tests in tests/vm/ seem to make some attempt to cope with the
> host system not allowing the user to use KVM, but it doesn't quite
> work. The problem is that tests/vm/basevm.py always uses "-cpu host"
> in the QEMU options it uses to run the VM, and that only works if
> KVM is enabled. If the user can't run KVM then we correctly avoid
> passing it "-enable-kvm" but then QEMU doesn't run because "-cpu host"
> isn't supported...
> 
> I guess the right fix here is to use "-cpu max" ?

I think this is the issue I intended to address in this series:

http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg03411.html
"tests/vm: Improvements when KVM is not available"
->
"tests/vm: Use 'host' cpu when KVM is available, else default to 'max'"

Re: [Qemu-devel] 'make vm-build-freebsd' &c don't work if KVM isn't enabled

[Peter Maydell]

On 2 August 2018 at 20:13, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Peter,
>
> On 07/30/2018 10:23 AM, Peter Maydell wrote:
>> The tests in tests/vm/ seem to make some attempt to cope with the
>> host system not allowing the user to use KVM, but it doesn't quite
>> work. The problem is that tests/vm/basevm.py always uses "-cpu host"
>> in the QEMU options it uses to run the VM, and that only works if
>> KVM is enabled. If the user can't run KVM then we correctly avoid
>> passing it "-enable-kvm" but then QEMU doesn't run because "-cpu host"
>> isn't supported...
>>
>> I guess the right fix here is to use "-cpu max" ?
>
> I think this is the issue I intended to address in this series:
>
> http://lists.nongnu.org/archive/html/qemu-devel/2018-07/msg03411.html
> "tests/vm: Improvements when KVM is not available"
> ->
> "tests/vm: Use 'host' cpu when KVM is available, else default to 'max'"

Just using "max" seems more straightforward, since the point
is that it works everywhere.

I thought I'd sent my tests/vm series out earlier this week,
but I must have managed to only do the dry-run or something --
I'll send them tomorrow.

thanks
-- PMM