* [PATCH 1/4] rsi: fix for low throughput issue
2018-07-05 12:38 [PATCH 0/4] rsi driver common fixes Sushant Kumar Mishra
@ 2018-07-05 12:38 ` Sushant Kumar Mishra
2018-07-31 7:15 ` Kalle Valo
2018-07-05 12:38 ` [PATCH 2/4] rsi: fix for 40MHZ connection issue Sushant Kumar Mishra
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Sushant Kumar Mishra @ 2018-07-05 12:38 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, Siva Rebbagondla, Sanjay Kumar Konduri,
Sushant Kumar Mishra
From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
observed low throughput rates during verification. This is because, QoS
enable flag is overridden by sequence number in the data descriptor frame.
Hence, added the fix for same.
Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Signed-off-by: Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
---
drivers/net/wireless/rsi/rsi_91x_hal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_hal.c b/drivers/net/wireless/rsi/rsi_91x_hal.c
index 0761e61..533d9e9 100644
--- a/drivers/net/wireless/rsi/rsi_91x_hal.c
+++ b/drivers/net/wireless/rsi/rsi_91x_hal.c
@@ -246,7 +246,7 @@ int rsi_prepare_data_desc(struct rsi_common *common, struct sk_buff *skb)
}
}
- data_desc->mac_flags = cpu_to_le16(seq_num & 0xfff);
+ data_desc->mac_flags |= cpu_to_le16(seq_num & 0xfff);
data_desc->qid_tid = ((skb->priority & 0xf) |
((tx_params->tid & 0xf) << 4));
data_desc->sta_id = tx_params->sta_id;
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/4] rsi: fix for 40MHZ connection issue.
2018-07-05 12:38 [PATCH 0/4] rsi driver common fixes Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 1/4] rsi: fix for low throughput issue Sushant Kumar Mishra
@ 2018-07-05 12:38 ` Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 3/4] rsi: fix for WoWLAN wakeup in security mode Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 4/4] rsi: optimize virtual interfaces Sushant Kumar Mishra
3 siblings, 0 replies; 6+ messages in thread
From: Sushant Kumar Mishra @ 2018-07-05 12:38 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, Siva Rebbagondla, Sanjay Kumar Konduri,
Ganapathi Raju, Sushant Kumar Mishra
From: Ganapathi Raju <ganapathi.kondraju@redpinesignals.com>
Radio capabilities packet is not prepared properly for 40MHZ case,
ppe_ack_rate is a two byte variable which is initialized wrongly,
hence we are unable to connect, resolved by assigning it properly.
Signed-off-by: Ganapathi Raju <ganapathi.kondraju@redpinesignals.com>
Signed-off-by: Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 21 +++++++++------------
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index d0e5937..8280f32 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -334,20 +334,17 @@ static int rsi_load_radio_caps(struct rsi_common *common)
struct ieee80211_conf *conf = &hw->conf;
if (conf_is_ht40_plus(conf)) {
- radio_caps->radio_cfg_info =
- RSI_CMDDESC_LOWER_20_ENABLE;
- radio_caps->radio_info =
- RSI_CMDDESC_LOWER_20_ENABLE;
+ radio_caps->ppe_ack_rate =
+ cpu_to_le16(LOWER_20_ENABLE |
+ (LOWER_20_ENABLE >> 12));
} else if (conf_is_ht40_minus(conf)) {
- radio_caps->radio_cfg_info =
- RSI_CMDDESC_UPPER_20_ENABLE;
- radio_caps->radio_info =
- RSI_CMDDESC_UPPER_20_ENABLE;
+ radio_caps->ppe_ack_rate =
+ cpu_to_le16(UPPER_20_ENABLE |
+ (UPPER_20_ENABLE >> 12));
} else {
- radio_caps->radio_cfg_info =
- RSI_CMDDESC_40MHZ;
- radio_caps->radio_info =
- RSI_CMDDESC_FULL_40_ENABLE;
+ radio_caps->ppe_ack_rate =
+ cpu_to_le16((BW_40MHZ << 12) |
+ FULL40M_ENABLE);
}
}
}
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 3/4] rsi: fix for WoWLAN wakeup in security mode.
2018-07-05 12:38 [PATCH 0/4] rsi driver common fixes Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 1/4] rsi: fix for low throughput issue Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 2/4] rsi: fix for 40MHZ connection issue Sushant Kumar Mishra
@ 2018-07-05 12:38 ` Sushant Kumar Mishra
2018-07-05 12:38 ` [PATCH 4/4] rsi: optimize virtual interfaces Sushant Kumar Mishra
3 siblings, 0 replies; 6+ messages in thread
From: Sushant Kumar Mishra @ 2018-07-05 12:38 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, Siva Rebbagondla, Sanjay Kumar Konduri,
Sushant Kumar Mishra
From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
System is unable to wake-up through magic-packet in secured connections.
Because key descriptor is getting corrupted and firmware is unable to
decrypt the magic packet. Fixed the issue by properly preparing it
before sending it to firmware.
Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Signed-off-by: Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index 8280f32..1095df7 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -746,7 +746,7 @@ int rsi_hal_load_key(struct rsi_common *common,
key_descriptor |= RSI_CIPHER_TKIP;
}
key_descriptor |= RSI_PROTECT_DATA_FRAMES;
- key_descriptor |= ((key_id << RSI_KEY_ID_OFFSET) & RSI_KEY_ID_MASK);
+ key_descriptor |= (key_id << RSI_KEY_ID_OFFSET);
rsi_set_len_qno(&set_key->desc_dword0.len_qno,
(frame_len - FRAME_DESC_SZ), RSI_WIFI_MGMT_Q);
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 4/4] rsi: optimize virtual interfaces
2018-07-05 12:38 [PATCH 0/4] rsi driver common fixes Sushant Kumar Mishra
` (2 preceding siblings ...)
2018-07-05 12:38 ` [PATCH 3/4] rsi: fix for WoWLAN wakeup in security mode Sushant Kumar Mishra
@ 2018-07-05 12:38 ` Sushant Kumar Mishra
3 siblings, 0 replies; 6+ messages in thread
From: Sushant Kumar Mishra @ 2018-07-05 12:38 UTC (permalink / raw)
To: Kalle Valo
Cc: linux-wireless, Siva Rebbagondla, Sanjay Kumar Konduri,
Sushant Kumar Mishra
From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Due to multiple calls of add interface routine, vif is getting duplicated
and at certain instance, we are out of vifs, causing the driver to behave
abnormal.
Fix: Every vif has a unique mac-id, when we got a vif with same mac-id as
the previous id's, we will override the respective vif.
Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Signed-off-by: Sushant Kumar Mishra <sushant.mishra@redpinesignals.com>
---
drivers/net/wireless/rsi/rsi_91x_mac80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/rsi/rsi_91x_mac80211.c b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
index 2ca7464..4e510cb 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mac80211.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mac80211.c
@@ -416,7 +416,8 @@ static int rsi_mac80211_add_interface(struct ieee80211_hw *hw,
/* Get free vap index */
for (i = 0; i < RSI_MAX_VIFS; i++) {
- if (!adapter->vifs[i]) {
+ if (!adapter->vifs[i] ||
+ !memcmp(vif->addr, adapter->vifs[i]->addr, ETH_ALEN)) {
vap_idx = i;
break;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread