From: Joerg Roedel <jroedel@suse.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: call dma_debug_add_bus for pci_bus_type in common code
Date: Tue, 31 Jul 2018 09:36:02 +0200 [thread overview]
Message-ID: <20180731073602.jbbcr4twd2gnkfoc@suse.de> (raw)
In-Reply-To: <20180730211713.GA45322@bhelgaas-glaptop.roam.corp.google.com>
On Mon, Jul 30, 2018 at 04:17:13PM -0500, Bjorn Helgaas wrote:
> [+cc Joerg]
>
> On Mon, Jul 30, 2018 at 09:38:42AM +0200, Christoph Hellwig wrote:
> > There is nothing arch specific about PCI or dma-debug, so move this
> > call to common code just after registering the bus type.
>
> I assume that previously, even if the user set CONFIG_DMA_API_DEBUG=y
> we only got PCI DMA debug on powerpc, sh, and x86. And after this
> patch, we'll get PCI DMA debug on *all* arches?
>
> If that's true, I'll add a comment to that effect to the commitlog
> since that new functionality might be of interest to other arches.
There should be implicit support for dma-debug for all arches that use
the generic dma_ops code. The dma_debug_add_bus() function just adds the
reporting of pending dma-allocations on driver-unload for a device.
Regards,
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <jroedel@suse.de>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>,
linux-pci@vger.kernel.org, iommu@lists.linux-foundation.org,
linuxppc-dev@lists.ozlabs.org, x86@kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: call dma_debug_add_bus for pci_bus_type in common code
Date: Tue, 31 Jul 2018 07:36:02 +0000 [thread overview]
Message-ID: <20180731073602.jbbcr4twd2gnkfoc@suse.de> (raw)
In-Reply-To: <20180730211713.GA45322@bhelgaas-glaptop.roam.corp.google.com>
On Mon, Jul 30, 2018 at 04:17:13PM -0500, Bjorn Helgaas wrote:
> [+cc Joerg]
>
> On Mon, Jul 30, 2018 at 09:38:42AM +0200, Christoph Hellwig wrote:
> > There is nothing arch specific about PCI or dma-debug, so move this
> > call to common code just after registering the bus type.
>
> I assume that previously, even if the user set CONFIG_DMA_API_DEBUG=y
> we only got PCI DMA debug on powerpc, sh, and x86. And after this
> patch, we'll get PCI DMA debug on *all* arches?
>
> If that's true, I'll add a comment to that effect to the commitlog
> since that new functionality might be of interest to other arches.
There should be implicit support for dma-debug for all arches that use
the generic dma_ops code. The dma_debug_add_bus() function just adds the
reporting of pending dma-allocations on driver-unload for a device.
Regards,
Joerg
next prev parent reply other threads:[~2018-07-31 7:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 7:38 [PATCH] PCI: call dma_debug_add_bus for pci_bus_type in common code Christoph Hellwig
2018-07-30 7:38 ` Christoph Hellwig
[not found] ` <20180730073842.16092-1-hch-jcswGhMUV9g@public.gmane.org>
2018-07-30 11:55 ` Thomas Gleixner
2018-07-30 11:55 ` Thomas Gleixner
2018-07-30 11:55 ` Thomas Gleixner
2018-07-30 21:17 ` Bjorn Helgaas
2018-07-30 21:17 ` Bjorn Helgaas
2018-07-30 21:17 ` Bjorn Helgaas
2018-07-31 7:36 ` Joerg Roedel [this message]
2018-07-31 7:36 ` Joerg Roedel
2018-07-31 8:07 ` Christoph Hellwig
2018-07-31 8:07 ` Christoph Hellwig
2018-07-31 9:34 ` Michael Ellerman
2018-07-31 9:34 ` Michael Ellerman
2018-07-31 10:54 ` Bjorn Helgaas
2018-07-31 10:54 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180731073602.jbbcr4twd2gnkfoc@suse.de \
--to=jroedel@suse.de \
--cc=hch@lst.de \
--cc=helgaas@kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.