All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Alexei Colin <acolin@isi.edu>
Cc: Alexandre Bounine <alex.bou9@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	John Paul Walters <jwalters@isi.edu>,
	linux-kernel@vger.kernel.org, x86@kernel.org,
	linuxppc-dev@lists.ozlabs.org, linux-mips@linux-mips.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESEND PATCH 5/6] arm: enable RapidIO menu in Kconfig
Date: Tue, 31 Jul 2018 16:36:55 +0100	[thread overview]
Message-ID: <20180731153655.GM17271@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180731142954.30345-6-acolin@isi.edu>

On Tue, Jul 31, 2018 at 10:29:53AM -0400, Alexei Colin wrote:
> Platforms with a PCI bus will be offered the RapidIO menu since they may
> be want support for a RapidIO PCI device. Platforms without a PCI bus
> that might include a RapidIO IP block will need to "select HAS_RAPIDIO"
> in the platform-/machine-specific "config ARCH_*" Kconfig entry.
> 
> Tested that kernel builds for ARM with the RapidIO subsystem and switch
> drivers enabled.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: John Paul Walters <jwalters@isi.edu>
> Cc: linux-kernel@vger.kernel.org
> Cc: x86@kernel.org
> Cc: linuxppc-dev@lists.ozlabs.org
> Cc: linux-mips@linux-mips.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Alexei Colin <acolin@isi.edu>
> ---
>  arch/arm/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index afe350e5e3d9..602a61324890 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1278,6 +1278,8 @@ config PCI_HOST_ITE8152
>  
>  source "drivers/pci/Kconfig"
>  
> +source "drivers/rapidio/Kconfig"
> +
>  source "drivers/pcmcia/Kconfig"

Why not place the new Kconfig file after pcmcia?  That way, it is in
a consistent position wrt architectures such as powerpc, and it is
also in alphabetical order.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up

WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 5/6] arm: enable RapidIO menu in Kconfig
Date: Tue, 31 Jul 2018 16:36:55 +0100	[thread overview]
Message-ID: <20180731153655.GM17271@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20180731142954.30345-6-acolin@isi.edu>

On Tue, Jul 31, 2018 at 10:29:53AM -0400, Alexei Colin wrote:
> Platforms with a PCI bus will be offered the RapidIO menu since they may
> be want support for a RapidIO PCI device. Platforms without a PCI bus
> that might include a RapidIO IP block will need to "select HAS_RAPIDIO"
> in the platform-/machine-specific "config ARCH_*" Kconfig entry.
> 
> Tested that kernel builds for ARM with the RapidIO subsystem and switch
> drivers enabled.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: John Paul Walters <jwalters@isi.edu>
> Cc: linux-kernel at vger.kernel.org
> Cc: x86 at kernel.org
> Cc: linuxppc-dev at lists.ozlabs.org
> Cc: linux-mips at linux-mips.org
> Cc: linux-arm-kernel at lists.infradead.org
> Signed-off-by: Alexei Colin <acolin@isi.edu>
> ---
>  arch/arm/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index afe350e5e3d9..602a61324890 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1278,6 +1278,8 @@ config PCI_HOST_ITE8152
>  
>  source "drivers/pci/Kconfig"
>  
> +source "drivers/rapidio/Kconfig"
> +
>  source "drivers/pcmcia/Kconfig"

Why not place the new Kconfig file after pcmcia?  That way, it is in
a consistent position wrt architectures such as powerpc, and it is
also in alphabetical order.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 13.8Mbps down 630kbps up
According to speedtest.net: 13Mbps down 490kbps up

  reply	other threads:[~2018-07-31 15:37 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-31 14:29 [RESEND PATCH 0/6] rapidio: move Kconfig menu definition to subsystem Alexei Colin
2018-07-31 14:29 ` Alexei Colin
2018-07-31 14:29 ` [RESEND PATCH 1/6] rapidio: define top Kconfig menu in driver subtree Alexei Colin
2018-07-31 14:29   ` Alexei Colin
2018-07-31 15:09   ` Alexander Sverdlin
2018-07-31 15:09     ` Alexander Sverdlin
2018-07-31 15:09     ` Alexander Sverdlin
2018-07-31 15:29   ` Russell King - ARM Linux
2018-07-31 15:29     ` Russell King - ARM Linux
2018-07-31 14:29 ` [RESEND PATCH 2/6] x86: factor out RapidIO Kconfig menu Alexei Colin
2018-07-31 14:29   ` Alexei Colin
2018-07-31 14:29 ` [RESEND PATCH 3/6] powerpc: factor out RapidIO Kconfig menu entry Alexei Colin
2018-07-31 14:29   ` Alexei Colin
2018-07-31 14:29 ` [RESEND PATCH 4/6] mips: factor out RapidIO Kconfig entry Alexei Colin
2018-07-31 14:29   ` Alexei Colin
2018-07-31 14:29 ` [RESEND PATCH 5/6] arm: enable RapidIO menu in Kconfig Alexei Colin
2018-07-31 14:29   ` Alexei Colin
2018-07-31 15:36   ` Russell King - ARM Linux [this message]
2018-07-31 15:36     ` Russell King - ARM Linux
2018-07-31 14:29 ` [RESEND PATCH 6/6] arm64: " Alexei Colin
2018-07-31 14:29   ` Alexei Colin
2018-08-01  9:54   ` Christoph Hellwig
2018-08-01  9:54     ` Christoph Hellwig
2018-08-01 13:15     ` Alex Bounine
2018-08-01 13:15       ` Alex Bounine
2018-08-02  8:57       ` Geert Uytterhoeven
2018-08-02  8:57         ` Geert Uytterhoeven
2018-08-02 13:45         ` Alexei Colin
2018-08-02 13:45           ` Alexei Colin
2018-08-02 13:54           ` Christoph Hellwig
2018-08-02 13:54             ` Christoph Hellwig
2018-08-02 14:00             ` Alexei Colin
2018-08-02 14:00               ` Alexei Colin
2018-08-02 14:16               ` Alex Bounine
2018-08-02 14:16                 ` Alex Bounine
2018-07-31 15:12 ` [RESEND PATCH 0/6] rapidio: move Kconfig menu definition to subsystem Alex Bounine
2018-07-31 15:12   ` Alex Bounine
2018-07-31 15:59 ` Russell King - ARM Linux
2018-07-31 15:59   ` Russell King - ARM Linux
2018-07-31 18:21   ` Alex Bounine
2018-07-31 18:21     ` Alex Bounine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731153655.GM17271@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=acolin@isi.edu \
    --cc=akpm@linux-foundation.org \
    --cc=alex.bou9@gmail.com \
    --cc=arnd@arndb.de \
    --cc=jwalters@isi.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@linux-mips.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.