From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
linux-pci@vger.kernel.org,
"Russell King" <linux@arm.linux.org.uk>,
"Antoine Tenart" <antoine.tenart@bootlin.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
"Nadav Haklai" <nadavh@marvell.com>,
"Victor Gu" <xigu@marvell.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
"Zachary Zhang" <zhangzg@marvell.com>,
"Wilson Ding" <dingwei@marvell.com>,
linux-arm-kernel@lists.infradead.org,
"Ray Jui" <ray.jui@broadcom.com>,
"Ley Foon Tan" <lftan@altera.com>,
"Simon Horman" <horms@verge.net.au>
Subject: Re: [PATCH 1/3] PCI: Introduce PCI software bridge common logic
Date: Wed, 1 Aug 2018 13:13:14 +0200 [thread overview]
Message-ID: <20180801131314.360c9454@windsurf> (raw)
In-Reply-To: <20180801104957.1b01b847@windsurf>
Bjorn,
On Wed, 1 Aug 2018 10:49:57 +0200, Thomas Petazzoni wrote:
> > I wonder if there's a way to use a common helper function to do this.
>
> Yes, this small bit of logic is duplicated all over the place. I'll see
> if I can come up with some reasonable helpers for that.
Here is an attempt at doing this:
- Introduce some helpers
https://github.com/MISL-EBU-System-SW/mainline-public/commit/55543d2050d9aa3abe297569be830bde8680e1e9
- Use them in drivers/pci/access.c
https://github.com/MISL-EBU-System-SW/mainline-public/commit/ce6158d5c6a039e0cddf5ee6840dadeb46c5fc4b
- Use them in PCI host controller drivers
https://github.com/MISL-EBU-System-SW/mainline-public/commit/df4d0b5272ea3b4c3226c96466e5360c5a89253f
I'm not a big fan of the naming though. Let me know what you think, if
you think it's worth it, I'll submit the patches.
Note: the whole thing is compile-tested only for now.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
WARNING: multiple messages have this Message-ID (diff)
From: thomas.petazzoni@bootlin.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] PCI: Introduce PCI software bridge common logic
Date: Wed, 1 Aug 2018 13:13:14 +0200 [thread overview]
Message-ID: <20180801131314.360c9454@windsurf> (raw)
In-Reply-To: <20180801104957.1b01b847@windsurf>
Bjorn,
On Wed, 1 Aug 2018 10:49:57 +0200, Thomas Petazzoni wrote:
> > I wonder if there's a way to use a common helper function to do this.
>
> Yes, this small bit of logic is duplicated all over the place. I'll see
> if I can come up with some reasonable helpers for that.
Here is an attempt at doing this:
- Introduce some helpers
https://github.com/MISL-EBU-System-SW/mainline-public/commit/55543d2050d9aa3abe297569be830bde8680e1e9
- Use them in drivers/pci/access.c
https://github.com/MISL-EBU-System-SW/mainline-public/commit/ce6158d5c6a039e0cddf5ee6840dadeb46c5fc4b
- Use them in PCI host controller drivers
https://github.com/MISL-EBU-System-SW/mainline-public/commit/df4d0b5272ea3b4c3226c96466e5360c5a89253f
I'm not a big fan of the naming though. Let me know what you think, if
you think it's worth it, I'll submit the patches.
Note: the whole thing is compile-tested only for now.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-01 11:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 9:22 [PATCH 0/3] PCI: emulated PCI bridge common logic Thomas Petazzoni
2018-06-29 9:22 ` Thomas Petazzoni
2018-06-29 9:22 ` [PATCH 1/3] PCI: Introduce PCI software " Thomas Petazzoni
2018-06-29 9:22 ` Thomas Petazzoni
2018-07-12 19:58 ` Bjorn Helgaas
2018-07-12 19:58 ` Bjorn Helgaas
2018-08-01 8:49 ` Thomas Petazzoni
2018-08-01 8:49 ` Thomas Petazzoni
2018-08-01 9:21 ` Russell King - ARM Linux
2018-08-01 9:21 ` Russell King - ARM Linux
2018-08-01 9:37 ` Thomas Petazzoni
2018-08-01 9:37 ` Thomas Petazzoni
2018-08-01 9:54 ` Thomas Petazzoni
2018-08-01 9:54 ` Thomas Petazzoni
2018-08-01 11:13 ` Thomas Petazzoni [this message]
2018-08-01 11:13 ` Thomas Petazzoni
2018-06-29 9:22 ` [PATCH 2/3] PCI: mvebu: Convert to PCI software bridge Thomas Petazzoni
2018-06-29 9:22 ` Thomas Petazzoni
2018-06-29 9:22 ` [PATCH 3/3] PCI: aardvark: Implement emulated root PCI bridge Thomas Petazzoni
2018-06-29 9:22 ` Thomas Petazzoni
2022-01-07 21:27 ` Bjorn Helgaas
2022-01-07 21:27 ` Bjorn Helgaas
2022-01-07 23:17 ` Bjorn Helgaas
2022-01-07 23:17 ` Bjorn Helgaas
2022-01-10 9:17 ` Pali Rohár
2022-01-10 9:17 ` Pali Rohár
2022-01-10 2:21 ` Marek Behún
2022-01-10 2:21 ` Marek Behún
2018-07-12 9:24 ` [PATCH 0/3] PCI: emulated PCI bridge common logic Thomas Petazzoni
2018-07-12 9:24 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801131314.360c9454@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=antoine.tenart@bootlin.com \
--cc=bhelgaas@google.com \
--cc=dingwei@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=helgaas@kernel.org \
--cc=horms@verge.net.au \
--cc=lftan@altera.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=miquel.raynal@bootlin.com \
--cc=nadavh@marvell.com \
--cc=ray.jui@broadcom.com \
--cc=xigu@marvell.com \
--cc=zhangzg@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.