From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 7/8] net: phy: Add support to configure clock in Broadcom iProc mdio mux
Date: Wed, 1 Aug 2018 22:07:12 +0200 [thread overview]
Message-ID: <20180801200712.GD19257@lunn.ch> (raw)
In-Reply-To: <9af7e7a3-54d4-8802-f64a-fc4f9c49c8b9@broadcom.com>
> My intention was to proceed with probe if the clock is not found in the DT.
> If the clock is specified in the DT, make use of it.
You might want to look at what phy_optional_get() does. If the phy
does not exist in DT, it does not return an error, but a NULL phy.
You can pass NULL to all the other calls generic phy_ calls. If there
is a real error, it returns it. That makes the driver code much
simpler.
You might want to consider adding clk_optional_get() and
devm_clk_optional_get().
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Arun Parameswaran <arun.parameswaran@broadcom.com>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 7/8] net: phy: Add support to configure clock in Broadcom iProc mdio mux
Date: Wed, 1 Aug 2018 22:07:12 +0200 [thread overview]
Message-ID: <20180801200712.GD19257@lunn.ch> (raw)
In-Reply-To: <9af7e7a3-54d4-8802-f64a-fc4f9c49c8b9@broadcom.com>
> My intention was to proceed with probe if the clock is not found in the DT.
> If the clock is specified in the DT, make use of it.
You might want to look at what phy_optional_get() does. If the phy
does not exist in DT, it does not return an error, but a NULL phy.
You can pass NULL to all the other calls generic phy_ calls. If there
is a real error, it returns it. That makes the driver code much
simpler.
You might want to consider adding clk_optional_get() and
devm_clk_optional_get().
Andrew
next prev parent reply other threads:[~2018-08-01 20:07 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-01 17:56 [PATCH v3 0/8] Add clock config and pm support to bcm iProc mdio mux Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 17:56 ` [PATCH v3 1/8] dt-bindings: net: Fix Broadcom iProc mdio mux driver base address Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 17:56 ` [PATCH v3 2/8] net: phy: Fix the register offsets in Broadcom iProc mdio mux driver Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 17:56 ` [PATCH v3 3/8] arm64: dts: Fix the base address of the Broadcom iProc mdio mux Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 17:56 ` [PATCH v3 4/8] net: phy: Disable external master access in bcm mdio mux driver Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 17:56 ` [PATCH v3 5/8] net: phy: Use devm api for mdio bus allocation in bcm iproc mdio mux Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 18:37 ` Florian Fainelli
2018-08-01 18:37 ` Florian Fainelli
2018-08-01 17:56 ` [PATCH v3 6/8] dt-bindings: net: Add clock handle to Broadcom iProc " Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 17:56 ` [PATCH v3 7/8] net: phy: Add support to configure clock in " Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 18:40 ` Florian Fainelli
2018-08-01 18:40 ` Florian Fainelli
2018-08-01 18:46 ` Russell King - ARM Linux
2018-08-01 18:46 ` Russell King - ARM Linux
2018-08-01 19:55 ` Arun Parameswaran
2018-08-01 19:55 ` Arun Parameswaran
2018-08-01 20:07 ` Andrew Lunn [this message]
2018-08-01 20:07 ` Andrew Lunn
2018-08-01 20:23 ` Russell King - ARM Linux
2018-08-01 20:23 ` Russell King - ARM Linux
2018-08-01 20:38 ` Andrew Lunn
2018-08-01 20:38 ` Andrew Lunn
2018-08-01 21:45 ` Arun Parameswaran
2018-08-01 21:45 ` Arun Parameswaran
2018-08-01 21:55 ` Andrew Lunn
2018-08-01 21:55 ` Andrew Lunn
2018-08-01 22:10 ` Arun Parameswaran
2018-08-01 22:10 ` Arun Parameswaran
2018-08-01 22:18 ` Andrew Lunn
2018-08-01 22:18 ` Andrew Lunn
2018-08-01 17:56 ` [PATCH v3 8/8] net: phy: Add pm support to Broadcom iProc mdio mux driver Arun Parameswaran
2018-08-01 17:56 ` Arun Parameswaran
2018-08-01 18:39 ` Florian Fainelli
2018-08-01 18:39 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801200712.GD19257@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.