From: Boris Brezillon <boris.brezillon@bootlin.com>
To: Mark Brown <broonie@kernel.org>
Cc: Piotr Bugalski <bugalski.piotr@gmail.com>,
linux-spi@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Cyrille Pitchen <cyrille.pitchen@microchip.com>,
Tudor Ambarus <tudor.ambarus@microchip.com>,
Piotr Bugalski <pbu@cryptera.com>
Subject: Re: [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2
Date: Wed, 1 Aug 2018 21:57:33 +0200 [thread overview]
Message-ID: <20180801215733.4dfa3a95@bbrezillon> (raw)
In-Reply-To: <20180801172747.GJ5509@sirena.org.uk>
Hi Mark,
On Wed, 1 Aug 2018 18:27:47 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 27, 2018 at 03:16:08PM +0200, Piotr Bugalski wrote:
> > Kernel contains QSPI driver strongly tied to MTD and nor-flash memory.
> > New spi-mem interface allows usage also other memory types, especially
> > much larger NAND with SPI interface. This driver works as SPI controller
> > and is not related to MTD, however can work with NAND-flash or other
> > peripherals using spi-mem interface.
>
> This is fine from a SPI point of view
Cool. There are still 2 things I think should be addressed before
merging the driver:
1/ Fixing the SoB tag to match the author (problem reported by
Alexandre)
2/ Getting this patch [1] merged and implementing the ->get_name() hook
in this driver so that SPI NOR devs declared to the MTD layer keep
the same name after the transition to spi-mem and mtdparts= passed on
the cmdline keep working. Without this in place we're likely to
break a few setups :-/.
> but I'd like to apply it directly
> to the SPI tree rather than ack it for merge via the MTD tree - can we
> work something out with a shared branch or something?
Sure, I can provide an immutable tag for you to pull and I'll add my
acks on those patches once the 2 things I mentioned above are
addressed.
Regards,
Boris
[1]https://patchwork.kernel.org/patch/10508693/
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@bootlin.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2
Date: Wed, 1 Aug 2018 21:57:33 +0200 [thread overview]
Message-ID: <20180801215733.4dfa3a95@bbrezillon> (raw)
In-Reply-To: <20180801172747.GJ5509@sirena.org.uk>
Hi Mark,
On Wed, 1 Aug 2018 18:27:47 +0100
Mark Brown <broonie@kernel.org> wrote:
> On Wed, Jun 27, 2018 at 03:16:08PM +0200, Piotr Bugalski wrote:
> > Kernel contains QSPI driver strongly tied to MTD and nor-flash memory.
> > New spi-mem interface allows usage also other memory types, especially
> > much larger NAND with SPI interface. This driver works as SPI controller
> > and is not related to MTD, however can work with NAND-flash or other
> > peripherals using spi-mem interface.
>
> This is fine from a SPI point of view
Cool. There are still 2 things I think should be addressed before
merging the driver:
1/ Fixing the SoB tag to match the author (problem reported by
Alexandre)
2/ Getting this patch [1] merged and implementing the ->get_name() hook
in this driver so that SPI NOR devs declared to the MTD layer keep
the same name after the transition to spi-mem and mtdparts= passed on
the cmdline keep working. Without this in place we're likely to
break a few setups :-/.
> but I'd like to apply it directly
> to the SPI tree rather than ack it for merge via the MTD tree - can we
> work something out with a shared branch or something?
Sure, I can provide an immutable tag for you to pull and I'll add my
acks on those patches once the 2 things I mentioned above are
addressed.
Regards,
Boris
[1]https://patchwork.kernel.org/patch/10508693/
next prev parent reply other threads:[~2018-08-01 19:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-27 13:16 [RFC PATCH v2 0/6] New QuadSPI driver for Atmel SAMA5D2 Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-06-27 13:16 ` [RFC PATCH v2 1/6] mtd: spi-nor: atmel-quaspi: Typo fix Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-07-03 12:52 ` Alexandre Belloni
2018-07-03 12:52 ` Alexandre Belloni
2018-07-05 7:26 ` Piotr Bugalski
2018-07-05 7:26 ` Piotr Bugalski
2018-06-27 13:16 ` [RFC PATCH v2 2/6] mtd: spi-nor: atmel-quadspi: Add spi-mem support to atmel-quadspi Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-06-27 13:16 ` [RFC PATCH v2 3/6] mtd: spi-nor: atmel-quadspi: Use spi-mem interface for atmel-quadspi driver Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-06-27 13:16 ` [RFC PATCH v2 4/6] mtd: spi-nor: atmel-quadspi: Remove unused code from " Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-06-27 13:16 ` [RFC PATCH v2 5/6] spi: Add QuadSPI driver for Atmel SAMA5D2 Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-08-01 17:27 ` Mark Brown
2018-08-01 17:27 ` Mark Brown
2018-08-01 17:27 ` Mark Brown
2018-08-01 19:57 ` Boris Brezillon [this message]
2018-08-01 19:57 ` Boris Brezillon
2018-08-02 10:17 ` Mark Brown
2018-08-02 10:17 ` Mark Brown
2018-08-02 10:46 ` Frieder Schrempf
2018-08-02 10:46 ` Frieder Schrempf
2018-08-02 11:46 ` Mark Brown
2018-08-02 11:46 ` Mark Brown
2018-08-02 11:48 ` Boris Brezillon
2018-08-02 11:48 ` Boris Brezillon
2018-06-27 13:16 ` [RFC PATCH v2 6/6] dt-bindings: spi: " Piotr Bugalski
2018-06-27 13:16 ` Piotr Bugalski
2018-07-03 22:45 ` Rob Herring
2018-07-03 22:45 ` Rob Herring
2018-10-31 13:43 ` [RFC PATCH v2 0/6] New " Boris Brezillon
2018-10-31 13:43 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180801215733.4dfa3a95@bbrezillon \
--to=boris.brezillon@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=bugalski.piotr@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@microchip.com \
--cc=pbu@cryptera.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tudor.ambarus@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.