* [PATCH] aoe: mark expected switch fall-through
@ 2018-08-01 22:30 Gustavo A. R. Silva
2018-08-02 15:59 ` Jens Axboe
2018-08-03 0:26 ` Ed Cashin
0 siblings, 2 replies; 3+ messages in thread
From: Gustavo A. R. Silva @ 2018-08-01 22:30 UTC (permalink / raw)
To: Ed L. Cashin, Jens Axboe; +Cc: linux-block, linux-kernel, Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Addresses-Coverity-ID: 114722 ("Missing break in switch")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/block/aoe/aoecmd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 096882e..136dc50 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -1137,6 +1137,7 @@ noskb: if (buf)
break;
}
bvcpy(skb, f->buf->bio, f->iter, n);
+ /* fall through */
case ATA_CMD_PIO_WRITE:
case ATA_CMD_PIO_WRITE_EXT:
spin_lock_irq(&d->lock);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] aoe: mark expected switch fall-through
2018-08-01 22:30 [PATCH] aoe: mark expected switch fall-through Gustavo A. R. Silva
@ 2018-08-02 15:59 ` Jens Axboe
2018-08-03 0:26 ` Ed Cashin
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2018-08-02 15:59 UTC (permalink / raw)
To: Gustavo A. R. Silva, Ed L. Cashin; +Cc: linux-block, linux-kernel
On 8/1/18 4:30 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
Applied for 4.19, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] aoe: mark expected switch fall-through
2018-08-01 22:30 [PATCH] aoe: mark expected switch fall-through Gustavo A. R. Silva
2018-08-02 15:59 ` Jens Axboe
@ 2018-08-03 0:26 ` Ed Cashin
1 sibling, 0 replies; 3+ messages in thread
From: Ed Cashin @ 2018-08-03 0:26 UTC (permalink / raw)
To: gustavo; +Cc: Ed L. Cashin, axboe, linux-block, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 756 bytes --]
On Wed, Aug 1, 2018 at 6:30 PM Gustavo A. R. Silva <gustavo@embeddedor.com>
wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
OK, thanks.
>
> diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
> index 096882e..136dc50 100644
> --- a/drivers/block/aoe/aoecmd.c
> +++ b/drivers/block/aoe/aoecmd.c
> @@ -1137,6 +1137,7 @@ noskb: if (buf)
> break;
> }
> bvcpy(skb, f->buf->bio, f->iter, n);
> + /* fall through */
> case ATA_CMD_PIO_WRITE:
> case ATA_CMD_PIO_WRITE_EXT:
> spin_lock_irq(&d->lock);
> --
> 2.7.4
>
>
--
Ed Cashin <ecashin@noserose.net>
[-- Attachment #2: Type: text/html, Size: 1468 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-03 0:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-01 22:30 [PATCH] aoe: mark expected switch fall-through Gustavo A. R. Silva
2018-08-02 15:59 ` Jens Axboe
2018-08-03 0:26 ` Ed Cashin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.